From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: Change bitmap truncate conditional to assertion
Date: Wed, 10 Jun 2015 14:52:01 -0600 [thread overview]
Message-ID: <5578A371.2060602@redhat.com> (raw)
In-Reply-To: <1433957094-8303-1-git-send-email-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
On 06/10/2015 11:24 AM, John Snow wrote:
> Requires: 1433796555-5608-1-git-send-email-jsnow@redhat.com
> [PATCH] block: record new size in bdrv_dirty_bitmap_truncate
>
Shouldn't this be after the '---' separator?
> This is an artifact of an older version that had both all-bitmap and
> single-bitmap truncate functions, and some info got lost in the shuffle.
>
> Bitmaps can only be frozen during a backup operation, and a backup
> operation should prevent a resize operation, so just assert that this
> cannot happen.
>
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> block.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-06-10 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 17:24 [Qemu-devel] [PATCH] block: Change bitmap truncate conditional to assertion John Snow
2015-06-10 20:52 ` Eric Blake [this message]
2015-06-10 20:55 ` John Snow
2015-06-11 8:26 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5578A371.2060602@redhat.com \
--to=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.