All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 08/15] fs/iso9660: support building a real iso9660 filesystem
Date: Sun, 14 Jun 2015 23:20:58 +0200	[thread overview]
Message-ID: <20150614232058.7fe8d702@free-electrons.com> (raw)
In-Reply-To: <20150614151740.GF3615@free.fr>

Dear Yann E. MORIN,

On Sun, 14 Jun 2015 17:17:40 +0200, Yann E. MORIN wrote:

> I have to admit I was not very confortable reviewing this patch, because
> the splashscreen settign are split in two locations, and checking all
> possible code paths (not that many, but still) to ensure splashscreen
> was either properly copied or disabled, was not trivial.

Yes, the splashscreen handling is split because:

 * We want to remove the splashscreen related line in menu.lst if Grub
   hasn't been built with splashscreen support, and this in both
   iso9660 as the real root filesystem *and* iso9660 using
   initrd/initramfs.

 * We want to copy the splashscreen image to the temporary target dir
   only if we're doing iso9660 using initrd/initramfs (not needed if
   iso9660 is the real root filesystem, since the splashscreen has
   already been installed by grub.mk).

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-06-14 21:20 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08 22:21 [Buildroot] [PATCHv2 00/15] iso9660 support improvements Thomas Petazzoni
2015-06-08 22:21 ` [Buildroot] [PATCHv2 01/15] fs/iso9660: use if ... endif block instead of depends on Thomas Petazzoni
2015-06-08 22:21 ` [Buildroot] [PATCHv2 02/15] fs/iso9660: convert to the filesystem infrastructure Thomas Petazzoni
2015-06-14 14:52   ` Yann E. MORIN
2015-06-08 22:21 ` [Buildroot] [PATCHv2 03/15] fs/iso9660: enable Joliet extension Thomas Petazzoni
2015-06-08 22:21 ` [Buildroot] [PATCHv2 04/15] fs/iso9660: rename all variables to use the ROOTFS_ISO9660 prefix Thomas Petazzoni
2015-06-08 22:21 ` [Buildroot] [PATCHv2 05/15] fs/iso9660: change the location of the splash image Thomas Petazzoni
2015-06-08 22:21 ` [Buildroot] [PATCHv2 06/15] fs/iso9660: get grub splash from $(TARGET_DIR) Thomas Petazzoni
2015-06-14 14:59   ` Yann E. MORIN
2015-06-08 22:21 ` [Buildroot] [PATCHv2 07/15] fs/iso9660: prepare cleaner kernel/initrd path handling Thomas Petazzoni
2015-06-08 22:21 ` [Buildroot] [PATCHv2 08/15] fs/iso9660: support building a real iso9660 filesystem Thomas Petazzoni
2015-06-14 15:17   ` Yann E. MORIN
2015-06-14 21:20     ` Thomas Petazzoni [this message]
2015-06-08 22:21 ` [Buildroot] [PATCHv2 09/15] fs/iso9660: introduce new variables Thomas Petazzoni
2015-06-14 15:25   ` Yann E. MORIN
2015-06-08 22:21 ` [Buildroot] [PATCHv2 10/15] fs/iso9660: introduce bootloader choice Thomas Petazzoni
2015-06-14 15:39   ` Yann E. MORIN
2015-06-08 22:21 ` [Buildroot] [PATCHv2 11/15] fs/iso9660: use 'depends on' instead of 'select' for bootloader Thomas Petazzoni
2015-06-14 15:40   ` Yann E. MORIN
2015-06-08 22:21 ` [Buildroot] [PATCHv2 12/15] fs/iso9660: add isolinux support Thomas Petazzoni
2015-06-14 15:47   ` Yann E. MORIN
2015-06-14 21:24     ` Thomas Petazzoni
2015-06-08 22:21 ` [Buildroot] [PATCHv2 13/15] fs/iso9660: add hybrid image support Thomas Petazzoni
2015-06-14 15:49   ` Yann E. MORIN
2015-06-14 15:49   ` Yann E. MORIN
2015-07-27  9:24   ` Noé RUBINSTEIN
2015-07-27  9:42     ` Thomas Petazzoni
2015-06-08 22:21 ` [Buildroot] [PATCHv2 14/15] grub2: prepare and install El Torito image Thomas Petazzoni
2015-06-14 15:50   ` Yann E. MORIN
2015-06-08 22:21 ` [Buildroot] [PATCHv2 15/15] fs/iso9660: add support for grub2 Thomas Petazzoni
2015-06-14 15:56   ` Yann E. MORIN
2015-06-14 21:26     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150614232058.7fe8d702@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.