From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: orion5x: Use vsprintf %pM extension
Date: Mon, 15 Jun 2015 05:28:42 +0200 [thread overview]
Message-ID: <20150615032842.GD10886@lunn.ch> (raw)
In-Reply-To: <1434333690.2507.30.camel@perches.com>
On Sun, Jun 14, 2015 at 07:01:30PM -0700, Joe Perches wrote:
> Format mac addresses with the normal kernel extension.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Andrew
> ---
> arch/arm/mach-orion5x/dns323-setup.c | 4 +---
> arch/arm/mach-orion5x/tsx09-common.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-orion5x/dns323-setup.c b/arch/arm/mach-orion5x/dns323-setup.c
> index 09d2a26..f267e58 100644
> --- a/arch/arm/mach-orion5x/dns323-setup.c
> +++ b/arch/arm/mach-orion5x/dns323-setup.c
> @@ -236,9 +236,7 @@ static int __init dns323_read_mac_addr(void)
> }
>
> iounmap(mac_page);
> - printk("DNS-323: Found ethernet MAC address: ");
> - for (i = 0; i < 6; i++)
> - printk("%.2x%s", addr[i], (i < 5) ? ":" : ".\n");
> + printk("DNS-323: Found ethernet MAC address: %pM\n", addr);
>
> memcpy(dns323_eth_data.mac_addr, addr, 6);
>
> diff --git a/arch/arm/mach-orion5x/tsx09-common.c b/arch/arm/mach-orion5x/tsx09-common.c
> index 7189827..24b2959 100644
> --- a/arch/arm/mach-orion5x/tsx09-common.c
> +++ b/arch/arm/mach-orion5x/tsx09-common.c
> @@ -101,9 +101,7 @@ static int __init qnap_tsx09_check_mac_addr(const char *addr_str)
> addr[i] = byte;
> }
>
> - printk(KERN_INFO "tsx09: found ethernet mac address ");
> - for (i = 0; i < 6; i++)
> - printk("%.2x%s", addr[i], (i < 5) ? ":" : ".\n");
> + printk(KERN_INFO "tsx09: found ethernet mac address %pM\n", addr);
>
> memcpy(qnap_tsx09_eth_data.mac_addr, addr, 6);
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Joe Perches <joe@perches.com>
Cc: Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: orion5x: Use vsprintf %pM extension
Date: Mon, 15 Jun 2015 05:28:42 +0200 [thread overview]
Message-ID: <20150615032842.GD10886@lunn.ch> (raw)
In-Reply-To: <1434333690.2507.30.camel@perches.com>
On Sun, Jun 14, 2015 at 07:01:30PM -0700, Joe Perches wrote:
> Format mac addresses with the normal kernel extension.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Andrew
> ---
> arch/arm/mach-orion5x/dns323-setup.c | 4 +---
> arch/arm/mach-orion5x/tsx09-common.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-orion5x/dns323-setup.c b/arch/arm/mach-orion5x/dns323-setup.c
> index 09d2a26..f267e58 100644
> --- a/arch/arm/mach-orion5x/dns323-setup.c
> +++ b/arch/arm/mach-orion5x/dns323-setup.c
> @@ -236,9 +236,7 @@ static int __init dns323_read_mac_addr(void)
> }
>
> iounmap(mac_page);
> - printk("DNS-323: Found ethernet MAC address: ");
> - for (i = 0; i < 6; i++)
> - printk("%.2x%s", addr[i], (i < 5) ? ":" : ".\n");
> + printk("DNS-323: Found ethernet MAC address: %pM\n", addr);
>
> memcpy(dns323_eth_data.mac_addr, addr, 6);
>
> diff --git a/arch/arm/mach-orion5x/tsx09-common.c b/arch/arm/mach-orion5x/tsx09-common.c
> index 7189827..24b2959 100644
> --- a/arch/arm/mach-orion5x/tsx09-common.c
> +++ b/arch/arm/mach-orion5x/tsx09-common.c
> @@ -101,9 +101,7 @@ static int __init qnap_tsx09_check_mac_addr(const char *addr_str)
> addr[i] = byte;
> }
>
> - printk(KERN_INFO "tsx09: found ethernet mac address ");
> - for (i = 0; i < 6; i++)
> - printk("%.2x%s", addr[i], (i < 5) ? ":" : ".\n");
> + printk(KERN_INFO "tsx09: found ethernet mac address %pM\n", addr);
>
> memcpy(qnap_tsx09_eth_data.mac_addr, addr, 6);
>
>
>
next prev parent reply other threads:[~2015-06-15 3:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 2:01 [PATCH] ARM: orion5x: Use vsprintf %pM extension Joe Perches
2015-06-15 2:01 ` Joe Perches
2015-06-15 3:28 ` Andrew Lunn [this message]
2015-06-15 3:28 ` Andrew Lunn
2015-06-17 14:53 ` Gregory CLEMENT
2015-06-17 14:53 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615032842.GD10886@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.