All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: Recalculate journal credits as inode depth changes
Date: Mon, 15 Jun 2015 00:22:56 -0400	[thread overview]
Message-ID: <20150615042256.GG15793@thunk.org> (raw)
In-Reply-To: <1433833126-28575-1-git-send-email-lczerner@redhat.com>

On Tue, Jun 09, 2015 at 08:58:45AM +0200, Lukas Czerner wrote:
> Currently in ext4_alloc_file_blocks() the number of credits is
> calculated only once before we enter the allocation loop. However within
> the allocation loop the extent tree depth can change, hence the number
> of credits needed can increase potentially exceeding the number of credits
> reserved in the handle which can cause journal failures.
> 
> Fix this by recalculating number of credits when the inode depth
> changes. Note that even though ext4_alloc_file_blocks() is only
> currently used by extent base inodes we will avoid recalculating number
> of credits unnecessarily in the case of indirect based inodes.
> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>

Thanks, applied.

					- Ted

      parent reply	other threads:[~2015-06-15  4:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09  6:58 [PATCH 1/2] ext4: Recalculate journal credits as inode depth changes Lukas Czerner
2015-06-09  6:58 ` [PATCH 2/2] ext4: Wait for existing dio workers in ext4_alloc_file_blocks() Lukas Czerner
2015-06-15  4:25   ` Theodore Ts'o
2015-06-15  4:22 ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150615042256.GG15793@thunk.org \
    --to=tytso@mit.edu \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.