All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: Wait for existing dio workers in ext4_alloc_file_blocks()
Date: Mon, 15 Jun 2015 00:25:54 -0400	[thread overview]
Message-ID: <20150615042554.GH15793@thunk.org> (raw)
In-Reply-To: <1433833126-28575-2-git-send-email-lczerner@redhat.com>

On Tue, Jun 09, 2015 at 08:58:46AM +0200, Lukas Czerner wrote:
> Currently existing dio workers can jump in and potentially increase
> extent tree depth while we're allocating blocks in
> ext4_alloc_file_blocks(). This may cause us to underestimate the number
> of credits needed for the transaction because the extent tree depth can
> change after our estimation.
> 
> Fix this by waiting for all the existing dio workers in the same way as
> we do it in ext4_punch_hole. We've seen errors caused by this in xfstest
> generic/299, however it's really hard to reproduce.
> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>

Thanks, applied.

						- Ted

  reply	other threads:[~2015-06-15  4:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09  6:58 [PATCH 1/2] ext4: Recalculate journal credits as inode depth changes Lukas Czerner
2015-06-09  6:58 ` [PATCH 2/2] ext4: Wait for existing dio workers in ext4_alloc_file_blocks() Lukas Czerner
2015-06-15  4:25   ` Theodore Ts'o [this message]
2015-06-15  4:22 ` [PATCH 1/2] ext4: Recalculate journal credits as inode depth changes Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150615042554.GH15793@thunk.org \
    --to=tytso@mit.edu \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.