Re: [Qemu-devel] [PATCH v4 3/8] cpus: Add a macro to walk CPUs in reverse

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]

On Fri, Jun 05, 2015 at 11:39:18PM +0900, Andreas Färber wrote:
> Am 05.06.2015 um 13:25 schrieb Bharata B Rao:
> > Add CPU_FOREACH_REVERSE that walks CPUs in reverse.
> > 
> > Needed for PowerPC CPU device tree reorganization.
> > 
> > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> > Cc: Andreas Färber <afaerber@suse.de>
> > ---
> >  include/qom/cpu.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/include/qom/cpu.h b/include/qom/cpu.h
> > index 39f0f19..42f42f5 100644
> > --- a/include/qom/cpu.h
> > +++ b/include/qom/cpu.h
> > @@ -323,6 +323,8 @@ extern struct CPUTailQ cpus;
> >  #define CPU_FOREACH(cpu) QTAILQ_FOREACH(cpu, &cpus, node)
> >  #define CPU_FOREACH_SAFE(cpu, next_cpu) \
> >      QTAILQ_FOREACH_SAFE(cpu, &cpus, node, next_cpu)
> > +#define CPU_FOREACH_REVERSE(cpu) \
> > +    QTAILQ_FOREACH_REVERSE(cpu, &cpus, CPUTailQ, node)
> >  #define first_cpu QTAILQ_FIRST(&cpus)
> >  
> >  DECLARE_TLS(CPUState *, current_cpu);
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>

I'm hoping to merge the parts of this series that affect the spapr
code (most of it) shortly.  Should this patch go through another tree
though?

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]