[PATCH] hp_wireless: remove unused header files

[PATCH] hp_wireless: remove unused header files

[Alex Hung]

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 drivers/platform/x86/hp-wireless.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/platform/x86/hp-wireless.c b/drivers/platform/x86/hp-wireless.c
index 4e4cc8b..731c69b 100644
--- a/drivers/platform/x86/hp-wireless.c
+++ b/drivers/platform/x86/hp-wireless.c
@@ -18,11 +18,8 @@
  *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-#include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/init.h>
 #include <linux/input.h>
-#include <linux/platform_device.h>
 #include <linux/acpi.h>
 #include <acpi/acpi_bus.h>
 
-- 
1.7.9.5

Re: [PATCH] hp_wireless: remove unused header files

[Darren Hart]

On Wed, Jun 10, 2015 at 05:26:27PM +0800, Alex Hung wrote:

No commit message again.

If you feel there is nothing to say in the commit message, do a git log search
for similar patches for examples of what is relevant. (There are several for
removing unused header files)

Please don't send another like this.

> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  drivers/platform/x86/hp-wireless.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/hp-wireless.c b/drivers/platform/x86/hp-wireless.c
> index 4e4cc8b..731c69b 100644
> --- a/drivers/platform/x86/hp-wireless.c
> +++ b/drivers/platform/x86/hp-wireless.c
> @@ -18,11 +18,8 @@
>   *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>   */
>  
> -#include <linux/kernel.h>
>  #include <linux/module.h>
> -#include <linux/init.h>
>  #include <linux/input.h>
> -#include <linux/platform_device.h>
>  #include <linux/acpi.h>
>  #include <acpi/acpi_bus.h>
>  

What was your motivation here? Did you observe a change in the driver? A
subsystem? Run a tool?

Note that acpi.h also includes acpi/acpi_bus.h, so it isn't strictly
necessary either.

Please explain your motivation and rationale. If it's worth preparing, building,
and testing, it's worth documenting.

-- 
Darren Hart
Intel Open Source Technology Center