From: Greg KH <gregkh@linuxfoundation.org>
To: Juston Li <juston.h.li@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: sm750fb: use tabs for indentation
Date: Sat, 20 Jun 2015 05:21:31 +0000 [thread overview]
Message-ID: <20150620052131.GA21984@kroah.com> (raw)
In-Reply-To: <1434777191-16946-1-git-send-email-juston.h.li@gmail.com>
On Fri, Jun 19, 2015 at 10:13:11PM -0700, Juston Li wrote:
> Replace spaces with tabs for indentation to fix the checkpatch.pl warning
> 'WARNING: please, no spaces at the start of a line'
>
> checkpatch doesn't catch comments indented by spaces but I fixed comments
> adjacent to warnings as well so they would remain aligned.
>
> Changes since v1:
> fix alignment in ddk750_display.c:154
> didn't remove a space in ddk750_hwi2c.c:48
The version info here should go below the --- line, so it doesn't show
up in the changelog itself.
third time's a charm?
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Juston Li <juston.h.li@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: sm750fb: use tabs for indentation
Date: Fri, 19 Jun 2015 22:21:31 -0700 [thread overview]
Message-ID: <20150620052131.GA21984@kroah.com> (raw)
In-Reply-To: <1434777191-16946-1-git-send-email-juston.h.li@gmail.com>
On Fri, Jun 19, 2015 at 10:13:11PM -0700, Juston Li wrote:
> Replace spaces with tabs for indentation to fix the checkpatch.pl warning
> 'WARNING: please, no spaces at the start of a line'
>
> checkpatch doesn't catch comments indented by spaces but I fixed comments
> adjacent to warnings as well so they would remain aligned.
>
> Changes since v1:
> fix alignment in ddk750_display.c:154
> didn't remove a space in ddk750_hwi2c.c:48
The version info here should go below the --- line, so it doesn't show
up in the changelog itself.
third time's a charm?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-06-20 5:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 5:13 [PATCH v2] staging: sm750fb: use tabs for indentation Juston Li
2015-06-20 5:13 ` Juston Li
2015-06-20 5:21 ` Greg KH [this message]
2015-06-20 5:21 ` Greg KH
2015-06-20 5:49 ` Juston Li
2015-06-20 5:49 ` Juston Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150620052131.GA21984@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=juston.h.li@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.