From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Juston Li <juston.h.li@gmail.com>
Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: sm750fb: fix spacing issues
Date: Sat, 20 Jun 2015 10:59:51 +0000 [thread overview]
Message-ID: <20150620104751.GC29626@sudip-PC> (raw)
In-Reply-To: <1434790115-21683-2-git-send-email-juston.h.li@gmail.com>
On Sat, Jun 20, 2015 at 01:48:33AM -0700, Juston Li wrote:
> Fix spacing errors and warnings caught by checkpatch.pl
> ERROR: space prohibited after that open parenthesis '('
> ERROR: space required before the open brace '{'
> ERROR: need consistent spacing around
> ERROR: trailing whitespace
> WARNING: unnecessary whitespace before a quoted newline
these are again too many changes in a single patch. please break them
up so that each patch does a single type of change.
regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Juston Li <juston.h.li@gmail.com>
Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: sm750fb: fix spacing issues
Date: Sat, 20 Jun 2015 16:17:51 +0530 [thread overview]
Message-ID: <20150620104751.GC29626@sudip-PC> (raw)
In-Reply-To: <1434790115-21683-2-git-send-email-juston.h.li@gmail.com>
On Sat, Jun 20, 2015 at 01:48:33AM -0700, Juston Li wrote:
> Fix spacing errors and warnings caught by checkpatch.pl
> ERROR: space prohibited after that open parenthesis '('
> ERROR: space required before the open brace '{'
> ERROR: need consistent spacing around
> ERROR: trailing whitespace
> WARNING: unnecessary whitespace before a quoted newline
these are again too many changes in a single patch. please break them
up so that each patch does a single type of change.
regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-06-20 10:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 8:45 [PATCH 0/4] staging: sm750fb: checkpatch.pl fixes Juston Li
2015-06-20 8:45 ` Juston Li
2015-06-20 8:48 ` [PATCH 1/4] staging: sm750fb: use tabs for indentation Juston Li
2015-06-20 8:48 ` Juston Li
2015-06-20 10:45 ` Sudip Mukherjee
2015-06-20 10:57 ` Sudip Mukherjee
2015-06-20 15:40 ` Juston Li
2015-06-20 15:40 ` Juston Li
2015-06-20 8:48 ` [PATCH 2/4] staging: sm750fb: fix spacing issues Juston Li
2015-06-20 8:48 ` Juston Li
2015-06-20 10:47 ` Sudip Mukherjee [this message]
2015-06-20 10:59 ` Sudip Mukherjee
2015-06-20 8:48 ` [PATCH 3/4] staging: sm750fb: fix brace placement Juston Li
2015-06-20 8:48 ` Juston Li
2015-06-20 8:48 ` [PATCH 4/4] staging: sm750fb: add missing blank line after declarations Juston Li
2015-06-20 8:48 ` Juston Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150620104751.GC29626@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=juston.h.li@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.