From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: axboe@kernel.dk, linux-nvdimm@lists.01.org, boaz@plexistor.com,
toshi.kani@hp.com, Vishal Verma <vishal.l.verma@linux.intel.com>,
linux-kernel@vger.kernel.org, hch@lst.de,
linux-acpi@vger.kernel.org, linux-fsdevel@vger.kernel.org,
mingo@kernel.org
Subject: Re: [PATCH 11/15] libnvdimm: pmem, blk, and btt make_request cleanups
Date: Sun, 21 Jun 2015 12:10:55 +0200 [thread overview]
Message-ID: <20150621101055.GD5915@lst.de> (raw)
In-Reply-To: <20150617235546.12943.2374.stgit@dwillia2-desk3.amr.corp.intel.com>
One patch per driver please.
> diff --git a/drivers/nvdimm/blk.c b/drivers/nvdimm/blk.c
> index 8a6345797a71..9d609ef95266 100644
> --- a/drivers/nvdimm/blk.c
> +++ b/drivers/nvdimm/blk.c
> @@ -170,18 +170,12 @@ static void nd_blk_make_request(struct request_queue *q, struct bio *bio)
> struct bvec_iter iter;
> struct bio_vec bvec;
> int err = 0, rw;
> - sector_t sector;
>
> - sector = bio->bi_iter.bi_sector;
> - if (bio_end_sector(bio) > get_capacity(disk)) {
> + if (unlikely(bio_end_sector(bio) > get_capacity(disk))) {
> err = -EIO;
> goto out;
> }
>
> - BUG_ON(bio->bi_rw & REQ_DISCARD);
If you remove the DISCARD check you can kill the max sectors one
as well, given that generic_make_request_checks() takes care of it.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: axboe@kernel.dk, linux-nvdimm@ml01.01.org, boaz@plexistor.com,
toshi.kani@hp.com, Vishal Verma <vishal.l.verma@linux.intel.com>,
linux-kernel@vger.kernel.org, hch@lst.de,
linux-acpi@vger.kernel.org, linux-fsdevel@vger.kernel.org,
mingo@kernel.org
Subject: Re: [PATCH 11/15] libnvdimm: pmem, blk, and btt make_request cleanups
Date: Sun, 21 Jun 2015 12:10:55 +0200 [thread overview]
Message-ID: <20150621101055.GD5915@lst.de> (raw)
In-Reply-To: <20150617235546.12943.2374.stgit@dwillia2-desk3.amr.corp.intel.com>
One patch per driver please.
> diff --git a/drivers/nvdimm/blk.c b/drivers/nvdimm/blk.c
> index 8a6345797a71..9d609ef95266 100644
> --- a/drivers/nvdimm/blk.c
> +++ b/drivers/nvdimm/blk.c
> @@ -170,18 +170,12 @@ static void nd_blk_make_request(struct request_queue *q, struct bio *bio)
> struct bvec_iter iter;
> struct bio_vec bvec;
> int err = 0, rw;
> - sector_t sector;
>
> - sector = bio->bi_iter.bi_sector;
> - if (bio_end_sector(bio) > get_capacity(disk)) {
> + if (unlikely(bio_end_sector(bio) > get_capacity(disk))) {
> err = -EIO;
> goto out;
> }
>
> - BUG_ON(bio->bi_rw & REQ_DISCARD);
If you remove the DISCARD check you can kill the max sectors one
as well, given that generic_make_request_checks() takes care of it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-06-21 10:10 UTC|newest]
Thread overview: 164+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 23:54 [PATCH 00/15] libnvdimm: ->rw_bytes(), BLK-mode, unit tests, and misc features Dan Williams
2015-06-17 23:54 ` Dan Williams
2015-06-17 23:54 ` [PATCH 01/15] block: introduce an ->rw_bytes() block device operation Dan Williams
2015-06-17 23:54 ` Dan Williams
2015-06-18 19:25 ` Dan Williams
2015-06-18 19:25 ` Dan Williams
2015-06-17 23:54 ` [PATCH 02/15] libnvdimm: infrastructure for btt devices Dan Williams
2015-06-17 23:54 ` Dan Williams
2015-06-22 16:34 ` Christoph Hellwig
2015-06-22 16:34 ` Christoph Hellwig
2015-06-22 16:48 ` Dan Williams
2015-06-22 16:48 ` Dan Williams
2015-06-22 16:48 ` Christoph Hellwig
2015-06-22 16:48 ` Christoph Hellwig
2015-06-22 16:48 ` Christoph Hellwig
2015-06-22 18:32 ` Jeff Moyer
2015-06-22 18:32 ` Jeff Moyer
2015-06-22 18:32 ` Jeff Moyer
2015-06-22 19:02 ` Dan Williams
2015-06-22 19:02 ` Dan Williams
2015-06-22 19:02 ` Dan Williams
2015-06-22 19:09 ` Jeff Moyer
2015-06-22 19:09 ` Jeff Moyer
2015-06-22 19:09 ` Jeff Moyer
2015-06-23 10:20 ` Christoph Hellwig
2015-06-23 10:19 ` Christoph Hellwig
2015-06-23 15:19 ` Dan Williams
2015-06-23 20:33 ` Dan Williams
2015-06-24 12:10 ` Christoph Hellwig
2015-06-23 10:10 ` Christoph Hellwig
2015-06-17 23:55 ` [PATCH 03/15] nd_btt: atomic sector updates Dan Williams
2015-06-17 23:55 ` Dan Williams
2015-06-21 10:03 ` Christoph Hellwig
2015-06-21 10:03 ` Christoph Hellwig
2015-06-21 10:03 ` Christoph Hellwig
2015-06-21 16:31 ` Dan Williams
2015-06-21 16:31 ` Dan Williams
2015-06-17 23:55 ` [PATCH 04/15] libnvdimm, nfit, nd_blk: driver for BLK-mode access persistent memory Dan Williams
2015-06-17 23:55 ` Dan Williams
2015-06-21 10:05 ` Christoph Hellwig
2015-06-21 10:05 ` Christoph Hellwig
2015-06-21 10:05 ` Christoph Hellwig
2015-06-21 13:31 ` Dan Williams
2015-06-21 13:31 ` Dan Williams
2015-06-21 13:56 ` Christoph Hellwig
2015-06-21 13:56 ` Christoph Hellwig
2015-06-21 13:56 ` Christoph Hellwig
2015-06-21 14:39 ` Dan Williams
2015-06-21 14:39 ` Dan Williams
2015-06-21 14:39 ` Dan Williams
2015-06-17 23:55 ` [PATCH 05/15] tools/testing/nvdimm: libnvdimm unit test infrastructure Dan Williams
2015-06-17 23:55 ` Dan Williams
2015-06-17 23:55 ` [PATCH 06/15] libnvdimm: Non-Volatile Devices Dan Williams
2015-06-17 23:55 ` Dan Williams
2015-06-17 23:55 ` [PATCH 07/15] fs/block_dev.c: skip rw_page if bdev has integrity Dan Williams
2015-06-17 23:55 ` Dan Williams
2015-06-17 23:55 ` [PATCH 08/15] libnvdimm, btt: add support for blk integrity Dan Williams
2015-06-17 23:55 ` Dan Williams
2015-06-17 23:55 ` [PATCH 09/15] libnvdimm, blk: " Dan Williams
2015-06-17 23:55 ` Dan Williams
2015-06-17 23:55 ` [PATCH 10/15] libnvdimm: fix up max_hw_sectors Dan Williams
2015-06-17 23:55 ` Dan Williams
2015-06-21 10:08 ` Christoph Hellwig
2015-06-21 10:08 ` Christoph Hellwig
2015-06-21 10:08 ` Christoph Hellwig
2015-06-21 13:28 ` Dan Williams
2015-06-21 13:28 ` Dan Williams
2015-06-17 23:55 ` [PATCH 11/15] libnvdimm: pmem, blk, and btt make_request cleanups Dan Williams
2015-06-17 23:55 ` Dan Williams
2015-06-21 10:10 ` Christoph Hellwig [this message]
2015-06-21 10:10 ` Christoph Hellwig
2015-06-21 13:26 ` Dan Williams
2015-06-21 13:26 ` Dan Williams
2015-06-21 13:26 ` Dan Williams
2015-06-17 23:55 ` [PATCH 12/15] libnvdimm: enable iostat Dan Williams
2015-06-17 23:55 ` Dan Williams
2015-06-19 8:34 ` Christoph Hellwig
2015-06-19 8:34 ` Christoph Hellwig
2015-06-19 9:02 ` Dan Williams
2015-06-19 9:02 ` Dan Williams
2015-06-21 10:11 ` Christoph Hellwig
2015-06-21 10:11 ` Christoph Hellwig
2015-06-21 13:22 ` Dan Williams
2015-06-21 13:22 ` Dan Williams
2015-06-21 13:22 ` Dan Williams
2015-06-17 23:55 ` [PATCH 13/15] libnvdimm: flag libnvdimm block devices as non-rotational Dan Williams
2015-06-17 23:55 ` Dan Williams
2015-06-17 23:56 ` [PATCH 14/15] libnvdimm: support read-only btt backing devices Dan Williams
2015-06-17 23:56 ` Dan Williams
2015-06-18 22:55 ` Vishal Verma
2015-06-18 22:55 ` Vishal Verma
2015-06-21 10:13 ` Christoph Hellwig
2015-06-21 10:13 ` Christoph Hellwig
2015-06-21 13:21 ` Dan Williams
2015-06-21 13:21 ` Dan Williams
2015-06-21 13:21 ` Dan Williams
2015-06-21 13:54 ` Christoph Hellwig
2015-06-21 13:54 ` Christoph Hellwig
2015-06-21 13:54 ` Christoph Hellwig
2015-06-21 15:11 ` Dan Williams
2015-06-21 15:11 ` Dan Williams
2015-06-22 6:30 ` Christoph Hellwig
2015-06-22 6:30 ` Christoph Hellwig
2015-06-22 6:30 ` Christoph Hellwig
2015-06-22 7:17 ` Dan Williams
2015-06-22 7:17 ` Dan Williams
2015-06-22 7:17 ` Dan Williams
2015-06-22 7:28 ` Christoph Hellwig
2015-06-22 7:28 ` Christoph Hellwig
2015-06-22 7:28 ` Christoph Hellwig
2015-06-22 7:39 ` Dan Williams
2015-06-22 7:39 ` Dan Williams
2015-06-22 7:39 ` Dan Williams
2015-06-22 15:02 ` Jeff Moyer
2015-06-22 15:02 ` Jeff Moyer
2015-06-22 15:02 ` Jeff Moyer
2015-06-22 15:41 ` Christoph Hellwig
2015-06-22 15:41 ` Christoph Hellwig
2015-06-22 15:41 ` Christoph Hellwig
2015-06-22 16:00 ` Jeff Moyer
2015-06-22 16:00 ` Jeff Moyer
2015-06-22 16:00 ` Jeff Moyer
2015-06-22 16:32 ` Christoph Hellwig
2015-06-22 16:32 ` Christoph Hellwig
2015-06-22 16:32 ` Christoph Hellwig
2015-06-22 16:42 ` Jeff Moyer
2015-06-22 16:42 ` Jeff Moyer
2015-06-22 16:42 ` Jeff Moyer
2015-06-22 16:48 ` Christoph Hellwig
2015-06-22 16:48 ` Christoph Hellwig
2015-06-22 16:48 ` Christoph Hellwig
2015-06-22 18:48 ` Jeff Moyer
2015-06-22 18:48 ` Jeff Moyer
2015-06-22 18:48 ` Jeff Moyer
2015-06-22 19:04 ` Dan Williams
2015-06-22 19:04 ` Dan Williams
2015-06-22 19:11 ` Jeff Moyer
2015-06-22 19:11 ` Jeff Moyer
2015-06-22 19:11 ` Jeff Moyer
2015-06-23 10:10 ` Christoph Hellwig
2015-06-23 10:10 ` Christoph Hellwig
2015-06-22 15:40 ` Christoph Hellwig
2015-06-22 15:40 ` Christoph Hellwig
2015-06-22 15:40 ` Christoph Hellwig
2015-06-22 16:36 ` Dan Williams
2015-06-22 16:36 ` Dan Williams
2015-06-22 16:36 ` Dan Williams
2015-06-22 16:45 ` Christoph Hellwig
2015-06-22 16:45 ` Christoph Hellwig
2015-06-22 16:45 ` Christoph Hellwig
2015-06-22 16:54 ` Dan Williams
2015-06-22 16:54 ` Dan Williams
2015-06-22 16:54 ` Dan Williams
2015-06-22 16:57 ` Christoph Hellwig
2015-06-22 16:57 ` Christoph Hellwig
2015-06-22 16:59 ` Dan Williams
2015-06-22 16:59 ` Dan Williams
2015-06-22 16:59 ` Dan Williams
2015-06-23 19:30 ` Matthew Wilcox
2015-06-23 19:30 ` Matthew Wilcox
2015-06-24 12:11 ` Christoph Hellwig
2015-06-24 12:11 ` Christoph Hellwig
2015-06-17 23:56 ` [PATCH 15/15] libnvdimm, nfit: handle acpi_nfit_memory_map flags Dan Williams
2015-06-17 23:56 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150621101055.GD5915@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=boaz@plexistor.com \
--cc=dan.j.williams@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mingo@kernel.org \
--cc=toshi.kani@hp.com \
--cc=vishal.l.verma@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.