From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com,
aarcange@redhat.com, riel@redhat.com, iamjoonsoo.kim@lge.com,
xiexiuqi@huawei.com, gorcunov@openvz.org,
linux-kernel@vger.kernel.org, mgorman@suse.de,
rientjes@google.com, vbabka@suse.cz,
aneesh.kumar@linux.vnet.ibm.com, hughd@google.com,
hannes@cmpxchg.org, mhocko@suse.cz, boaz@plexistor.com,
raindel@mellanox.com
Subject: Re: [RFC v2 3/3] mm: make swapin readahead to improve thp collapse rate
Date: Sun, 21 Jun 2015 22:19:58 +0300 [thread overview]
Message-ID: <20150621191958.GA6766@node.dhcp.inet.fi> (raw)
In-Reply-To: <20150621181131.GA6710@node.dhcp.inet.fi>
On Sun, Jun 21, 2015 at 09:11:31PM +0300, Kirill A. Shutemov wrote:
> On Sat, Jun 20, 2015 at 02:28:06PM +0300, Ebru Akagunduz wrote:
> > + /* pte is unmapped now, we need to map it */
> > + pte = pte_offset_map(pmd, _address);
>
> No, it's within the same pte page table. It should be mapped with
> pte_offset_map() above.
Ahh.. do_swap_page() will unmap it. Probably worth rewording the comment.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com,
aarcange@redhat.com, riel@redhat.com, iamjoonsoo.kim@lge.com,
xiexiuqi@huawei.com, gorcunov@openvz.org,
linux-kernel@vger.kernel.org, mgorman@suse.de,
rientjes@google.com, vbabka@suse.cz,
aneesh.kumar@linux.vnet.ibm.com, hughd@google.com,
hannes@cmpxchg.org, mhocko@suse.cz, boaz@plexistor.com,
raindel@mellanox.com
Subject: Re: [RFC v2 3/3] mm: make swapin readahead to improve thp collapse rate
Date: Sun, 21 Jun 2015 22:19:58 +0300 [thread overview]
Message-ID: <20150621191958.GA6766@node.dhcp.inet.fi> (raw)
In-Reply-To: <20150621181131.GA6710@node.dhcp.inet.fi>
On Sun, Jun 21, 2015 at 09:11:31PM +0300, Kirill A. Shutemov wrote:
> On Sat, Jun 20, 2015 at 02:28:06PM +0300, Ebru Akagunduz wrote:
> > + /* pte is unmapped now, we need to map it */
> > + pte = pte_offset_map(pmd, _address);
>
> No, it's within the same pte page table. It should be mapped with
> pte_offset_map() above.
Ahh.. do_swap_page() will unmap it. Probably worth rewording the comment.
--
Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-06-21 19:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 11:28 [RFC v2 0/3] mm: make swapin readahead to gain more thp performance Ebru Akagunduz
2015-06-20 11:28 ` Ebru Akagunduz
2015-06-20 11:28 ` [RFC v2 1/3] mm: add tracepoint for scanning pages Ebru Akagunduz
2015-06-20 11:28 ` Ebru Akagunduz
2015-06-21 17:42 ` Kirill A. Shutemov
2015-06-21 17:42 ` Kirill A. Shutemov
2015-06-24 11:59 ` Vlastimil Babka
2015-06-24 11:59 ` Vlastimil Babka
2015-06-20 11:28 ` [RFC v2 2/3] mm: make optimistic check for swapin readahead Ebru Akagunduz
2015-06-20 11:28 ` Ebru Akagunduz
2015-06-21 17:55 ` Kirill A. Shutemov
2015-06-21 17:55 ` Kirill A. Shutemov
2015-06-20 11:28 ` [RFC v2 3/3] mm: make swapin readahead to improve thp collapse rate Ebru Akagunduz
2015-06-20 11:28 ` Ebru Akagunduz
2015-06-21 18:11 ` Kirill A. Shutemov
2015-06-21 18:11 ` Kirill A. Shutemov
2015-06-21 19:19 ` Kirill A. Shutemov [this message]
2015-06-21 19:19 ` Kirill A. Shutemov
2015-06-22 1:37 ` Rik van Riel
2015-06-22 1:37 ` Rik van Riel
2015-06-24 12:33 ` Vlastimil Babka
2015-06-24 12:33 ` Vlastimil Babka
2015-06-26 1:44 ` Rik van Riel
2015-06-26 1:44 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150621191958.GA6766@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=boaz@plexistor.com \
--cc=ebru.akagunduz@gmail.com \
--cc=gorcunov@openvz.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=raindel@mellanox.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.