All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Dave Hansen <dave.hansen@intel.com>, Ingo Molnar <mingo@kernel.org>
Cc: Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>, Hugh Dickins <hughd@google.com>,
	Minchan Kim <minchan@kernel.org>,
	Andi Kleen <andi@firstfloor.org>, H Peter Anvin <hpa@zytor.com>,
	Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 0/3] TLB flush multiple pages per IPI v5
Date: Sun, 21 Jun 2015 23:22:31 +0300	[thread overview]
Message-ID: <20150621202231.GB6766@node.dhcp.inet.fi> (raw)
In-Reply-To: <5577078B.2000503@intel.com>

On Tue, Jun 09, 2015 at 08:34:35AM -0700, Dave Hansen wrote:
> On 06/09/2015 05:43 AM, Ingo Molnar wrote:
> > +static char tlb_flush_target[PAGE_SIZE] __aligned(4096);
> > +static void fn_flush_tlb_one(void)
> > +{
> > +	unsigned long addr = (unsigned long)&tlb_flush_target;
> > +
> > +	tlb_flush_target[0]++;
> > +	__flush_tlb_one(addr);
> > +}
> 
> So we've got an increment of a variable in kernel memory (which is
> almost surely in the L1), then we flush that memory location, and repeat
> the increment.

BTW, Ingo, have you disabled direct mapping of kernel memory with 2M/1G
pages for the test? 

I'm just thinking if there is chance that the test shooting out 1G tlb
entry. In this case we're measure wrong thing.

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Dave Hansen <dave.hansen@intel.com>, Ingo Molnar <mingo@kernel.org>
Cc: Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>, Hugh Dickins <hughd@google.com>,
	Minchan Kim <minchan@kernel.org>,
	Andi Kleen <andi@firstfloor.org>, H Peter Anvin <hpa@zytor.com>,
	Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 0/3] TLB flush multiple pages per IPI v5
Date: Sun, 21 Jun 2015 23:22:31 +0300	[thread overview]
Message-ID: <20150621202231.GB6766@node.dhcp.inet.fi> (raw)
In-Reply-To: <5577078B.2000503@intel.com>

On Tue, Jun 09, 2015 at 08:34:35AM -0700, Dave Hansen wrote:
> On 06/09/2015 05:43 AM, Ingo Molnar wrote:
> > +static char tlb_flush_target[PAGE_SIZE] __aligned(4096);
> > +static void fn_flush_tlb_one(void)
> > +{
> > +	unsigned long addr = (unsigned long)&tlb_flush_target;
> > +
> > +	tlb_flush_target[0]++;
> > +	__flush_tlb_one(addr);
> > +}
> 
> So we've got an increment of a variable in kernel memory (which is
> almost surely in the L1), then we flush that memory location, and repeat
> the increment.

BTW, Ingo, have you disabled direct mapping of kernel memory with 2M/1G
pages for the test? 

I'm just thinking if there is chance that the test shooting out 1G tlb
entry. In this case we're measure wrong thing.

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

  parent reply	other threads:[~2015-06-21 20:23 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08 12:50 [PATCH 0/3] TLB flush multiple pages per IPI v5 Mel Gorman
2015-06-08 12:50 ` Mel Gorman
2015-06-08 12:50 ` [PATCH 1/3] x86, mm: Trace when an IPI is about to be sent Mel Gorman
2015-06-08 12:50   ` Mel Gorman
2015-06-08 12:50 ` [PATCH 2/3] mm: Send one IPI per CPU to TLB flush multiple pages that were recently unmapped Mel Gorman
2015-06-08 12:50   ` Mel Gorman
2015-06-08 22:38   ` Andrew Morton
2015-06-08 22:38     ` Andrew Morton
2015-06-09 11:07     ` Mel Gorman
2015-06-09 11:07       ` Mel Gorman
2015-06-08 12:50 ` [PATCH 3/3] mm: Defer flush of writable TLB entries Mel Gorman
2015-06-08 12:50   ` Mel Gorman
2015-06-08 17:45 ` [PATCH 0/3] TLB flush multiple pages per IPI v5 Ingo Molnar
2015-06-08 17:45   ` Ingo Molnar
2015-06-08 18:21   ` Dave Hansen
2015-06-08 18:21     ` Dave Hansen
2015-06-08 19:52     ` Ingo Molnar
2015-06-08 19:52       ` Ingo Molnar
2015-06-08 20:03       ` Ingo Molnar
2015-06-08 20:03         ` Ingo Molnar
2015-06-08 21:07       ` Dave Hansen
2015-06-08 21:07         ` Dave Hansen
2015-06-08 21:50         ` Ingo Molnar
2015-06-08 21:50           ` Ingo Molnar
2015-06-09  8:47   ` Mel Gorman
2015-06-09  8:47     ` Mel Gorman
2015-06-09 10:32     ` Ingo Molnar
2015-06-09 10:32       ` Ingo Molnar
2015-06-09 11:20       ` Mel Gorman
2015-06-09 11:20         ` Mel Gorman
2015-06-09 12:43         ` Ingo Molnar
2015-06-09 12:43           ` Ingo Molnar
2015-06-09 13:05           ` Mel Gorman
2015-06-09 13:05             ` Mel Gorman
2015-06-10  8:51             ` Ingo Molnar
2015-06-10  8:51               ` Ingo Molnar
2015-06-10  9:08               ` Ingo Molnar
2015-06-10  9:08                 ` Ingo Molnar
2015-06-10 10:15                 ` Mel Gorman
2015-06-10 10:15                   ` Mel Gorman
2015-06-11 15:26                   ` Ingo Molnar
2015-06-11 15:26                     ` Ingo Molnar
2015-06-10  9:19               ` Mel Gorman
2015-06-10  9:19                 ` Mel Gorman
2015-06-09 15:34           ` Dave Hansen
2015-06-09 15:34             ` Dave Hansen
2015-06-09 16:49             ` Dave Hansen
2015-06-09 16:49               ` Dave Hansen
2015-06-09 21:14               ` Dave Hansen
2015-06-09 21:14                 ` Dave Hansen
2015-06-09 21:54                 ` Linus Torvalds
2015-06-09 21:54                   ` Linus Torvalds
2015-06-09 22:32                   ` Mel Gorman
2015-06-09 22:32                     ` Mel Gorman
2015-06-09 22:35                     ` Mel Gorman
2015-06-09 22:35                       ` Mel Gorman
2015-06-10 13:13                   ` Andi Kleen
2015-06-10 13:13                     ` Andi Kleen
2015-06-10 16:17                     ` Linus Torvalds
2015-06-10 16:17                       ` Linus Torvalds
2015-06-10 16:42                       ` Linus Torvalds
2015-06-10 16:42                         ` Linus Torvalds
2015-06-10 17:24                         ` Mel Gorman
2015-06-10 17:24                           ` Mel Gorman
2015-06-10 17:31                           ` Linus Torvalds
2015-06-10 17:31                             ` Linus Torvalds
2015-06-10 18:08                         ` Josh Boyer
2015-06-10 18:08                           ` Josh Boyer
2015-06-10 17:07                       ` Mel Gorman
2015-06-10 17:07                         ` Mel Gorman
2015-06-21 20:22             ` Kirill A. Shutemov [this message]
2015-06-21 20:22               ` Kirill A. Shutemov
2015-06-25 11:48               ` Ingo Molnar
2015-06-25 11:48                 ` Ingo Molnar
2015-06-25 18:36                 ` Linus Torvalds
2015-06-25 19:15                   ` Vlastimil Babka
2015-06-25 19:15                     ` Vlastimil Babka
2015-06-25 22:04                     ` Linus Torvalds
2015-06-25 22:04                       ` Linus Torvalds
2015-06-25 18:46                 ` Dave Hansen
2015-06-25 18:46                   ` Dave Hansen
2015-06-26  9:08                   ` Ingo Molnar
2015-06-26  9:08                     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150621202231.GB6766@node.dhcp.inet.fi \
    --to=kirill@shutemov.name \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=dave.hansen@intel.com \
    --cc=hpa@zytor.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    --cc=mingo@kernel.org \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.