All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCHv2] Bluetooth:hci_bcsp:Fix coding style -- Clean up
@ 2015-06-22  5:58 Mutharaju, Prasanna (P.)
  2015-06-22 10:26 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: Mutharaju, Prasanna (P.) @ 2015-06-22  5:58 UTC (permalink / raw)
  To: Marcel Holtmann, Gustavo F. Padovan, Johan Hedberg
  Cc: linux-bluetooth@vger.kernel.org

From: Prasanna Karthik <mkarthi3@visteon.com>

Space prohibited between function name and open parenthesis '('
reported by Checkpatch

Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>

----
V2 Cleaned up the patch to remove trailing whitespace
---

Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
---
 drivers/bluetooth/hci_bcsp.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c
index dc8e3d4..9b8233b 100644
--- a/drivers/bluetooth/hci_bcsp.c
+++ b/drivers/bluetooth/hci_bcsp.c
@@ -464,7 +464,7 @@ static inline void bcsp_unslip_one_byte(struct bcsp_str=
uct *bcsp, unsigned char
 			break;
=20
 		default:
-			BT_ERR ("Invalid byte %02x after esc byte", byte);
+			BT_ERR("Invalid byte %02x after esc byte", byte);
 			kfree_skb(bcsp->rx_skb);
 			bcsp->rx_skb =3D NULL;
 			bcsp->rx_state =3D BCSP_W4_PKT_DELIMITER;
@@ -527,7 +527,7 @@ static void bcsp_complete_rx_pkt(struct hci_uart *hu)
=20
 				hci_recv_frame(hu->hdev, bcsp->rx_skb);
 			} else {
-				BT_ERR ("Packet for unknown channel (%u %s)",
+				BT_ERR("Packet for unknown channel (%u %s)",
 					bcsp->rx_skb->data[1] & 0x0f,
 					bcsp->rx_skb->data[0] & 0x80 ?=20
 					"reliable" : "unreliable");
@@ -587,7 +587,7 @@ static int bcsp_recv(struct hci_uart *hu, const void *d=
ata, int count)
 			}
 			if (bcsp->rx_skb->data[0] & 0x80	/* reliable pkt */
 			    		&& (bcsp->rx_skb->data[0] & 0x07) !=3D bcsp->rxseq_txack) {
-				BT_ERR ("Out-of-order packet arrived, got %u expected %u",
+				BT_ERR("Out-of-order packet arrived, got %u expected %u",
 					bcsp->rx_skb->data[0] & 0x07, bcsp->rxseq_txack);
=20
 				kfree_skb(bcsp->rx_skb);
@@ -610,7 +610,7 @@ static int bcsp_recv(struct hci_uart *hu, const void *d=
ata, int count)
=20
 		case BCSP_W4_CRC:
 			if (bitrev16(bcsp->message_crc) !=3D bscp_get_crc(bcsp)) {
-				BT_ERR ("Checksum failed: computed %04x received %04x",
+				BT_ERR("Checksum failed: computed %04x received %04x",
 					bitrev16(bcsp->message_crc),
 					bscp_get_crc(bcsp));
=20
--=20
1.7.0.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCHv2] Bluetooth:hci_bcsp:Fix coding style -- Clean up
  2015-06-22  5:58 [PATCHv2] Bluetooth:hci_bcsp:Fix coding style -- Clean up Mutharaju, Prasanna (P.)
@ 2015-06-22 10:26 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2015-06-22 10:26 UTC (permalink / raw)
  To: Mutharaju, Prasanna (P.)
  Cc: Gustavo F. Padovan, Johan Hedberg,
	linux-bluetooth@vger.kernel.org

Hi Prasanna,

> Space prohibited between function name and open parenthesis '('
> reported by Checkpatch
> 
> Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
> 
> ----
> V2 Cleaned up the patch to remove trailing whitespace
> ---
> 
> Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
> ---
> drivers/bluetooth/hci_bcsp.c |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)

the patch is still malformed when it arrives on the mailing list. Please use git send-email to actually send the patch. Maybe your email client is mangling it somehow.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-06-22 10:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-22  5:58 [PATCHv2] Bluetooth:hci_bcsp:Fix coding style -- Clean up Mutharaju, Prasanna (P.)
2015-06-22 10:26 ` Marcel Holtmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.