All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: lkp@lists.01.org
Subject: Re: [x86/mm/pat, drivers/media/ivtv] WARNING: CPU: 0 PID: 1 at drivers/media/pci/ivtv/ivtvfb.c:1270 ivtvfb_init()
Date: Mon, 22 Jun 2015 08:36:47 +0200	[thread overview]
Message-ID: <20150622063647.GA24434@gmail.com> (raw)
In-Reply-To: <20150621204120.GA11833@pd.tnic>

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]


* Borislav Petkov <bp@suse.de> wrote:

> On Sun, Jun 21, 2015 at 10:23:48PM +0200, Luis R. Rodriguez wrote:

> > Nope, well the driver requires huge amounts of work to work with PAT, that 
> > work will likely never be done, so hence the warning. Its our compromise as 
> > only 2 drivers will live on Linux like this and they are both old and rare.
> 
> Hmm, so wasn't the possibility discussed to fail loading instead and issue a 
> single-line pr_warn() when PAT is enabled? Those big WARN() splats will only 
> confuse people...

Absolutely - they are a regression.

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@suse.de>
Cc: "Luis R. Rodriguez" <mcgrof@suse.com>,
	Fengguang Wu <fengguang.wu@intel.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	LKP <lkp@01.org>
Subject: Re: [x86/mm/pat, drivers/media/ivtv]  WARNING: CPU: 0 PID: 1 at drivers/media/pci/ivtv/ivtvfb.c:1270 ivtvfb_init()
Date: Mon, 22 Jun 2015 08:36:47 +0200	[thread overview]
Message-ID: <20150622063647.GA24434@gmail.com> (raw)
In-Reply-To: <20150621204120.GA11833@pd.tnic>


* Borislav Petkov <bp@suse.de> wrote:

> On Sun, Jun 21, 2015 at 10:23:48PM +0200, Luis R. Rodriguez wrote:

> > Nope, well the driver requires huge amounts of work to work with PAT, that 
> > work will likely never be done, so hence the warning. Its our compromise as 
> > only 2 drivers will live on Linux like this and they are both old and rare.
> 
> Hmm, so wasn't the possibility discussed to fail loading instead and issue a 
> single-line pr_warn() when PAT is enabled? Those big WARN() splats will only 
> confuse people...

Absolutely - they are a regression.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@suse.de>
Cc: "Luis R. Rodriguez" <mcgrof@suse.com>,
	Fengguang Wu <fengguang.wu@intel.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	LKP <lkp@01.org>
Subject: Re: [x86/mm/pat, drivers/media/ivtv]  WARNING: CPU: 0 PID: 1 at drivers/media/pci/ivtv/ivtvfb.c:1270 ivtvfb_init()
Date: Mon, 22 Jun 2015 08:36:47 +0200	[thread overview]
Message-ID: <20150622063647.GA24434@gmail.com> (raw)
In-Reply-To: <20150621204120.GA11833@pd.tnic>


* Borislav Petkov <bp@suse.de> wrote:

> On Sun, Jun 21, 2015 at 10:23:48PM +0200, Luis R. Rodriguez wrote:

> > Nope, well the driver requires huge amounts of work to work with PAT, that 
> > work will likely never be done, so hence the warning. Its our compromise as 
> > only 2 drivers will live on Linux like this and they are both old and rare.
> 
> Hmm, so wasn't the possibility discussed to fail loading instead and issue a 
> single-line pr_warn() when PAT is enabled? Those big WARN() splats will only 
> confuse people...

Absolutely - they are a regression.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

  parent reply	other threads:[~2015-06-22  6:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-20  7:17 [x86/mm/pat, drivers/media/ivtv] WARNING: CPU: 0 PID: 1 at drivers/media/pci/ivtv/ivtvfb.c:1270 ivtvfb_init() Fengguang Wu
2015-06-20  7:17 ` Fengguang Wu
2015-06-20 11:08 ` Borislav Petkov
2015-06-20 11:08   ` Borislav Petkov
2015-06-20 11:08   ` Borislav Petkov
2015-06-21 20:23   ` Luis R. Rodriguez
2015-06-21 20:23     ` Luis R. Rodriguez
2015-06-21 20:23     ` Luis R. Rodriguez
2015-06-21 20:41     ` Borislav Petkov
2015-06-21 20:41       ` Borislav Petkov
2015-06-21 20:41       ` Borislav Petkov
2015-06-22  1:01       ` Luis R. Rodriguez
2015-06-22  1:01         ` Luis R. Rodriguez
2015-06-22  1:01         ` Luis R. Rodriguez
2015-06-22  7:06         ` Borislav Petkov
2015-06-22  7:06           ` Borislav Petkov
2015-06-22  7:06           ` Borislav Petkov
2015-06-22 17:19           ` Luis R. Rodriguez
2015-06-22 17:19             ` Luis R. Rodriguez
2015-06-22 17:19             ` Luis R. Rodriguez
2015-06-22  6:36       ` Ingo Molnar [this message]
2015-06-22  6:36         ` Ingo Molnar
2015-06-22  6:36         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150622063647.GA24434@gmail.com \
    --to=mingo@kernel.org \
    --cc=lkp@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.