From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
peterhuewe@gmx.de, gregkh@linuxfoundation.org,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Guenter Roeck <linux@roeck-us.net>, NeilBrown <neilb@suse.de>
Subject: Re: [PATCH v7 1/3] sysfs: added sysfs_link_entry_to_kobj()
Date: Mon, 22 Jun 2015 11:52:53 -0600 [thread overview]
Message-ID: <20150622175253.GA28080@obsidianresearch.com> (raw)
In-Reply-To: <20150622173039.GA3710@mtj.duckdns.org>
On Mon, Jun 22, 2015 at 01:30:39PM -0400, Tejun Heo wrote:
> On Mon, Jun 22, 2015 at 08:24:50PM +0300, Jarkko Sakkinen wrote:
> > Added a new function sysfs_link_group_to_kobj() that adds a symlink
> > from attribute or group to a kobject. Exported kernfs_remove_by_name_ns
> > in order to provide a way to remove such symlinks.
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> Hmmm... is this *really* necessary? If linking from the parent kobj
> doesn't make a fundamental functional difference, I don't think this
> is a good idea. If linking to the parent doesn't work, why doesn't
> it? Shouldn't that already be a different kobj then? I'd really like
> to keep groups as a dumb container of simple attrs.
TPM is undergoing a migration of core attributes from the
platform_device to the core's struct device.
The only purpose of the symlink was to provide userspace
compatability with the old location.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-06-22 17:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 17:24 [PATCH v7 0/3] Enable PPI sysfs interface for TPM 2.0 Jarkko Sakkinen
2015-06-22 17:24 ` Jarkko Sakkinen
2015-06-22 17:24 ` [PATCH v7 1/3] sysfs: added sysfs_link_entry_to_kobj() Jarkko Sakkinen
2015-06-22 17:30 ` Tejun Heo
2015-06-22 17:52 ` Jason Gunthorpe [this message]
2015-06-22 18:01 ` Tejun Heo
2015-06-23 12:43 ` Jarkko Sakkinen
2015-06-23 16:19 ` Jason Gunthorpe
2015-07-02 17:04 ` Tejun Heo
2015-07-03 11:12 ` Jarkko Sakkinen
2015-06-22 17:24 ` [PATCH v7 2/3] tpm: move the PPI attributes to character device directory Jarkko Sakkinen
2015-06-22 17:24 ` [PATCH v7 3/3] tpm: update PPI documentation to address the location change Jarkko Sakkinen
2015-06-22 17:24 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150622175253.GA28080@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=neilb@suse.de \
--cc=peterhuewe@gmx.de \
--cc=tj@kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.