All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	peterhuewe@gmx.de, gregkh@linuxfoundation.org,
	Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
	Guenter Roeck <linux@roeck-us.net>, NeilBrown <neilb@suse.de>
Subject: Re: [PATCH v7 1/3] sysfs: added sysfs_link_entry_to_kobj()
Date: Thu, 2 Jul 2015 13:04:07 -0400	[thread overview]
Message-ID: <20150702170407.GD30677@mtj.duckdns.org> (raw)
In-Reply-To: <20150623161932.GA20922@obsidianresearch.com>

Hello, Jason.

On Tue, Jun 23, 2015 at 10:19:32AM -0600, Jason Gunthorpe wrote:
> The concept was to move the sysfs files to the natural location on the
> core's struct tpm.struct device and leave a symlink behind on the
> platform_device for compat.

I see.  The only problem I see is that this might get abused.  Can you
clearly mark the function that it's not intended to be used in
anything new, e.g. by renaming it to sth like
__compat_only_sysfs_link_entry_to_kobj().

> We could also just move the sysfs file and ignore the compat symlink,
> but it is not clear to me if that is an OK UAPI break for sysfs?

We shouldn't if it has actual chance of disturbing userland.

Thanks.

-- 
tejun

  reply	other threads:[~2015-07-02 17:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22 17:24 [PATCH v7 0/3] Enable PPI sysfs interface for TPM 2.0 Jarkko Sakkinen
2015-06-22 17:24 ` Jarkko Sakkinen
2015-06-22 17:24 ` [PATCH v7 1/3] sysfs: added sysfs_link_entry_to_kobj() Jarkko Sakkinen
2015-06-22 17:30   ` Tejun Heo
2015-06-22 17:52     ` Jason Gunthorpe
2015-06-22 18:01       ` Tejun Heo
2015-06-23 12:43         ` Jarkko Sakkinen
2015-06-23 16:19         ` Jason Gunthorpe
2015-07-02 17:04           ` Tejun Heo [this message]
2015-07-03 11:12             ` Jarkko Sakkinen
2015-06-22 17:24 ` [PATCH v7 2/3] tpm: move the PPI attributes to character device directory Jarkko Sakkinen
2015-06-22 17:24 ` [PATCH v7 3/3] tpm: update PPI documentation to address the location change Jarkko Sakkinen
2015-06-22 17:24   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150702170407.GD30677@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=neilb@suse.de \
    --cc=peterhuewe@gmx.de \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.