All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH 1/4] ARM: dts: sunxi: Add regulator-boot-on to usb host port regulator nodes
Date: Tue, 23 Jun 2015 09:16:46 +0200	[thread overview]
Message-ID: <20150623071646.GL2266@lukather> (raw)
In-Reply-To: <5587C720.9040007@redhat.com>

On Mon, Jun 22, 2015 at 10:28:16AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 22-06-15 02:30, Julian Calaby wrote:
> >Hi Hans,
> >
> >On Sun, Jun 21, 2015 at 1:40 AM, Hans de Goede <hdegoede@redhat.com> wrote:
> >>u-boot will have turned on the power to the usb host ports, so mark them
> >>as regulator-boot-on, this stops the power on the ports from temporarily
> >>getting turned off during boot, causing issues with e.g. usb powered
> >>harddisks.
> >
> >Stupid question: shouldn't u-boot set this property?
> 
> We could make u-boot set this property but that will require a lot of code on
> u-boot's side which is simply not there atm. And traditionally this property
> is is simply a part of the dts files as shipped with the kernel.

What happens if the property is set but the regulator is not actually
enabled?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150623/87bae54c/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Julian Calaby
	<julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Mailing List,
	Arm"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: [PATCH 1/4] ARM: dts: sunxi: Add regulator-boot-on to usb host port regulator nodes
Date: Tue, 23 Jun 2015 09:16:46 +0200	[thread overview]
Message-ID: <20150623071646.GL2266@lukather> (raw)
In-Reply-To: <5587C720.9040007-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 964 bytes --]

On Mon, Jun 22, 2015 at 10:28:16AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 22-06-15 02:30, Julian Calaby wrote:
> >Hi Hans,
> >
> >On Sun, Jun 21, 2015 at 1:40 AM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> >>u-boot will have turned on the power to the usb host ports, so mark them
> >>as regulator-boot-on, this stops the power on the ports from temporarily
> >>getting turned off during boot, causing issues with e.g. usb powered
> >>harddisks.
> >
> >Stupid question: shouldn't u-boot set this property?
> 
> We could make u-boot set this property but that will require a lot of code on
> u-boot's side which is simply not there atm. And traditionally this property
> is is simply a part of the dts files as shipped with the kernel.

What happens if the property is set but the regulator is not actually
enabled?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-06-23  7:16 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-20 15:40 [PATCH 0/4] ARM: dts: sunxi: Enable otg on more boards Hans de Goede
2015-06-20 15:40 ` Hans de Goede
2015-06-20 15:40 ` [PATCH 1/4] ARM: dts: sunxi: Add regulator-boot-on to usb host port regulator nodes Hans de Goede
2015-06-20 15:40   ` Hans de Goede
2015-06-22  0:30   ` [linux-sunxi] " Julian Calaby
2015-06-22  0:30     ` Julian Calaby
2015-06-22  8:28     ` [linux-sunxi] " Hans de Goede
2015-06-22  8:28       ` Hans de Goede
2015-06-22 14:54       ` [linux-sunxi] " Julian Calaby
2015-06-22 14:54         ` Julian Calaby
2015-06-23  7:16       ` Maxime Ripard [this message]
2015-06-23  7:16         ` Maxime Ripard
2015-06-23  8:19         ` [linux-sunxi] " Hans de Goede
2015-06-23  8:19           ` Hans de Goede
2015-06-25 11:12           ` Maxime Ripard
2015-06-25 11:12             ` Maxime Ripard
2015-06-20 15:40 ` [PATCH 2/4] ARM: dts: sun4i: Enable otg controller on the ba10-tvbox Hans de Goede
2015-06-20 15:40   ` Hans de Goede
2015-06-20 15:40 ` [PATCH 3/4] ARM: dts: sun4i: Enable otg controller on the mini-x Hans de Goede
2015-06-20 15:40   ` Hans de Goede
2015-06-20 15:40 ` [PATCH 4/4] ARM: dts: sun6i: Enable otg controller on the cs908 Hans de Goede
2015-06-20 15:40   ` Hans de Goede
2015-06-25 11:13 ` [PATCH 0/4] ARM: dts: sunxi: Enable otg on more boards Maxime Ripard
2015-06-25 11:13   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150623071646.GL2266@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.