From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Isaac Assegai <isaac.a.travers@gmail.com>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
teddy.wang@siliconmotion.com
Subject: Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines
Date: Tue, 23 Jun 2015 08:55:48 +0000 [thread overview]
Message-ID: <20150623085548.GM28762@mwanda> (raw)
In-Reply-To: <20150620072402.GA15195@sudip-PC>
On Sat, Jun 20, 2015 at 12:54:02PM +0530, Sudip Mukherjee wrote:
> On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote:
> > Place braces on previous lines in ddk750_sii164.c to
> > rectify the following checkpatch errors:
> > ERROR: that open brace { should be on the previous line
> >
> > Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com>
> > ---
> > drivers/staging/sm750fb/ddk750_sii164.c | 16 +++++-----------
> > 1 file changed, 5 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> > index 7f58fbe..64d4291 100644
> > --- a/drivers/staging/sm750fb/ddk750_sii164.c
> > +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> > @@ -136,8 +136,7 @@ long sii164InitChip(
> > #endif
> >
> > /* Check if SII164 Chip exists */
> > - if ((sii164GetVendorID() = SII164_VENDOR_ID) && (sii164GetDeviceID() = SII164_DEVICE_ID))
> > - {
> > + if ((sii164GetVendorID() = SII164_VENDOR_ID) && (sii164GetDeviceID() = SII164_DEVICE_ID) {
> ^^^^
> you have not build tested it :(
> In function ‘sii164InitChip’:
> error: expected ‘)’ before ‘{’ token
>
I never get Isaac's emails. I think gmail is still sending them to the
Spam folder? I searched my spam folder and don't see them though...
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Isaac Assegai <isaac.a.travers@gmail.com>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
teddy.wang@siliconmotion.com
Subject: Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines
Date: Tue, 23 Jun 2015 11:55:48 +0300 [thread overview]
Message-ID: <20150623085548.GM28762@mwanda> (raw)
In-Reply-To: <20150620072402.GA15195@sudip-PC>
On Sat, Jun 20, 2015 at 12:54:02PM +0530, Sudip Mukherjee wrote:
> On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote:
> > Place braces on previous lines in ddk750_sii164.c to
> > rectify the following checkpatch errors:
> > ERROR: that open brace { should be on the previous line
> >
> > Signed-off-by: Isaac Assegai <isaac.a.travers@gmail.com>
> > ---
> > drivers/staging/sm750fb/ddk750_sii164.c | 16 +++++-----------
> > 1 file changed, 5 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> > index 7f58fbe..64d4291 100644
> > --- a/drivers/staging/sm750fb/ddk750_sii164.c
> > +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> > @@ -136,8 +136,7 @@ long sii164InitChip(
> > #endif
> >
> > /* Check if SII164 Chip exists */
> > - if ((sii164GetVendorID() == SII164_VENDOR_ID) && (sii164GetDeviceID() == SII164_DEVICE_ID))
> > - {
> > + if ((sii164GetVendorID() == SII164_VENDOR_ID) && (sii164GetDeviceID() == SII164_DEVICE_ID) {
> ^^^^
> you have not build tested it :(
> In function ‘sii164InitChip’:
> error: expected ‘)’ before ‘{’ token
>
I never get Isaac's emails. I think gmail is still sending them to the
Spam folder? I searched my spam folder and don't see them though...
regards,
dan carpenter
next prev parent reply other threads:[~2015-06-23 8:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1434743301-14774-1-git-send-email-isaac.a.travers@gmail.com>
[not found] ` <1434743301-14774-7-git-send-email-isaac.a.travers@gmail.com>
2015-06-20 7:24 ` [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines Sudip Mukherjee
2015-06-20 7:36 ` Sudip Mukherjee
2015-06-23 8:55 ` Dan Carpenter [this message]
2015-06-23 8:55 ` Dan Carpenter
2015-06-23 9:53 ` Sudip Mukherjee
2015-06-23 9:53 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623085548.GM28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=isaac.a.travers@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.