From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH 0/2] Revert changes to libxl_set_memory_target, unblock 4.6
Date: Tue, 23 Jun 2015 15:19:45 +0100 [thread overview]
Message-ID: <20150623141945.GA28647@zion.uk.xensource.com> (raw)
In-Reply-To: <1435068984-9163-1-git-send-email-wei.liu2@citrix.com>
CC Jan, author of one of the patches.
On Tue, Jun 23, 2015 at 03:16:22PM +0100, Wei Liu wrote:
> A new memory model that allows QEMU to bump memory behind libxl's back was
> merged a few months ago. We didn't fully understand the repercussions back
> then. Now it breaks migration and becomes blocker of 4.6 release.
>
> It's better to restore to original behaviour at this stage of the release
> cycle, that would put us in a position no worse than before, so the release is
> unblocked.
>
> The said function is still racy after reverting these two patches. Making
> domain memory state consistent requires a bit more work. Separate patch(es)
> will be sent out to deal with that problem.
>
> Wei.
>
> Wei Liu (2):
> Revert "libxl: fix "xl mem-set" regression from 0c029c4da2"
> Revert "libxl_set_memory_target: retain the same maxmem offset on top
> of the current target"
>
> tools/libxc/include/xenctrl.h | 2 +-
> tools/libxc/xc_domain.c | 2 +-
> tools/libxl/libxl.c | 29 ++++++++++++++++-------------
> 3 files changed, 18 insertions(+), 15 deletions(-)
>
> --
> 1.9.1
prev parent reply other threads:[~2015-06-23 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 14:16 [PATCH 0/2] Revert changes to libxl_set_memory_target, unblock 4.6 Wei Liu
2015-06-23 14:16 ` [PATCH 1/2] Revert "libxl: fix "xl mem-set" regression from 0c029c4da2" Wei Liu
2015-06-23 14:24 ` Konrad Rzeszutek Wilk
2015-06-23 14:45 ` Jan Beulich
2015-06-23 14:52 ` Wei Liu
2015-06-23 15:00 ` Ian Campbell
2015-06-23 14:16 ` [PATCH 2/2] Revert "libxl_set_memory_target: retain the same maxmem offset on top of the current target" Wei Liu
2015-06-23 14:19 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623141945.GA28647@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.