From: "Richard W.M. Jones" <rjones@redhat.com>
To: Cole Robinson <crobinso@redhat.com>
Cc: "Jindřich Makovička" <makovick@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow2: Handle EAGAIN returned from update_refcount
Date: Wed, 24 Jun 2015 15:22:44 +0100 [thread overview]
Message-ID: <20150624142243.GX29283@redhat.com> (raw)
In-Reply-To: <558ABB79.20202@redhat.com>
On Wed, Jun 24, 2015 at 10:15:21AM -0400, Cole Robinson wrote:
> On 06/24/2015 01:05 AM, Jindřich Makovička wrote:
> > Fixes a crash during image compression
> >
> > Signed-off-by: Jindřich Makovička <makovick@gmail.com>
> > ---
> > block/qcow2-refcount.c | 22 ++++++++++++----------
> > 1 file changed, 12 insertions(+), 10 deletions(-)
> >
>
> Rich Jones already confirmed that this patch fixes a bug he can reliably
> reproduce:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1214855
Confirmed. You can add
Tested-by: Richard W.M. Jones <rjones@redhat.com>
to this patch.
Also note that if you view the patch without whitespace changes
(eg. git diff -b) then it's actually quite simple.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/
next prev parent reply other threads:[~2015-06-24 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 21:34 [Qemu-devel] [PATCH] Fix occassional crashes during qcow2 recompression Jindřich Makovička
2015-06-23 21:34 ` [Qemu-devel] [PATCH] qcow2: Handle EAGAIN returned from update_refcount Jindřich Makovička
2015-06-24 5:05 ` Jindřich Makovička
2015-06-24 14:15 ` Cole Robinson
2015-06-24 14:22 ` Richard W.M. Jones [this message]
2015-06-24 15:26 ` Max Reitz
2015-06-25 14:52 ` [Qemu-devel] [PATCH] Fix occassional crashes during qcow2 recompression Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150624142243.GX29283@redhat.com \
--to=rjones@redhat.com \
--cc=crobinso@redhat.com \
--cc=makovick@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.