All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Luis Henriques <luis.henriques@canonical.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Vince Weaver <vincent.weaver@maine.edu>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [GIT PULL] tracing: Have filter check for balanced ops
Date: Wed, 24 Jun 2015 07:54:51 -0700	[thread overview]
Message-ID: <20150624145451.GC17352@kroah.com> (raw)
In-Reply-To: <20150622144940.GD2036@ares>

On Mon, Jun 22, 2015 at 03:49:40PM +0100, Luis Henriques wrote:
> On Mon, Jun 22, 2015 at 10:17:28AM -0400, Steven Rostedt wrote:
> ...
> > To make this patch simpler, just move the "cnt--;" above the OP_AND and
> > OP_OR check and remove the "cnt--;" from that if statement.
> > 
> > But yeah, this looks fine. You can test it with the example in the
> > change log.
> > 
> >   echo "((dev==1)blocks==2)" > events/ext4/ext4_truncate_exit/filter
> > 
> > And see if it gives an error other than "parse_error: No error".
> > 
> > -- Steve
> 
> Thanks Steven, I've done a quick test with a 3.16-ckt kernel and I can
> confirm that the modified patch (i.e. including your suggestion) fixes
> the problem.
> 
> I'm attaching the patch below and CC'ing stable mailing-list.
> 
> Cheers,
> --
> Luís

Thanks, I've used this patch for 3.10 and 3.14.

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Luis Henriques <luis.henriques@canonical.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Vince Weaver <vincent.weaver@maine.edu>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [GIT PULL] tracing: Have filter check for balanced ops
Date: Wed, 24 Jun 2015 07:54:51 -0700	[thread overview]
Message-ID: <20150624145451.GC17352@kroah.com> (raw)
In-Reply-To: <20150622144940.GD2036@ares>

On Mon, Jun 22, 2015 at 03:49:40PM +0100, Luis Henriques wrote:
> On Mon, Jun 22, 2015 at 10:17:28AM -0400, Steven Rostedt wrote:
> ...
> > To make this patch simpler, just move the "cnt--;" above the OP_AND and
> > OP_OR check and remove the "cnt--;" from that if statement.
> > 
> > But yeah, this looks fine. You can test it with the example in the
> > change log.
> > 
> >   echo "((dev==1)blocks==2)" > events/ext4/ext4_truncate_exit/filter
> > 
> > And see if it gives an error other than "parse_error: No error".
> > 
> > -- Steve
> 
> Thanks Steven, I've done a quick test with a 3.16-ckt kernel and I can
> confirm that the modified patch (i.e. including your suggestion) fixes
> the problem.
> 
> I'm attaching the patch below and CC'ing stable mailing-list.
> 
> Cheers,
> --
> Lu�s

Thanks, I've used this patch for 3.10 and 3.14.

greg k-h

  reply	other threads:[~2015-06-24 14:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 12:36 [GIT PULL] tracing: Have filter check for balanced ops Steven Rostedt
2015-06-22 13:53 ` Luis Henriques
2015-06-22 14:03   ` Luis Henriques
2015-06-22 14:17     ` Steven Rostedt
2015-06-22 14:49       ` Luis Henriques
2015-06-22 14:49         ` Luis Henriques
2015-06-24 14:54         ` Greg KH [this message]
2015-06-24 14:54           ` Greg KH
2015-06-25  4:03 ` Sasha Levin
2015-06-25  4:35   ` Steven Rostedt
2015-06-25 20:11     ` Sasha Levin
2015-06-25 23:08       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150624145451.GC17352@kroah.com \
    --to=greg@kroah.com \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luis.henriques@canonical.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.