From: Thomas Huth <huth@tuxfamily.org>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] m68k: is_mem is useless
Date: Wed, 24 Jun 2015 21:15:42 +0200 [thread overview]
Message-ID: <20150624211542.01e0534b@thh440s> (raw)
In-Reply-To: <1435100422-30667-1-git-send-email-laurent@vivier.eu>
On Wed, 24 Jun 2015 01:00:22 +0200
Laurent Vivier <laurent@vivier.eu> wrote:
> Remove is_mem as it is never tested anymore since:
>
> commit bfa50bc2638d877cf2900712b7503be22e8811cb
> Author: aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>
> Date: Tue Nov 18 20:26:41 2008 +0000
>
> Remove premature memop TB terminations (Jan Kiszka)
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> target-m68k/translate.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 96d75bf..ce1fc92 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -129,7 +129,6 @@ typedef struct DisasContext {
> uint32_t fpcr;
> struct TranslationBlock *tb;
> int singlestep_enabled;
> - int is_mem;
> TCGv_i64 mactmp;
> int done_mac;
> } DisasContext;
> @@ -179,7 +178,6 @@ static inline TCGv gen_load(DisasContext * s, int opsize, TCGv addr, int sign)
> {
> TCGv tmp;
> int index = IS_USER(s);
> - s->is_mem = 1;
> tmp = tcg_temp_new_i32();
> switch(opsize) {
> case OS_BYTE:
> @@ -209,7 +207,6 @@ static inline TCGv_i64 gen_load64(DisasContext * s, TCGv addr)
> {
> TCGv_i64 tmp;
> int index = IS_USER(s);
> - s->is_mem = 1;
> tmp = tcg_temp_new_i64();
> tcg_gen_qemu_ldf64(tmp, addr, index);
> gen_throws_exception = gen_last_qop;
> @@ -220,7 +217,6 @@ static inline TCGv_i64 gen_load64(DisasContext * s, TCGv addr)
> static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv val)
> {
> int index = IS_USER(s);
> - s->is_mem = 1;
> switch(opsize) {
> case OS_BYTE:
> tcg_gen_qemu_st8(val, addr, index);
> @@ -241,7 +237,6 @@ static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv val)
> static inline void gen_store64(DisasContext *s, TCGv addr, TCGv_i64 val)
> {
> int index = IS_USER(s);
> - s->is_mem = 1;
> tcg_gen_qemu_stf64(val, addr, index);
> gen_throws_exception = gen_last_qop;
> }
> @@ -2227,7 +2222,6 @@ DISAS_INSN(fpu)
> mask = 0x80;
> for (i = 0; i < 8; i++) {
> if (ext & mask) {
> - s->is_mem = 1;
> dest = FREG(i, 0);
> if (ext & (1 << 13)) {
> /* store */
> @@ -2999,7 +2993,6 @@ gen_intermediate_code_internal(M68kCPU *cpu, TranslationBlock *tb,
> dc->singlestep_enabled = cs->singlestep_enabled;
> dc->fpcr = env->fpcr;
> dc->user = (env->sr & SR_S) == 0;
> - dc->is_mem = 0;
> dc->done_mac = 0;
> lj = -1;
> num_insns = 0;
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <huth@tuxfamily.org>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] m68k: is_mem is useless
Date: Wed, 24 Jun 2015 21:15:42 +0200 [thread overview]
Message-ID: <20150624211542.01e0534b@thh440s> (raw)
In-Reply-To: <1435100422-30667-1-git-send-email-laurent@vivier.eu>
On Wed, 24 Jun 2015 01:00:22 +0200
Laurent Vivier <laurent@vivier.eu> wrote:
> Remove is_mem as it is never tested anymore since:
>
> commit bfa50bc2638d877cf2900712b7503be22e8811cb
> Author: aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>
> Date: Tue Nov 18 20:26:41 2008 +0000
>
> Remove premature memop TB terminations (Jan Kiszka)
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> target-m68k/translate.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 96d75bf..ce1fc92 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -129,7 +129,6 @@ typedef struct DisasContext {
> uint32_t fpcr;
> struct TranslationBlock *tb;
> int singlestep_enabled;
> - int is_mem;
> TCGv_i64 mactmp;
> int done_mac;
> } DisasContext;
> @@ -179,7 +178,6 @@ static inline TCGv gen_load(DisasContext * s, int opsize, TCGv addr, int sign)
> {
> TCGv tmp;
> int index = IS_USER(s);
> - s->is_mem = 1;
> tmp = tcg_temp_new_i32();
> switch(opsize) {
> case OS_BYTE:
> @@ -209,7 +207,6 @@ static inline TCGv_i64 gen_load64(DisasContext * s, TCGv addr)
> {
> TCGv_i64 tmp;
> int index = IS_USER(s);
> - s->is_mem = 1;
> tmp = tcg_temp_new_i64();
> tcg_gen_qemu_ldf64(tmp, addr, index);
> gen_throws_exception = gen_last_qop;
> @@ -220,7 +217,6 @@ static inline TCGv_i64 gen_load64(DisasContext * s, TCGv addr)
> static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv val)
> {
> int index = IS_USER(s);
> - s->is_mem = 1;
> switch(opsize) {
> case OS_BYTE:
> tcg_gen_qemu_st8(val, addr, index);
> @@ -241,7 +237,6 @@ static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv val)
> static inline void gen_store64(DisasContext *s, TCGv addr, TCGv_i64 val)
> {
> int index = IS_USER(s);
> - s->is_mem = 1;
> tcg_gen_qemu_stf64(val, addr, index);
> gen_throws_exception = gen_last_qop;
> }
> @@ -2227,7 +2222,6 @@ DISAS_INSN(fpu)
> mask = 0x80;
> for (i = 0; i < 8; i++) {
> if (ext & mask) {
> - s->is_mem = 1;
> dest = FREG(i, 0);
> if (ext & (1 << 13)) {
> /* store */
> @@ -2999,7 +2993,6 @@ gen_intermediate_code_internal(M68kCPU *cpu, TranslationBlock *tb,
> dc->singlestep_enabled = cs->singlestep_enabled;
> dc->fpcr = env->fpcr;
> dc->user = (env->sr & SR_S) == 0;
> - dc->is_mem = 0;
> dc->done_mac = 0;
> lj = -1;
> num_insns = 0;
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
next prev parent reply other threads:[~2015-06-24 19:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 23:00 [Qemu-devel] [PATCH] m68k: is_mem is useless Laurent Vivier
2015-06-24 0:24 ` [Qemu-trivial] " Peter Crosthwaite
2015-06-24 0:24 ` Peter Crosthwaite
2015-06-24 19:15 ` Thomas Huth [this message]
2015-06-24 19:15 ` Thomas Huth
2015-06-24 19:19 ` Peter Maydell
2015-06-25 7:45 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150624211542.01e0534b@thh440s \
--to=huth@tuxfamily.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.