All of lore.kernel.org
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM64: smp: Silence suspicious RCU usage with ipi tracepoints
Date: Thu, 25 Jun 2015 14:24:54 +0100	[thread overview]
Message-ID: <20150625132453.GA13892@localhost> (raw)
In-Reply-To: <558B2842.2030007@codeaurora.org>

On Wed, Jun 24, 2015 at 02:59:30PM -0700, Stephen Boyd wrote:
> On 06/24/2015 02:29 PM, Peter Zijlstra wrote:
> > On Wed, Jun 24, 2015 at 01:14:18PM -0700, Stephen Boyd wrote:
> >> John Stultz reported an RCU splat on ARM with ipi trace events
> >> enabled. It looks like the same problem exists on ARM64.
> >>
> >> At this point in the IPI handling path we haven't called
> >> irq_enter() yet, so RCU doesn't know that we're about to exit
> >> idle and properly warns that we're using RCU from an idle CPU.
> >> Use trace_ipi_entry_rcuidle() instead of trace_ipi_entry() so
> >> that RCU is informed about our exit from idle.
> > I have a problem with $subject. It says 'silence', whereas afaict this
> > fixes an actual bug, so it should be 'fixes'.
> 
> Fair enough. I can resend or whoever applies this patch can
> s/Silence/Fix/ on the $subject.

I'll apply the patch and change the subject as well.

Thanks.

-- 
Catalin

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Nicolas Pitre <nicolas.pitre@linaro.org>,
	Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	John Stultz <john.stultz@linaro.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM64: smp: Silence suspicious RCU usage with ipi tracepoints
Date: Thu, 25 Jun 2015 14:24:54 +0100	[thread overview]
Message-ID: <20150625132453.GA13892@localhost> (raw)
In-Reply-To: <558B2842.2030007@codeaurora.org>

On Wed, Jun 24, 2015 at 02:59:30PM -0700, Stephen Boyd wrote:
> On 06/24/2015 02:29 PM, Peter Zijlstra wrote:
> > On Wed, Jun 24, 2015 at 01:14:18PM -0700, Stephen Boyd wrote:
> >> John Stultz reported an RCU splat on ARM with ipi trace events
> >> enabled. It looks like the same problem exists on ARM64.
> >>
> >> At this point in the IPI handling path we haven't called
> >> irq_enter() yet, so RCU doesn't know that we're about to exit
> >> idle and properly warns that we're using RCU from an idle CPU.
> >> Use trace_ipi_entry_rcuidle() instead of trace_ipi_entry() so
> >> that RCU is informed about our exit from idle.
> > I have a problem with $subject. It says 'silence', whereas afaict this
> > fixes an actual bug, so it should be 'fixes'.
> 
> Fair enough. I can resend or whoever applies this patch can
> s/Silence/Fix/ on the $subject.

I'll apply the patch and change the subject as well.

Thanks.

-- 
Catalin

  reply	other threads:[~2015-06-25 13:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24 20:14 [PATCH] ARM64: smp: Silence suspicious RCU usage with ipi tracepoints Stephen Boyd
2015-06-24 20:14 ` Stephen Boyd
2015-06-24 20:20 ` Paul E. McKenney
2015-06-24 20:20   ` Paul E. McKenney
2015-06-24 21:29 ` Peter Zijlstra
2015-06-24 21:29   ` Peter Zijlstra
2015-06-24 21:59   ` Stephen Boyd
2015-06-24 21:59     ` Stephen Boyd
2015-06-25 13:24     ` Catalin Marinas [this message]
2015-06-25 13:24       ` Catalin Marinas
2015-06-25  1:01   ` Steven Rostedt
2015-06-25  1:01     ` Steven Rostedt
2015-06-29 10:02 ` Russell King - ARM Linux
2015-06-29 10:02   ` Russell King - ARM Linux
2015-06-29 11:23   ` Catalin Marinas
2015-06-29 11:23     ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150625132453.GA13892@localhost \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.