* [PATCH 1/3] phy: berlin: .owner field is setup by core
@ 2015-06-24 8:40 Michal Simek
2015-06-24 8:40 ` [PATCH 2/3] phy: berlin: Do not use sata name in usb phy driver Michal Simek
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Michal Simek @ 2015-06-24 8:40 UTC (permalink / raw)
To: linux-kernel, monstr, antoine.tenart; +Cc: Kishon Vijay Abraham I
There was big cleanup in past to remove this unneeded setting.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
Can be also tracked by coccinelle script.
scripts/coccinelle/api/platform_no_drv_owner.cocci
---
drivers/phy/phy-berlin-usb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
index c6fc95b53083..d7431f6ab975 100644
--- a/drivers/phy/phy-berlin-usb.c
+++ b/drivers/phy/phy-berlin-usb.c
@@ -207,7 +207,6 @@ static struct platform_driver phy_berlin_usb_driver = {
.probe = phy_berlin_usb_probe,
.driver = {
.name = "phy-berlin-usb",
- .owner = THIS_MODULE,
.of_match_table = phy_berlin_sata_of_match,
},
};
--
2.3.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] phy: berlin: Do not use sata name in usb phy driver
2015-06-24 8:40 [PATCH 1/3] phy: berlin: .owner field is setup by core Michal Simek
@ 2015-06-24 8:40 ` Michal Simek
2015-06-26 8:59 ` Antoine Tenart
2015-06-24 8:40 ` [PATCH 3/3] usb: berlin: Trivial coding style cleanup Michal Simek
2015-06-26 8:59 ` [PATCH 1/3] phy: berlin: .owner field is setup by core Antoine Tenart
2 siblings, 1 reply; 7+ messages in thread
From: Michal Simek @ 2015-06-24 8:40 UTC (permalink / raw)
To: linux-kernel, monstr, antoine.tenart; +Cc: Kishon Vijay Abraham I
c&p error from berlin sata phy driver.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/phy/phy-berlin-usb.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
index d7431f6ab975..762f0fbdc119 100644
--- a/drivers/phy/phy-berlin-usb.c
+++ b/drivers/phy/phy-berlin-usb.c
@@ -152,7 +152,7 @@ static struct phy_ops phy_berlin_usb_ops = {
.owner = THIS_MODULE,
};
-static const struct of_device_id phy_berlin_sata_of_match[] = {
+static const struct of_device_id phy_berlin_usb_of_match[] = {
{
.compatible = "marvell,berlin2-usb-phy",
.data = &phy_berlin_pll_dividers[0],
@@ -163,12 +163,12 @@ static const struct of_device_id phy_berlin_sata_of_match[] = {
},
{ },
};
-MODULE_DEVICE_TABLE(of, phy_berlin_sata_of_match);
+MODULE_DEVICE_TABLE(of, phy_berlin_usb_of_match);
static int phy_berlin_usb_probe(struct platform_device *pdev)
{
const struct of_device_id *match =
- of_match_device(phy_berlin_sata_of_match, &pdev->dev);
+ of_match_device(phy_berlin_usb_of_match, &pdev->dev);
struct phy_berlin_usb_priv *priv;
struct resource *res;
struct phy *phy;
@@ -207,7 +207,7 @@ static struct platform_driver phy_berlin_usb_driver = {
.probe = phy_berlin_usb_probe,
.driver = {
.name = "phy-berlin-usb",
- .of_match_table = phy_berlin_sata_of_match,
+ .of_match_table = phy_berlin_usb_of_match,
},
};
module_platform_driver(phy_berlin_usb_driver);
--
2.3.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] usb: berlin: Trivial coding style cleanup
2015-06-24 8:40 [PATCH 1/3] phy: berlin: .owner field is setup by core Michal Simek
2015-06-24 8:40 ` [PATCH 2/3] phy: berlin: Do not use sata name in usb phy driver Michal Simek
@ 2015-06-24 8:40 ` Michal Simek
2015-06-26 8:59 ` Antoine Tenart
2015-06-26 8:59 ` [PATCH 1/3] phy: berlin: .owner field is setup by core Antoine Tenart
2 siblings, 1 reply; 7+ messages in thread
From: Michal Simek @ 2015-06-24 8:40 UTC (permalink / raw)
To: linux-kernel, monstr, antoine.tenart; +Cc: Jiri Kosina, Kishon Vijay Abraham I
Remove unneeded space after tab.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/phy/phy-berlin-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
index 762f0fbdc119..0fe0d81c29ee 100644
--- a/drivers/phy/phy-berlin-usb.c
+++ b/drivers/phy/phy-berlin-usb.c
@@ -208,7 +208,7 @@ static struct platform_driver phy_berlin_usb_driver = {
.driver = {
.name = "phy-berlin-usb",
.of_match_table = phy_berlin_usb_of_match,
- },
+ },
};
module_platform_driver(phy_berlin_usb_driver);
--
2.3.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] phy: berlin: .owner field is setup by core
2015-06-24 8:40 [PATCH 1/3] phy: berlin: .owner field is setup by core Michal Simek
2015-06-24 8:40 ` [PATCH 2/3] phy: berlin: Do not use sata name in usb phy driver Michal Simek
2015-06-24 8:40 ` [PATCH 3/3] usb: berlin: Trivial coding style cleanup Michal Simek
@ 2015-06-26 8:59 ` Antoine Tenart
2 siblings, 0 replies; 7+ messages in thread
From: Antoine Tenart @ 2015-06-26 8:59 UTC (permalink / raw)
To: Michal Simek; +Cc: linux-kernel, monstr, antoine.tenart, Kishon Vijay Abraham I
On Wed, Jun 24, 2015 at 10:40:53AM +0200, Michal Simek wrote:
> There was big cleanup in past to remove this unneeded setting.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
>
> Can be also tracked by coccinelle script.
> scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> ---
> drivers/phy/phy-berlin-usb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index c6fc95b53083..d7431f6ab975 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -207,7 +207,6 @@ static struct platform_driver phy_berlin_usb_driver = {
> .probe = phy_berlin_usb_probe,
> .driver = {
> .name = "phy-berlin-usb",
> - .owner = THIS_MODULE,
> .of_match_table = phy_berlin_sata_of_match,
> },
> };
> --
> 2.3.5
>
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] usb: berlin: Trivial coding style cleanup
2015-06-24 8:40 ` [PATCH 3/3] usb: berlin: Trivial coding style cleanup Michal Simek
@ 2015-06-26 8:59 ` Antoine Tenart
2015-07-15 12:43 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 7+ messages in thread
From: Antoine Tenart @ 2015-06-26 8:59 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, antoine.tenart, Jiri Kosina,
Kishon Vijay Abraham I
On Wed, Jun 24, 2015 at 10:40:55AM +0200, Michal Simek wrote:
> Remove unneeded space after tab.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
>
> drivers/phy/phy-berlin-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index 762f0fbdc119..0fe0d81c29ee 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -208,7 +208,7 @@ static struct platform_driver phy_berlin_usb_driver = {
> .driver = {
> .name = "phy-berlin-usb",
> .of_match_table = phy_berlin_usb_of_match,
> - },
> + },
> };
> module_platform_driver(phy_berlin_usb_driver);
>
> --
> 2.3.5
>
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] phy: berlin: Do not use sata name in usb phy driver
2015-06-24 8:40 ` [PATCH 2/3] phy: berlin: Do not use sata name in usb phy driver Michal Simek
@ 2015-06-26 8:59 ` Antoine Tenart
0 siblings, 0 replies; 7+ messages in thread
From: Antoine Tenart @ 2015-06-26 8:59 UTC (permalink / raw)
To: Michal Simek; +Cc: linux-kernel, monstr, antoine.tenart, Kishon Vijay Abraham I
On Wed, Jun 24, 2015 at 10:40:54AM +0200, Michal Simek wrote:
> c&p error from berlin sata phy driver.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
>
> drivers/phy/phy-berlin-usb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index d7431f6ab975..762f0fbdc119 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -152,7 +152,7 @@ static struct phy_ops phy_berlin_usb_ops = {
> .owner = THIS_MODULE,
> };
>
> -static const struct of_device_id phy_berlin_sata_of_match[] = {
> +static const struct of_device_id phy_berlin_usb_of_match[] = {
> {
> .compatible = "marvell,berlin2-usb-phy",
> .data = &phy_berlin_pll_dividers[0],
> @@ -163,12 +163,12 @@ static const struct of_device_id phy_berlin_sata_of_match[] = {
> },
> { },
> };
> -MODULE_DEVICE_TABLE(of, phy_berlin_sata_of_match);
> +MODULE_DEVICE_TABLE(of, phy_berlin_usb_of_match);
>
> static int phy_berlin_usb_probe(struct platform_device *pdev)
> {
> const struct of_device_id *match =
> - of_match_device(phy_berlin_sata_of_match, &pdev->dev);
> + of_match_device(phy_berlin_usb_of_match, &pdev->dev);
> struct phy_berlin_usb_priv *priv;
> struct resource *res;
> struct phy *phy;
> @@ -207,7 +207,7 @@ static struct platform_driver phy_berlin_usb_driver = {
> .probe = phy_berlin_usb_probe,
> .driver = {
> .name = "phy-berlin-usb",
> - .of_match_table = phy_berlin_sata_of_match,
> + .of_match_table = phy_berlin_usb_of_match,
> },
> };
> module_platform_driver(phy_berlin_usb_driver);
> --
> 2.3.5
>
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] usb: berlin: Trivial coding style cleanup
2015-06-26 8:59 ` Antoine Tenart
@ 2015-07-15 12:43 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 7+ messages in thread
From: Kishon Vijay Abraham I @ 2015-07-15 12:43 UTC (permalink / raw)
To: Antoine Tenart, Michal Simek; +Cc: linux-kernel, monstr, Jiri Kosina
Hi,
On Friday 26 June 2015 02:29 PM, Antoine Tenart wrote:
> On Wed, Jun 24, 2015 at 10:40:55AM +0200, Michal Simek wrote:
>> Remove unneeded space after tab.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>
> Acked-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Fixed $subject to have "phy" instead of "usb" and merged this series to
linux-phy tree.
Cheers
Kishon
>
>> ---
>>
>> drivers/phy/phy-berlin-usb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
>> index 762f0fbdc119..0fe0d81c29ee 100644
>> --- a/drivers/phy/phy-berlin-usb.c
>> +++ b/drivers/phy/phy-berlin-usb.c
>> @@ -208,7 +208,7 @@ static struct platform_driver phy_berlin_usb_driver = {
>> .driver = {
>> .name = "phy-berlin-usb",
>> .of_match_table = phy_berlin_usb_of_match,
>> - },
>> + },
>> };
>> module_platform_driver(phy_berlin_usb_driver);
>>
>> --
>> 2.3.5
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-07-15 12:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-24 8:40 [PATCH 1/3] phy: berlin: .owner field is setup by core Michal Simek
2015-06-24 8:40 ` [PATCH 2/3] phy: berlin: Do not use sata name in usb phy driver Michal Simek
2015-06-26 8:59 ` Antoine Tenart
2015-06-24 8:40 ` [PATCH 3/3] usb: berlin: Trivial coding style cleanup Michal Simek
2015-06-26 8:59 ` Antoine Tenart
2015-07-15 12:43 ` Kishon Vijay Abraham I
2015-06-26 8:59 ` [PATCH 1/3] phy: berlin: .owner field is setup by core Antoine Tenart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.