From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: Will Deacon <Will.Deacon-5wv7dgnIgG8@public.gmane.org>,
Catalin Marinas <Catalin.Marinas-5wv7dgnIgG8@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 3/4] arm64: dts: add Rockchip rk3368 core dtsi and board dts for the r88 board
Date: Fri, 26 Jun 2015 10:34:01 +0100 [thread overview]
Message-ID: <20150626093400.GA19947@leverpostej> (raw)
In-Reply-To: <3220645.At1oVfRcjk@diego>
[...]
> + memory {
> + reg = <0x0 0x0 0x0 0x40000000>;
> + };
This needs device_type = "memory", no?
I guess the bootloader is overriding this anyway?
Otherwise this looked fine to me.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] arm64: dts: add Rockchip rk3368 core dtsi and board dts for the r88 board
Date: Fri, 26 Jun 2015 10:34:01 +0100 [thread overview]
Message-ID: <20150626093400.GA19947@leverpostej> (raw)
In-Reply-To: <3220645.At1oVfRcjk@diego>
[...]
> + memory {
> + reg = <0x0 0x0 0x0 0x40000000>;
> + };
This needs device_type = "memory", no?
I guess the bootloader is overriding this anyway?
Otherwise this looked fine to me.
Thanks,
Mark.
next prev parent reply other threads:[~2015-06-26 9:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 18:12 [PATCH 0/4] arm64: add initial support for the Rockchip rk3368 Heiko Stübner
2015-06-25 18:12 ` Heiko Stübner
2015-06-25 18:13 ` [PATCH 1/4] arm64: add Rockchip architecture entry Heiko Stübner
2015-06-25 18:13 ` Heiko Stübner
2015-06-25 18:14 ` [PATCH 2/4] arm64: defconfig: enable ARCH_ROCKCHIP Heiko Stübner
2015-06-25 18:14 ` Heiko Stübner
2015-06-25 18:14 ` [PATCH 3/4] arm64: dts: add Rockchip rk3368 core dtsi and board dts for the r88 board Heiko Stübner
2015-06-25 18:14 ` Heiko Stübner
2015-06-26 9:34 ` Mark Rutland [this message]
2015-06-26 9:34 ` Mark Rutland
2015-06-25 18:15 ` [PATCH 4/4] dt-bindings: document rk3368 R89 board from Rockchip Heiko Stübner
2015-06-25 18:15 ` Heiko Stübner
2015-06-26 4:35 ` [PATCH 0/4] arm64: add initial support for the Rockchip rk3368 Bamvor Jian Zhang
2015-06-26 4:35 ` Bamvor Jian Zhang
[not found] ` <558CD6AE.7030505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-06-26 7:17 ` Heiko Stübner
2015-06-26 7:17 ` Heiko Stübner
2015-06-26 13:30 ` Bamvor Zhang
2015-06-26 13:30 ` Bamvor Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150626093400.GA19947@leverpostej \
--to=mark.rutland-5wv7dgnigg8@public.gmane.org \
--cc=Catalin.Marinas-5wv7dgnIgG8@public.gmane.org \
--cc=Pawel.Moll-5wv7dgnIgG8@public.gmane.org \
--cc=Will.Deacon-5wv7dgnIgG8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.