From: Will Deacon <will.deacon@arm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: arm64 allmodconfig failure in expansion of macro ‘_X’
Date: Fri, 26 Jun 2015 11:11:47 +0100 [thread overview]
Message-ID: <20150626101147.GD1568@arm.com> (raw)
In-Reply-To: <20150626100944.GA19292@gondor.apana.org.au>
On Fri, Jun 26, 2015 at 11:09:44AM +0100, Herbert Xu wrote:
> On Fri, Jun 26, 2015 at 11:08:05AM +0100, Will Deacon wrote:
> > Hi all,
> >
> > arm64 allmodconfig fails to build with mainline due to the following:
> >
> >
> > In file included from include/acpi/platform/aclinux.h:74:0,
> > from include/acpi/platform/acenv.h:173,
> > from include/acpi/acpi.h:56,
> > from include/linux/acpi.h:37,
> > from ./arch/arm64/include/asm/dma-mapping.h:21,
> > from include/linux/dma-mapping.h:86,
> > from include/linux/skbuff.h:34,
> > from include/crypto/algapi.h:18,
> > from crypto/asymmetric_keys/rsa.c:16:
> > include/linux/ctype.h:15:12: error: expected ‘;’, ‘,’ or ‘)’ before numeric constant
> > #define _X 0x40 /* hex digit */
> > ^
> > crypto/asymmetric_keys/rsa.c:123:47: note: in expansion of macro ‘_X’
> > static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X)
> > ^
> > crypto/asymmetric_keys/rsa.c: In function ‘RSA_verify_signature’:
> > crypto/asymmetric_keys/rsa.c:256:2: error: implicit declaration of function ‘RSA_I2OSP’ [-Werror=implicit-function-declaration]
> > ret = RSA_I2OSP(m, k, &EM);
> >
> >
> > This is thanks to the following function type:
> >
> > static int RSA_I2OSP(MPI x, size_t xLen, u8 **__X)
> >
> > conflicting with the _X #define in linux/ctype.h:
> >
> > #define _X 0x40 /* hex digit */
> >
> > Simple patch below, but solving this problem with more underscores feels
> > slightly inhumane.
>
> Thanks but I've already merged a similar patch yesterday.
Perfect, sorry for the noise.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: arm64 allmodconfig failure in expansion of macro ‘_X’
Date: Fri, 26 Jun 2015 11:11:47 +0100 [thread overview]
Message-ID: <20150626101147.GD1568@arm.com> (raw)
In-Reply-To: <20150626100944.GA19292@gondor.apana.org.au>
On Fri, Jun 26, 2015 at 11:09:44AM +0100, Herbert Xu wrote:
> On Fri, Jun 26, 2015 at 11:08:05AM +0100, Will Deacon wrote:
> > Hi all,
> >
> > arm64 allmodconfig fails to build with mainline due to the following:
> >
> >
> > In file included from include/acpi/platform/aclinux.h:74:0,
> > from include/acpi/platform/acenv.h:173,
> > from include/acpi/acpi.h:56,
> > from include/linux/acpi.h:37,
> > from ./arch/arm64/include/asm/dma-mapping.h:21,
> > from include/linux/dma-mapping.h:86,
> > from include/linux/skbuff.h:34,
> > from include/crypto/algapi.h:18,
> > from crypto/asymmetric_keys/rsa.c:16:
> > include/linux/ctype.h:15:12: error: expected ?;?, ?,? or ?)? before numeric constant
> > #define _X 0x40 /* hex digit */
> > ^
> > crypto/asymmetric_keys/rsa.c:123:47: note: in expansion of macro ?_X?
> > static int RSA_I2OSP(MPI x, size_t xLen, u8 **_X)
> > ^
> > crypto/asymmetric_keys/rsa.c: In function ?RSA_verify_signature?:
> > crypto/asymmetric_keys/rsa.c:256:2: error: implicit declaration of function ?RSA_I2OSP? [-Werror=implicit-function-declaration]
> > ret = RSA_I2OSP(m, k, &EM);
> >
> >
> > This is thanks to the following function type:
> >
> > static int RSA_I2OSP(MPI x, size_t xLen, u8 **__X)
> >
> > conflicting with the _X #define in linux/ctype.h:
> >
> > #define _X 0x40 /* hex digit */
> >
> > Simple patch below, but solving this problem with more underscores feels
> > slightly inhumane.
>
> Thanks but I've already merged a similar patch yesterday.
Perfect, sorry for the noise.
Will
next prev parent reply other threads:[~2015-06-26 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 10:08 arm64 allmodconfig failure in expansion of macro ‘_X’ Will Deacon
2015-06-26 10:08 ` Will Deacon
2015-06-26 10:09 ` Herbert Xu
2015-06-26 10:09 ` Herbert Xu
2015-06-26 10:11 ` Will Deacon [this message]
2015-06-26 10:11 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150626101147.GD1568@arm.com \
--to=will.deacon@arm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.