From: Mel Gorman <mgorman@suse.de>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
iamjoonsoo.kim@lge.com, David Rientjes <rientjes@google.com>,
sasha.levin@oracle.com, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: fix set pageblock migratetype when boot
Date: Fri, 26 Jun 2015 12:04:24 +0100 [thread overview]
Message-ID: <20150626110424.GI26927@suse.de> (raw)
In-Reply-To: <558D24C1.5020901@huawei.com>
On Fri, Jun 26, 2015 at 06:09:05PM +0800, Xishi Qiu wrote:
> memmap_init_zone()
> ...
> if ((z->zone_start_pfn <= pfn)
> && (pfn < zone_end_pfn(z))
> && !(pfn & (pageblock_nr_pages - 1)))
> set_pageblock_migratetype(page, MIGRATE_MOVABLE);
> ...
>
> If the pfn does not align to pageblock, it will not init the migratetype.
What important impact does that have? It should leave a partial pageblock
as MIGRATE_UNMOVABLE which is fine by me.
> So call it for every page, it will takes more time, but it doesn't matter,
> this function will be called only in boot or hotadd memory.
>
It's a lot of additional overhead to add to memory initialisation. It
would need to be for an excellent reason with no alternative solution.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
iamjoonsoo.kim@lge.com, David Rientjes <rientjes@google.com>,
sasha.levin@oracle.com, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: fix set pageblock migratetype when boot
Date: Fri, 26 Jun 2015 12:04:24 +0100 [thread overview]
Message-ID: <20150626110424.GI26927@suse.de> (raw)
In-Reply-To: <558D24C1.5020901@huawei.com>
On Fri, Jun 26, 2015 at 06:09:05PM +0800, Xishi Qiu wrote:
> memmap_init_zone()
> ...
> if ((z->zone_start_pfn <= pfn)
> && (pfn < zone_end_pfn(z))
> && !(pfn & (pageblock_nr_pages - 1)))
> set_pageblock_migratetype(page, MIGRATE_MOVABLE);
> ...
>
> If the pfn does not align to pageblock, it will not init the migratetype.
What important impact does that have? It should leave a partial pageblock
as MIGRATE_UNMOVABLE which is fine by me.
> So call it for every page, it will takes more time, but it doesn't matter,
> this function will be called only in boot or hotadd memory.
>
It's a lot of additional overhead to add to memory initialisation. It
would need to be for an excellent reason with no alternative solution.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2015-06-26 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 10:09 [PATCH] mm: fix set pageblock migratetype when boot Xishi Qiu
2015-06-26 10:09 ` Xishi Qiu
2015-06-26 11:04 ` Mel Gorman [this message]
2015-06-26 11:04 ` Mel Gorman
2015-06-26 11:25 ` Xishi Qiu
2015-06-26 11:25 ` Xishi Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150626110424.GI26927@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=qiuxishi@huawei.com \
--cc=rientjes@google.com \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.