All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [RFC][PATCHv3 3/7] zsmalloc: always keep per-class stats
Date: Mon, 29 Jun 2015 15:40:29 +0900	[thread overview]
Message-ID: <20150629064029.GA13179@bbox> (raw)
In-Reply-To: <1434628004-11144-4-git-send-email-sergey.senozhatsky@gmail.com>

On Thu, Jun 18, 2015 at 08:46:40PM +0900, Sergey Senozhatsky wrote:
> Always account per-class `zs_size_stat' stats. This data will
> help us make better decisions during compaction. We are especially
> interested in OBJ_ALLOCATED and OBJ_USED, which can tell us if
> class compaction will result in any memory gain.
> 
> For instance, we know the number of allocated objects in the class,
> the number of objects being used (so we also know how many objects
> are not used) and the number of objects per-page. So we can ensure
> if we have enough unused objects to form at least one ZS_EMPTY
> zspage during compaction.
> 
> We calculate this value on per-class basis so we can calculate a
> total number of zspages that can be released. Which is exactly what
> a shrinker wants to know.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [RFC][PATCHv3 3/7] zsmalloc: always keep per-class stats
Date: Mon, 29 Jun 2015 15:40:29 +0900	[thread overview]
Message-ID: <20150629064029.GA13179@bbox> (raw)
In-Reply-To: <1434628004-11144-4-git-send-email-sergey.senozhatsky@gmail.com>

On Thu, Jun 18, 2015 at 08:46:40PM +0900, Sergey Senozhatsky wrote:
> Always account per-class `zs_size_stat' stats. This data will
> help us make better decisions during compaction. We are especially
> interested in OBJ_ALLOCATED and OBJ_USED, which can tell us if
> class compaction will result in any memory gain.
> 
> For instance, we know the number of allocated objects in the class,
> the number of objects being used (so we also know how many objects
> are not used) and the number of objects per-page. So we can ensure
> if we have enough unused objects to form at least one ZS_EMPTY
> zspage during compaction.
> 
> We calculate this value on per-class basis so we can calculate a
> total number of zspages that can be released. Which is exactly what
> a shrinker wants to know.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>


  reply	other threads:[~2015-06-29  6:40 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18 11:46 [RFC][PATCH v3 0/7] introduce automatic pool compaction Sergey Senozhatsky
2015-06-18 11:46 ` Sergey Senozhatsky
2015-06-18 11:46 ` [RFC][PATCHv3 1/7] zsmalloc: drop unused variable `nr_to_migrate' Sergey Senozhatsky
2015-06-18 11:46   ` Sergey Senozhatsky
2015-06-18 11:46 ` [RFC][PATCHv3 2/7] zsmalloc: partial page ordering within a fullness_list Sergey Senozhatsky
2015-06-18 11:46   ` Sergey Senozhatsky
2015-06-18 12:13   ` Sergey Senozhatsky
2015-06-18 12:13     ` Sergey Senozhatsky
2015-06-18 12:45     ` Sergey Senozhatsky
2015-06-18 12:45       ` Sergey Senozhatsky
2015-06-18 12:48     ` Sergey Senozhatsky
2015-06-18 12:48       ` Sergey Senozhatsky
2015-06-18 14:43     ` Sergey Senozhatsky
2015-06-18 14:43       ` Sergey Senozhatsky
2015-06-29  6:52   ` Minchan Kim
2015-06-29  6:52     ` Minchan Kim
2015-06-29 23:41     ` Sergey Senozhatsky
2015-06-29 23:41       ` Sergey Senozhatsky
2015-06-30  0:42       ` Minchan Kim
2015-06-30  0:42         ` Minchan Kim
2015-06-18 11:46 ` [RFC][PATCHv3 3/7] zsmalloc: always keep per-class stats Sergey Senozhatsky
2015-06-18 11:46   ` Sergey Senozhatsky
2015-06-29  6:40   ` Minchan Kim [this message]
2015-06-29  6:40     ` Minchan Kim
2015-06-29  9:06     ` Sergey Senozhatsky
2015-06-29  9:06       ` Sergey Senozhatsky
2015-06-18 11:46 ` [RFC][PATCHv3 4/7] zsmalloc: introduce zs_can_compact() function Sergey Senozhatsky
2015-06-18 11:46   ` Sergey Senozhatsky
2015-06-29  6:45   ` Minchan Kim
2015-06-29  6:45     ` Minchan Kim
2015-06-29  8:58     ` Sergey Senozhatsky
2015-06-29  8:58       ` Sergey Senozhatsky
2015-06-18 11:46 ` [RFC][PATCHv3 5/7] zsmalloc: cosmetic compaction code adjustments Sergey Senozhatsky
2015-06-18 11:46   ` Sergey Senozhatsky
2015-06-18 11:46 ` [RFC][PATCHv3 6/7] zsmalloc/zram: move `num_migrated' to zs_pool Sergey Senozhatsky
2015-06-18 11:46   ` Sergey Senozhatsky
2015-06-18 11:46 ` [RFC][PATCHv3 7/7] zsmalloc: register a shrinker to trigger auto-compaction Sergey Senozhatsky
2015-06-18 11:46   ` Sergey Senozhatsky
2015-06-29  7:07   ` Minchan Kim
2015-06-29  7:07     ` Minchan Kim
2015-06-29  8:57     ` Sergey Senozhatsky
2015-06-29  8:57       ` Sergey Senozhatsky
2015-06-29 13:39       ` Minchan Kim
2015-06-29 13:39         ` Minchan Kim
2015-06-29 23:36         ` Sergey Senozhatsky
2015-06-29 23:36           ` Sergey Senozhatsky
2015-06-18 12:17 ` [RFC][PATCH v3 0/7] introduce automatic pool compaction Sergey Senozhatsky
2015-06-18 12:17   ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150629064029.GA13179@bbox \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.