From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christoph Hellwig <hch@lst.de>,
Dan Williams <dan.j.williams@intel.com>,
Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Juergen Gross <jgross@suse.com>, X86 ML <x86@kernel.org>,
"Kani, Toshimitsu" <toshi.kani@hp.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Luis Rodriguez <mcgrof@suse.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stefan Bader <stefan.bader@canonical.com>,
Andy Lutomirski <luto@amacapital.net>,
Linux MM <linux-mm@kvack.org>, Ralf Baechle <ralf@linux-mips.org>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Michael Ellerman <mpe@ellerman.id.au>, Tejun Heo <tj@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 2/6] arch: unify ioremap prototypes and macro aliases
Date: Wed, 1 Jul 2015 08:59:48 +0200 [thread overview]
Message-ID: <20150701065948.GA4355@lst.de> (raw)
In-Reply-To: <CAMuHMdUO4uSWH1Qc0SfDTLuXbiG2N9fq8Tf6j+3RoqVKdPugbA@mail.gmail.com>
On Wed, Jul 01, 2015 at 08:55:57AM +0200, Geert Uytterhoeven wrote:
> >
> > I think doing this at runtime might be a better idea. E.g. a
> > ioremap_flags with the CACHED argument will return -EOPNOTSUP unless
> > actually implemented. On various architectures different CPUs or
> > boards will have different capabilities in this area.
>
> So it would be the responsibility of the caller to fall back from
> ioremap(..., CACHED) to ioremap(..., UNCACHED)?
> I.e. all drivers using it should be changed...
All of the zero users we currently have will need to be changed, yes.
Note that I propose to leave ioremap(), aka ioremap_flags(..., 0) as
a default that always has to work, -EOPNOTSUP is only a valid return
value for non-default flaga.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/6] arch: unify ioremap prototypes and macro aliases
Date: Wed, 1 Jul 2015 08:59:48 +0200 [thread overview]
Message-ID: <20150701065948.GA4355@lst.de> (raw)
In-Reply-To: <CAMuHMdUO4uSWH1Qc0SfDTLuXbiG2N9fq8Tf6j+3RoqVKdPugbA@mail.gmail.com>
On Wed, Jul 01, 2015 at 08:55:57AM +0200, Geert Uytterhoeven wrote:
> >
> > I think doing this at runtime might be a better idea. E.g. a
> > ioremap_flags with the CACHED argument will return -EOPNOTSUP unless
> > actually implemented. On various architectures different CPUs or
> > boards will have different capabilities in this area.
>
> So it would be the responsibility of the caller to fall back from
> ioremap(..., CACHED) to ioremap(..., UNCACHED)?
> I.e. all drivers using it should be changed...
All of the zero users we currently have will need to be changed, yes.
Note that I propose to leave ioremap(), aka ioremap_flags(..., 0) as
a default that always has to work, -EOPNOTSUP is only a valid return
value for non-default flaga.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christoph Hellwig <hch@lst.de>,
Dan Williams <dan.j.williams@intel.com>,
Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Juergen Gross <jgross@suse.com>, X86 ML <x86@kernel.org>,
"Kani, Toshimitsu" <toshi.kani@hp.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Luis Rodriguez <mcgrof@suse.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stefan Bader <stefan.bader@canonical.com>,
Andy Lutomirski <luto@amacapital.net>,
Linux MM <linux-mm@kvack.org>, Ralf Baechle <ralf@linux-mips.org>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Michael Ellerman <mpe@ellerman.id.au>, Tejun Heo <tj@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 2/6] arch: unify ioremap prototypes and macro aliases
Date: Wed, 1 Jul 2015 08:59:48 +0200 [thread overview]
Message-ID: <20150701065948.GA4355@lst.de> (raw)
In-Reply-To: <CAMuHMdUO4uSWH1Qc0SfDTLuXbiG2N9fq8Tf6j+3RoqVKdPugbA@mail.gmail.com>
On Wed, Jul 01, 2015 at 08:55:57AM +0200, Geert Uytterhoeven wrote:
> >
> > I think doing this at runtime might be a better idea. E.g. a
> > ioremap_flags with the CACHED argument will return -EOPNOTSUP unless
> > actually implemented. On various architectures different CPUs or
> > boards will have different capabilities in this area.
>
> So it would be the responsibility of the caller to fall back from
> ioremap(..., CACHED) to ioremap(..., UNCACHED)?
> I.e. all drivers using it should be changed...
All of the zero users we currently have will need to be changed, yes.
Note that I propose to leave ioremap(), aka ioremap_flags(..., 0) as
a default that always has to work, -EOPNOTSUP is only a valid return
value for non-default flaga.
next prev parent reply other threads:[~2015-07-01 6:59 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 8:24 [PATCH v5 0/6] pmem api, generic ioremap_cache, and memremap Dan Williams
2015-06-22 8:24 ` Dan Williams
2015-06-22 8:24 ` [PATCH v5 1/6] arch, drivers: don't include <asm/io.h> directly, use <linux/io.h> instead Dan Williams
2015-06-22 8:24 ` Dan Williams
2015-06-22 16:01 ` Christoph Hellwig
2015-06-22 16:01 ` Christoph Hellwig
2015-06-22 8:24 ` [PATCH v5 2/6] arch: unify ioremap prototypes and macro aliases Dan Williams
2015-06-22 8:24 ` Dan Williams
2015-06-22 16:10 ` Christoph Hellwig
2015-06-22 16:10 ` Christoph Hellwig
2015-06-22 17:12 ` Dan Williams
2015-06-22 17:12 ` Dan Williams
2015-06-23 10:07 ` Christoph Hellwig
2015-06-23 10:07 ` Christoph Hellwig
2015-06-23 15:04 ` Dan Williams
2015-06-23 15:04 ` Dan Williams
2015-06-24 12:24 ` Christoph Hellwig
2015-06-24 12:24 ` Christoph Hellwig
2015-06-30 22:57 ` Dan Williams
2015-06-30 22:57 ` Dan Williams
2015-06-30 22:57 ` Dan Williams
2015-07-01 6:23 ` Christoph Hellwig
2015-07-01 6:23 ` Christoph Hellwig
2015-07-01 6:23 ` Christoph Hellwig
2015-07-01 6:55 ` Geert Uytterhoeven
2015-07-01 6:55 ` Geert Uytterhoeven
2015-07-01 6:55 ` Geert Uytterhoeven
2015-07-01 6:59 ` Christoph Hellwig [this message]
2015-07-01 6:59 ` Christoph Hellwig
2015-07-01 6:59 ` Christoph Hellwig
2015-07-01 7:19 ` Geert Uytterhoeven
2015-07-01 7:19 ` Geert Uytterhoeven
2015-07-01 7:19 ` Geert Uytterhoeven
2015-07-01 7:28 ` Christoph Hellwig
2015-07-01 7:28 ` Christoph Hellwig
2015-07-01 7:28 ` Christoph Hellwig
2015-07-07 9:50 ` Luis R. Rodriguez
2015-07-07 9:50 ` Luis R. Rodriguez
2015-07-07 9:50 ` Luis R. Rodriguez
2015-07-07 10:13 ` Russell King - ARM Linux
2015-07-07 10:13 ` Russell King - ARM Linux
2015-07-07 10:13 ` Russell King - ARM Linux
2015-07-07 10:27 ` Geert Uytterhoeven
2015-07-07 10:27 ` Geert Uytterhoeven
2015-07-07 10:27 ` Geert Uytterhoeven
2015-07-07 16:07 ` Luis R. Rodriguez
2015-07-07 16:07 ` Luis R. Rodriguez
2015-07-07 16:07 ` Luis R. Rodriguez
2015-07-07 23:10 ` Toshi Kani
2015-07-07 23:10 ` Toshi Kani
2015-07-07 23:10 ` Toshi Kani
2015-07-09 1:40 ` Luis R. Rodriguez
2015-07-09 1:40 ` Luis R. Rodriguez
2015-07-09 1:40 ` Luis R. Rodriguez
2015-07-09 23:43 ` Toshi Kani
2015-07-09 23:43 ` Toshi Kani
2015-07-09 23:43 ` Toshi Kani
2015-07-01 8:09 ` Russell King - ARM Linux
2015-07-01 8:09 ` Russell King - ARM Linux
2015-07-01 8:09 ` Russell King - ARM Linux
2015-07-01 16:47 ` Dan Williams
2015-07-01 16:47 ` Dan Williams
2015-07-01 16:47 ` Dan Williams
2015-07-09 18:54 ` Luis R. Rodriguez
2015-07-09 18:54 ` Luis R. Rodriguez
2015-06-22 8:24 ` [PATCH v5 3/6] cleanup IORESOURCE_CACHEABLE vs ioremap() Dan Williams
2015-06-22 8:24 ` Dan Williams
2015-06-22 8:24 ` [PATCH v5 4/6] devm: fix ioremap_cache() usage Dan Williams
2015-06-22 8:24 ` Dan Williams
2015-06-22 8:24 ` [PATCH v5 5/6] arch: introduce memremap_cache() and memremap_wt() Dan Williams
2015-06-22 8:24 ` Dan Williams
2015-06-22 8:24 ` [PATCH v5 6/6] arch, x86: pmem api for ensuring durability of persistent memory updates Dan Williams
2015-06-22 8:24 ` Dan Williams
2015-06-22 16:17 ` Christoph Hellwig
2015-06-22 16:17 ` Christoph Hellwig
2015-06-22 17:51 ` Dan Williams
2015-06-22 17:51 ` Dan Williams
2015-06-23 10:09 ` Christoph Hellwig
2015-06-23 10:09 ` Christoph Hellwig
2015-06-23 10:39 ` Richard Weinberger
2015-06-23 10:39 ` Richard Weinberger
2015-06-24 12:08 ` Christoph Hellwig
2015-06-24 12:08 ` Christoph Hellwig
2015-06-24 12:35 ` Richard Weinberger
2015-06-24 12:35 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150701065948.GA4355@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=geert@linux-m68k.org \
--cc=hmh@hmh.eng.br \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux@arm.linux.org.uk \
--cc=luto@amacapital.net \
--cc=mcgrof@suse.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=ross.zwisler@linux.intel.com \
--cc=stefan.bader@canonical.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.