All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoffer Dall <christoffer.dall@linaro.org>
To: Mario Smarduch <m.smarduch@samsung.com>
Cc: kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com,
	linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
	catalin.marinas@arm.com, will.deacon@arm.com
Subject: Re: [PATCH v3 0/2] arm/arm64: KVM: Optimize arm64 fp/simd, saves 30-50% on exits
Date: Wed, 1 Jul 2015 11:49:10 +0200	[thread overview]
Message-ID: <20150701094910.GF11332@cbox> (raw)
In-Reply-To: <1435190652-5831-1-git-send-email-m.smarduch@samsung.com>

On Wed, Jun 24, 2015 at 05:04:10PM -0700, Mario Smarduch wrote:
> Currently we save/restore fp/simd on each exit. Fist  patch optimizes arm64
> save/restore, we only do so on Guest access. hackbench and
> several lmbench tests show anywhere from 30% to above 50% optimzation
> achieved.
> 
> In second patch 32-bit handler is updated to keep exit handling consistent
> with 64-bit code.

30-50% of what?  The overhead or overall performance?

> 
> Changes since v1:
> - Addressed Marcs comments
> - Verified optimization improvements with lmbench and hackbench, updated 
>   commit message
> 
> Changes since v2:
> - only for patch 2/2
>   - Reworked trapping to vfp access handler
> 
> Changes since v3:
> - Only for patch 2/2
>   - Removed load_vcpu in switch_to_guest_vfp per Marcs comment
>   - Got another chance to replace an unreferenced label with a comment
> 
> 
> Mario Smarduch (2):
>   Optimize arm64 skip 30-50% vfp/simd save/restore on exits
>   keep arm vfp/simd exit handling consistent with arm64
> 
>  arch/arm/kvm/interrupts.S        |   14 +++++++-----
>  arch/arm64/include/asm/kvm_arm.h |    5 ++++-
>  arch/arm64/kvm/hyp.S             |   46 +++++++++++++++++++++++++++++++++++---
>  3 files changed, 55 insertions(+), 10 deletions(-)
> 
> -- 
> 1.7.9.5
> 

WARNING: multiple messages have this Message-ID (diff)
From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/2] arm/arm64: KVM: Optimize arm64 fp/simd, saves 30-50% on exits
Date: Wed, 1 Jul 2015 11:49:10 +0200	[thread overview]
Message-ID: <20150701094910.GF11332@cbox> (raw)
In-Reply-To: <1435190652-5831-1-git-send-email-m.smarduch@samsung.com>

On Wed, Jun 24, 2015 at 05:04:10PM -0700, Mario Smarduch wrote:
> Currently we save/restore fp/simd on each exit. Fist  patch optimizes arm64
> save/restore, we only do so on Guest access. hackbench and
> several lmbench tests show anywhere from 30% to above 50% optimzation
> achieved.
> 
> In second patch 32-bit handler is updated to keep exit handling consistent
> with 64-bit code.

30-50% of what?  The overhead or overall performance?

> 
> Changes since v1:
> - Addressed Marcs comments
> - Verified optimization improvements with lmbench and hackbench, updated 
>   commit message
> 
> Changes since v2:
> - only for patch 2/2
>   - Reworked trapping to vfp access handler
> 
> Changes since v3:
> - Only for patch 2/2
>   - Removed load_vcpu in switch_to_guest_vfp per Marcs comment
>   - Got another chance to replace an unreferenced label with a comment
> 
> 
> Mario Smarduch (2):
>   Optimize arm64 skip 30-50% vfp/simd save/restore on exits
>   keep arm vfp/simd exit handling consistent with arm64
> 
>  arch/arm/kvm/interrupts.S        |   14 +++++++-----
>  arch/arm64/include/asm/kvm_arm.h |    5 ++++-
>  arch/arm64/kvm/hyp.S             |   46 +++++++++++++++++++++++++++++++++++---
>  3 files changed, 55 insertions(+), 10 deletions(-)
> 
> -- 
> 1.7.9.5
> 

  parent reply	other threads:[~2015-07-01  9:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25  0:04 [PATCH v3 0/2] arm/arm64: KVM: Optimize arm64 fp/simd, saves 30-50% on exits Mario Smarduch
2015-06-25  0:04 ` Mario Smarduch
2015-06-25  0:04 ` [PATCH v3 1/2] arm64: KVM: Optimize arm64 skip 30-50% vfp/simd save/restore " Mario Smarduch
2015-06-25  0:04   ` Mario Smarduch
2015-07-01 13:46   ` Christoffer Dall
2015-07-01 13:46     ` Christoffer Dall
2015-07-02 21:51     ` Mario Smarduch
2015-07-02 21:51       ` Mario Smarduch
2015-07-03 11:53       ` Christoffer Dall
2015-07-03 11:53         ` Christoffer Dall
2015-07-03 18:56         ` Mario Smarduch
2015-07-03 18:56           ` Mario Smarduch
2015-06-25  0:04 ` [PATCH v3 2/2] arm: KVM: keep arm vfp/simd exit handling consistent with arm64 Mario Smarduch
2015-06-25  0:04   ` Mario Smarduch
2015-07-01 13:50   ` Christoffer Dall
2015-07-01 13:50     ` Christoffer Dall
2015-07-01  9:49 ` Christoffer Dall [this message]
2015-07-01  9:49   ` [PATCH v3 0/2] arm/arm64: KVM: Optimize arm64 fp/simd, saves 30-50% on exits Christoffer Dall
2015-07-02 17:49   ` Mario Smarduch
2015-07-02 17:49     ` Mario Smarduch
2015-07-02 20:58     ` Christoffer Dall
2015-07-02 20:58       ` Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150701094910.GF11332@cbox \
    --to=christoffer.dall@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=m.smarduch@samsung.com \
    --cc=marc.zyngier@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.