All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: rts5208: Fix checkpatch warning: else is not generally useful
@ 2015-07-01 16:44 Leung Timothy Chi King
  0 siblings, 0 replies; only message in thread
From: Leung Timothy Chi King @ 2015-07-01 16:44 UTC (permalink / raw)
  To: gregkh, fabio.falzoi84, joe, lambert.quentin, tinajohnson.1234
  Cc: contact, devel, linux-kernel

The following checkpatch warning was fixed:

WARNING: else is not generally useful after a break or return

Signed-off-by: Leung Timothy Chi King <contact@timothyleung.co>
---
 drivers/staging/rts5208/sd.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index a8d657b..cb41579 100644
--- a/drivers/staging/rts5208/sd.c
+++ b/drivers/staging/rts5208/sd.c
@@ -3520,12 +3520,11 @@ int reset_sd_card(struct rtsx_chip *chip)
 			if (chip->sd_io) {
 				rtsx_trace(chip);
 				return STATUS_FAIL;
-			} else {
-				retval = reset_mmc(chip);
-				if (retval != STATUS_SUCCESS) {
-					rtsx_trace(chip);
-					return STATUS_FAIL;
-				}
+			}
+			retval = reset_mmc(chip);
+			if (retval != STATUS_SUCCESS) {
+				rtsx_trace(chip);
+				return STATUS_FAIL;
 			}
 		}
 	}
-- 
1.9.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-07-01 16:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-01 16:44 [PATCH] Staging: rts5208: Fix checkpatch warning: else is not generally useful Leung Timothy Chi King

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.