From: Dave Chinner <david@fromorbit.com>
To: Jan Tulak <jtulak@redhat.com>
Cc: hch@infradead.org, sandeen@redhat.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: blkid is now mandatory
Date: Thu, 2 Jul 2015 08:55:36 +1000 [thread overview]
Message-ID: <20150701225535.GT22807@dastard> (raw)
In-Reply-To: <1435766461-30961-1-git-send-email-jtulak@redhat.com>
On Wed, Jul 01, 2015 at 06:01:01PM +0200, Jan Tulak wrote:
> Because blkid is here for a long time, I hereby propose a patch for removing support
> for NOT having blkid. The current support through set of #ifdef is prone to errors like
> making a patch just in one of the branches, and according to a recent talk between
> Christoph and Eric, it is not necessary to keep it supported.
>
> Remove code for checking ENABLE_BLKID, and the code when ENABLE_BLKID is not defined.
> It makes blkid required for compilation.
>
> Signed-off-by: Jan Tulak <jtulak@redhat.com>
> ---
> Makefile | 5 ----
> configure.ac | 6 +----
> doc/INSTALL | 44 ------------------------------------
> include/builddefs.in | 1 -
> libdisk/Makefile | 4 ----
> m4/package_blkid.m4 | 7 +++---
> mkfs/Makefile | 21 ++++-------------
> mkfs/xfs_mkfs.c | 64 ----------------------------------------------------
> 8 files changed, 10 insertions(+), 142 deletions(-)
Given that only mkfs.xfs uses libdisk, which is now not linked to
any binary, shouldn't libdisk/ be removed completely?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-07-01 22:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 16:01 [PATCH] xfsprogs: blkid is now mandatory Jan Tulak
2015-07-01 22:55 ` Dave Chinner [this message]
2015-07-02 10:27 ` Jan Tulak
2015-07-02 10:43 ` [PATCH v2] " Jan Tulak
2015-07-03 15:19 ` Christoph Hellwig
2015-07-03 23:45 ` Dave Chinner
2015-07-07 15:10 ` Jan Tulak
2015-07-08 9:14 ` [PATCH v3] " Jan Tulak
2015-07-21 12:39 ` Jan Tulak
2015-07-26 16:25 ` Christoph Hellwig
2015-08-03 10:40 ` Jan Tulak
2015-08-03 17:20 ` Eric Sandeen
2015-08-04 15:30 ` Jan Tulak
2015-08-04 16:24 ` Eric Sandeen
2015-08-06 13:13 ` Jan Tulak
2015-08-11 16:40 ` Jan Tulak
2015-07-26 16:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150701225535.GT22807@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jtulak@redhat.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.