All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: <herbert@gondor.apana.org.au>, <linux-crypto@vger.kernel.org>,
	<davem@davemloft.net>, <linux-omap@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <t-kristo@ti.com>,
	<nsekhar@ti.com>
Subject: Re: [PATCH 01/10] crypto: omap-aes: Add support for lengths not aligned with AES_BLOCK_SIZE
Date: Thu, 2 Jul 2015 02:53:41 -0500	[thread overview]
Message-ID: <20150702075341.GA4033@saruman.tx.rr.com> (raw)
In-Reply-To: <1435814320-30347-2-git-send-email-lokeshvutla@ti.com>

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

On Thu, Jul 02, 2015 at 10:48:31AM +0530, Lokesh Vutla wrote:
> OMAP AES driver returns an error if the data is not aligned with
> AES_BLOCK_SIZE bytes.
> But OMAP AES hw allows data input upto 1 byte aligned, but still
> zeros are to be appended and complete AES_BLOCK_SIZE has to be written.
> And correct length has to be passed in LENGTH field.
> Adding support for inputs not aligned with AES_BLOCK_SIZE.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
>  drivers/crypto/omap-aes.c |   33 ++++++++++++++++-----------------
>  1 file changed, 16 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
> index 9a28b7e..a923101 100644
> --- a/drivers/crypto/omap-aes.c
> +++ b/drivers/crypto/omap-aes.c
> @@ -558,6 +558,9 @@ static int omap_aes_check_aligned(struct scatterlist *sg, int total)
>  {
>  	int len = 0;
>  
> +	if (!IS_ALIGNED(total, AES_BLOCK_SIZE))
> +		return -1;

-EINVAL?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
	davem@davemloft.net, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, t-kristo@ti.com, nsekhar@ti.com
Subject: Re: [PATCH 01/10] crypto: omap-aes: Add support for lengths not aligned with AES_BLOCK_SIZE
Date: Thu, 2 Jul 2015 02:53:41 -0500	[thread overview]
Message-ID: <20150702075341.GA4033@saruman.tx.rr.com> (raw)
In-Reply-To: <1435814320-30347-2-git-send-email-lokeshvutla@ti.com>

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

On Thu, Jul 02, 2015 at 10:48:31AM +0530, Lokesh Vutla wrote:
> OMAP AES driver returns an error if the data is not aligned with
> AES_BLOCK_SIZE bytes.
> But OMAP AES hw allows data input upto 1 byte aligned, but still
> zeros are to be appended and complete AES_BLOCK_SIZE has to be written.
> And correct length has to be passed in LENGTH field.
> Adding support for inputs not aligned with AES_BLOCK_SIZE.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
>  drivers/crypto/omap-aes.c |   33 ++++++++++++++++-----------------
>  1 file changed, 16 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
> index 9a28b7e..a923101 100644
> --- a/drivers/crypto/omap-aes.c
> +++ b/drivers/crypto/omap-aes.c
> @@ -558,6 +558,9 @@ static int omap_aes_check_aligned(struct scatterlist *sg, int total)
>  {
>  	int len = 0;
>  
> +	if (!IS_ALIGNED(total, AES_BLOCK_SIZE))
> +		return -1;

-EINVAL?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-07-02  7:53 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02  5:18 [PATCH 00/10] crypto: omap-aes: Add support for GCM mode Lokesh Vutla
2015-07-02  5:18 ` Lokesh Vutla
2015-07-02  5:18 ` [PATCH 01/10] crypto: omap-aes: Add support for lengths not aligned with AES_BLOCK_SIZE Lokesh Vutla
2015-07-02  5:18   ` Lokesh Vutla
2015-07-02  7:53   ` Felipe Balbi [this message]
2015-07-02  7:53     ` Felipe Balbi
2015-07-02  9:26     ` Lokesh Vutla
2015-07-02  9:26       ` Lokesh Vutla
2015-07-06  7:38   ` Herbert Xu
2015-07-02  5:18 ` [PATCH 02/10] crypto: omap-aes: Fix configuring of AES mode Lokesh Vutla
2015-07-02  5:18   ` Lokesh Vutla
2015-07-02  7:57   ` Felipe Balbi
2015-07-02  7:57     ` Felipe Balbi
2015-07-02  9:43     ` Lokesh Vutla
2015-07-02  9:43       ` Lokesh Vutla
2015-07-02  5:18 ` [PATCH 03/10] crypto: aead: Add aead_request_cast() api Lokesh Vutla
2015-07-02  5:18   ` Lokesh Vutla
2015-07-02  7:58   ` Felipe Balbi
2015-07-02  7:58     ` Felipe Balbi
2015-07-02  9:46     ` Lokesh Vutla
2015-07-02  9:46       ` Lokesh Vutla
2015-07-06  7:41   ` Herbert Xu
2015-07-02  5:18 ` [PATCH 04/10] crypto: omap-aes: Use BIT() macro Lokesh Vutla
2015-07-02  5:18   ` Lokesh Vutla
2015-07-02  7:59   ` Felipe Balbi
2015-07-02  7:59     ` Felipe Balbi
2015-07-06  7:42     ` Herbert Xu
2015-07-02  5:18 ` [PATCH 05/10] crypto: omap-aes: Add support for GCM mode Lokesh Vutla
2015-07-02  5:18   ` Lokesh Vutla
2015-07-02  8:04   ` Felipe Balbi
2015-07-02  8:04     ` Felipe Balbi
2015-07-02 10:10     ` Lokesh Vutla
2015-07-02 10:10       ` Lokesh Vutla
2015-07-02  5:18 ` [PATCH 06/10] crypto: omap-aes: gcm: Handle inputs properly Lokesh Vutla
2015-07-02  5:18   ` Lokesh Vutla
2015-07-02  8:04   ` Felipe Balbi
2015-07-02  8:04     ` Felipe Balbi
2015-07-02 10:13     ` Lokesh Vutla
2015-07-02 10:13       ` Lokesh Vutla
2015-07-02  5:18 ` [PATCH 07/10] crypto: omap-aes: gcm: Add support for unaligned lengths Lokesh Vutla
2015-07-02  5:18   ` Lokesh Vutla
2015-07-02  8:05   ` Felipe Balbi
2015-07-02  8:05     ` Felipe Balbi
2015-07-02  5:18 ` [PATCH 08/10] crypto: omap-aes: gmc: Add algo info Lokesh Vutla
2015-07-02  5:18   ` Lokesh Vutla
2015-07-02  8:00   ` Stephan Mueller
2015-07-02  9:54     ` Lokesh Vutla
2015-07-02  9:54       ` Lokesh Vutla
2015-07-02  9:56       ` Stephan Mueller
2015-07-06  7:35   ` Herbert Xu
2015-07-06  8:15     ` Lokesh Vutla
2015-07-06  8:15       ` Lokesh Vutla
2015-07-02  5:18 ` [PATCH 09/10] crypto: omap-aes: gcm: Add support for PIO mode Lokesh Vutla
2015-07-02  5:18   ` Lokesh Vutla
2015-07-02  8:06   ` Felipe Balbi
2015-07-02  8:06     ` Felipe Balbi
2015-07-02 10:17     ` Lokesh Vutla
2015-07-02 10:17       ` Lokesh Vutla
2015-07-02  5:18 ` [PATCH 10/10] crypto: tcrypt: Added speed tests for Async AEAD crypto alogrithms Lokesh Vutla
2015-07-02  5:18   ` Lokesh Vutla
2015-07-06  7:44   ` Herbert Xu
2015-07-06  8:45     ` Lokesh Vutla
2015-07-06  8:45       ` Lokesh Vutla
2015-07-06  8:49       ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150702075341.GA4033@saruman.tx.rr.com \
    --to=balbi@ti.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=nsekhar@ti.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.