All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Julien Grall <julien.grall@citrix.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
	netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	fw@strlen.de, linux-kernel@vger.kernel.org,
	Bernhard Thaler <bernhard.thaler@wvnet.at>,
	xen-devel@lists.xenproject.org, davem@davemloft.net,
	Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [Bridge] [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6
Date: Fri, 3 Jul 2015 22:42:13 +0200	[thread overview]
Message-ID: <20150703204213.GM16529@breakpoint.cc> (raw)
In-Reply-To: <1435946491-11148-1-git-send-email-julien.grall@citrix.com>

Julien Grall <julien.grall@citrix.com> wrote:
> The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd "netfilter: bridge:
> forward IPv6 fragmented packets" introduced a new function
> br_validate_ipv6 which take a reference on the inet6 device. Although,
> the reference is not released at the end.
> 
> This will result to the impossibility to destroy any netdevice using
> ipv6 and bridge.
> 
> Spotted while trying to destroy a Xen guest on the upstream Linux:
> "unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1"

Ugh :-/

I think it makes more sense to use __in6_dev_get() instead which doesn't
take a reference.

WARNING: multiple messages have this Message-ID (diff)
From: Florian Westphal <fw@strlen.de>
To: Julien Grall <julien.grall@citrix.com>
Cc: stephen@networkplumber.org, davem@davemloft.net,
	bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	Bernhard Thaler <bernhard.thaler@wvnet.at>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	fw@strlen.de, ian.campbell@citrix.com, wei.liu2@citrix.com
Subject: Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6
Date: Fri, 3 Jul 2015 22:42:13 +0200	[thread overview]
Message-ID: <20150703204213.GM16529@breakpoint.cc> (raw)
In-Reply-To: <1435946491-11148-1-git-send-email-julien.grall@citrix.com>

Julien Grall <julien.grall@citrix.com> wrote:
> The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd "netfilter: bridge:
> forward IPv6 fragmented packets" introduced a new function
> br_validate_ipv6 which take a reference on the inet6 device. Although,
> the reference is not released at the end.
> 
> This will result to the impossibility to destroy any netdevice using
> ipv6 and bridge.
> 
> Spotted while trying to destroy a Xen guest on the upstream Linux:
> "unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1"

Ugh :-/

I think it makes more sense to use __in6_dev_get() instead which doesn't
take a reference.

WARNING: multiple messages have this Message-ID (diff)
From: Florian Westphal <fw@strlen.de>
To: Julien Grall <julien.grall@citrix.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
	netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	fw@strlen.de, linux-kernel@vger.kernel.org,
	Bernhard Thaler <bernhard.thaler@wvnet.at>,
	xen-devel@lists.xenproject.org, davem@davemloft.net,
	Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6
Date: Fri, 3 Jul 2015 22:42:13 +0200	[thread overview]
Message-ID: <20150703204213.GM16529@breakpoint.cc> (raw)
In-Reply-To: <1435946491-11148-1-git-send-email-julien.grall@citrix.com>

Julien Grall <julien.grall@citrix.com> wrote:
> The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd "netfilter: bridge:
> forward IPv6 fragmented packets" introduced a new function
> br_validate_ipv6 which take a reference on the inet6 device. Although,
> the reference is not released at the end.
> 
> This will result to the impossibility to destroy any netdevice using
> ipv6 and bridge.
> 
> Spotted while trying to destroy a Xen guest on the upstream Linux:
> "unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1"

Ugh :-/

I think it makes more sense to use __in6_dev_get() instead which doesn't
take a reference.

  parent reply	other threads:[~2015-07-03 20:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-03 18:01 [Bridge] [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6 Julien Grall
2015-07-03 18:01 ` Julien Grall
2015-07-03 20:42 ` Florian Westphal
2015-07-03 20:42 ` Florian Westphal [this message]
2015-07-03 20:42   ` Florian Westphal
2015-07-03 20:42   ` Florian Westphal
2015-07-06 10:35   ` [Bridge] " Julien Grall
2015-07-06 10:35     ` Julien Grall
2015-07-06 11:16     ` Eric Dumazet
2015-07-06 11:16     ` [Bridge] " Eric Dumazet
2015-07-06 11:16       ` Eric Dumazet
2015-07-06 11:16       ` Eric Dumazet
2015-07-06 11:19     ` Florian Westphal
2015-07-06 11:19     ` [Bridge] " Florian Westphal
2015-07-06 11:19       ` Florian Westphal
2015-07-06 11:19       ` Florian Westphal
2015-07-06 11:32       ` Julien Grall
2015-07-06 11:32       ` [Bridge] [Xen-devel] " Julien Grall
2015-07-06 11:32         ` Julien Grall
2015-07-06 11:32         ` Julien Grall
2015-07-06 10:35   ` Julien Grall
2015-07-06  9:58 ` Bob Liu
2015-07-06  9:58 ` [Bridge] [Xen-devel] " Bob Liu
2015-07-06  9:58   ` Bob Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150703204213.GM16529@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=bernhard.thaler@wvnet.at \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=ian.campbell@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.