From: Theodore Ts'o <tytso@mit.edu>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext4: replace open coded nofail allocation
Date: Sun, 5 Jul 2015 17:06:00 -0400 [thread overview]
Message-ID: <20150705210600.GD8628@thunk.org> (raw)
In-Reply-To: <1435053037-1451-1-git-send-email-mhocko@suse.cz>
On Tue, Jun 23, 2015 at 11:50:37AM +0200, Michal Hocko wrote:
> ext4_free_blocks is looping around the allocation request and mimics
> __GFP_NOFAIL behavior without any allocation fallback strategy. Let's
> remove the open coded loop and replace it with __GFP_NOFAIL. Without
> the flag the allocator has no way to find out never-fail requirement
> and cannot help in any way.
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
Thanks, applied.
- Ted
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Ts'o" <tytso@mit.edu>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext4: replace open coded nofail allocation
Date: Sun, 5 Jul 2015 17:06:00 -0400 [thread overview]
Message-ID: <20150705210600.GD8628@thunk.org> (raw)
In-Reply-To: <1435053037-1451-1-git-send-email-mhocko@suse.cz>
On Tue, Jun 23, 2015 at 11:50:37AM +0200, Michal Hocko wrote:
> ext4_free_blocks is looping around the allocation request and mimics
> __GFP_NOFAIL behavior without any allocation fallback strategy. Let's
> remove the open coded loop and replace it with __GFP_NOFAIL. Without
> the flag the allocator has no way to find out never-fail requirement
> and cannot help in any way.
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2015-07-05 21:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 9:50 [PATCH] ext4: replace open coded nofail allocation Michal Hocko
2015-06-23 9:50 ` Michal Hocko
2015-06-23 9:50 ` Michal Hocko
2015-07-05 21:06 ` Theodore Ts'o [this message]
2015-07-05 21:06 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150705210600.GD8628@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.