All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage"
Date: Mon, 06 Jul 2015 20:33:58 -0500	[thread overview]
Message-ID: <20150707013358.17393.64638@loki> (raw)
In-Reply-To: <87y4jki2jy.fsf@blackfin.pond.sub.org>

Quoting Markus Armbruster (2015-06-16 01:34:57)
> Ping?

Applied, thanks.

> 
> Markus Armbruster <armbru@redhat.com> writes:
> 
> > Since we now require GLib 2.22+ (commit f40685c), we don't have to
> > work around lack of g_strcmp0() anymore.
> >
> > This reverts commit 8f4774789947bc4bc4c8d026a289fe980d3d2ee1.
> >
> > Conflicts:
> >       qemu-ga.c
> >
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> > ---
> >  qga/main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/qga/main.c b/qga/main.c
> > index 9939a2b..0b788e1 100644
> > --- a/qga/main.c
> > +++ b/qga/main.c
> > @@ -274,7 +274,7 @@ static void ga_log(const gchar *domain, GLogLevelFlags level,
> >  
> >      level &= G_LOG_LEVEL_MASK;
> >  #ifndef _WIN32
> > -    if (domain && strcmp(domain, "syslog") == 0) {
> > +    if (g_strcmp0(domain, "syslog") == 0) {
> >          syslog(LOG_INFO, "%s: %s", level_str, msg);
> >      } else if (level & s->log_level) {
> >  #else
> 

  parent reply	other threads:[~2015-07-07  1:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 17:53 [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage" Markus Armbruster
2015-05-28 19:04 ` John Snow
2015-06-16  6:34 ` Markus Armbruster
2015-06-18 11:55   ` [Qemu-trivial] " Markus Armbruster
2015-06-18 11:55     ` [Qemu-devel] " Markus Armbruster
2015-07-07  1:33   ` Michael Roth [this message]
2015-06-18 12:47 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150707013358.17393.64638@loki \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.