From: Michael Tokarev <mjt@tls.msk.ru>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage"
Date: Thu, 18 Jun 2015 15:47:42 +0300 [thread overview]
Message-ID: <5582BDEE.4070700@msgid.tls.msk.ru> (raw)
In-Reply-To: <1432749229-4861-1-git-send-email-armbru@redhat.com>
27.05.2015 20:53, Markus Armbruster wrote:
> Since we now require GLib 2.22+ (commit f40685c), we don't have to
> work around lack of g_strcmp0() anymore.
> qga/main.c | 2 +-
> - if (domain && strcmp(domain, "syslog") == 0) {
> + if (g_strcmp0(domain, "syslog") == 0) {
Why bother? To me the current version is easier to read,
it is traditional and working, while for g_strcmp0() I
have to look up documentation.
/mjt
prev parent reply other threads:[~2015-06-18 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 17:53 [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage" Markus Armbruster
2015-05-28 19:04 ` John Snow
2015-06-16 6:34 ` Markus Armbruster
2015-06-18 11:55 ` [Qemu-trivial] " Markus Armbruster
2015-06-18 11:55 ` [Qemu-devel] " Markus Armbruster
2015-07-07 1:33 ` Michael Roth
2015-06-18 12:47 ` Michael Tokarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5582BDEE.4070700@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=armbru@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.