From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/3] arm: psci: enable PSCI on UP systems
Date: Tue, 7 Jul 2015 15:16:58 +0100 [thread overview]
Message-ID: <20150707141658.GF4379@red-moon> (raw)
In-Reply-To: <1436014910-1201-3-git-send-email-jszhang@marvell.com>
On Sat, Jul 04, 2015 at 02:01:49PM +0100, Jisheng Zhang wrote:
> This is to make calls like eg cpu_suspend can be made functional on UP too.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> arch/arm/kernel/Makefile | 5 +----
> arch/arm/kernel/psci.c | 2 ++
> 2 files changed, 3 insertions(+), 4 deletions(-)
You will have to rewrite the commit log (mostly because PSCI CPU suspend
will move to drivers/firmware so it will become stale, I know what you
mean but it might be unclear to others so please improve it).
Patch (and intent) seems fine though:
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> diff --git a/arch/arm/kernel/Makefile b/arch/arm/kernel/Makefile
> index c57b2c0..2b1a60c 100644
> --- a/arch/arm/kernel/Makefile
> +++ b/arch/arm/kernel/Makefile
> @@ -88,9 +88,6 @@ obj-$(CONFIG_DEBUG_LL) += debug.o
> obj-$(CONFIG_EARLY_PRINTK) += early_printk.o
>
> obj-$(CONFIG_ARM_VIRT_EXT) += hyp-stub.o
> -ifeq ($(CONFIG_ARM_PSCI),y)
> -obj-y += psci-call.o
> -obj-$(CONFIG_SMP) += psci.o
> -endif
> +obj-$(CONFIG_ARM_PSCI) += psci-call.o psci.o
>
> extra-y := $(head-y) vmlinux.lds
> diff --git a/arch/arm/kernel/psci.c b/arch/arm/kernel/psci.c
> index 61c04b0..7f6ff02 100644
> --- a/arch/arm/kernel/psci.c
> +++ b/arch/arm/kernel/psci.c
> @@ -47,6 +47,7 @@
> *
> */
>
> +#ifdef CONFIG_SMP
> extern void secondary_startup(void);
>
> static int psci_boot_secondary(unsigned int cpu, struct task_struct *idle)
> @@ -128,3 +129,4 @@ struct smp_operations __initdata psci_smp_ops = {
> .cpu_kill = psci_cpu_kill,
> #endif
> };
> +#endif
> --
> 2.1.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
Will Deacon <Will.Deacon@arm.com>,
Mark Rutland <Mark.Rutland@arm.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 2/3] arm: psci: enable PSCI on UP systems
Date: Tue, 7 Jul 2015 15:16:58 +0100 [thread overview]
Message-ID: <20150707141658.GF4379@red-moon> (raw)
In-Reply-To: <1436014910-1201-3-git-send-email-jszhang@marvell.com>
On Sat, Jul 04, 2015 at 02:01:49PM +0100, Jisheng Zhang wrote:
> This is to make calls like eg cpu_suspend can be made functional on UP too.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> arch/arm/kernel/Makefile | 5 +----
> arch/arm/kernel/psci.c | 2 ++
> 2 files changed, 3 insertions(+), 4 deletions(-)
You will have to rewrite the commit log (mostly because PSCI CPU suspend
will move to drivers/firmware so it will become stale, I know what you
mean but it might be unclear to others so please improve it).
Patch (and intent) seems fine though:
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> diff --git a/arch/arm/kernel/Makefile b/arch/arm/kernel/Makefile
> index c57b2c0..2b1a60c 100644
> --- a/arch/arm/kernel/Makefile
> +++ b/arch/arm/kernel/Makefile
> @@ -88,9 +88,6 @@ obj-$(CONFIG_DEBUG_LL) += debug.o
> obj-$(CONFIG_EARLY_PRINTK) += early_printk.o
>
> obj-$(CONFIG_ARM_VIRT_EXT) += hyp-stub.o
> -ifeq ($(CONFIG_ARM_PSCI),y)
> -obj-y += psci-call.o
> -obj-$(CONFIG_SMP) += psci.o
> -endif
> +obj-$(CONFIG_ARM_PSCI) += psci-call.o psci.o
>
> extra-y := $(head-y) vmlinux.lds
> diff --git a/arch/arm/kernel/psci.c b/arch/arm/kernel/psci.c
> index 61c04b0..7f6ff02 100644
> --- a/arch/arm/kernel/psci.c
> +++ b/arch/arm/kernel/psci.c
> @@ -47,6 +47,7 @@
> *
> */
>
> +#ifdef CONFIG_SMP
> extern void secondary_startup(void);
>
> static int psci_boot_secondary(unsigned int cpu, struct task_struct *idle)
> @@ -128,3 +129,4 @@ struct smp_operations __initdata psci_smp_ops = {
> .cpu_kill = psci_cpu_kill,
> #endif
> };
> +#endif
> --
> 2.1.4
>
next prev parent reply other threads:[~2015-07-07 14:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-04 13:01 [RFC PATCH 0/3] arm: psci: implement cpuidle_ops Jisheng Zhang
2015-07-04 13:01 ` Jisheng Zhang
2015-07-04 13:01 ` [RFC PATCH 1/3] arm: psci: rename psci_smp.c to psci.c Jisheng Zhang
2015-07-04 13:01 ` Jisheng Zhang
2015-07-06 9:06 ` Daniel Lezcano
2015-07-06 9:06 ` Daniel Lezcano
2015-07-06 9:14 ` Jisheng Zhang
2015-07-06 9:14 ` Jisheng Zhang
2015-07-04 13:01 ` [RFC PATCH 2/3] arm: psci: enable PSCI on UP systems Jisheng Zhang
2015-07-04 13:01 ` Jisheng Zhang
2015-07-07 14:16 ` Lorenzo Pieralisi [this message]
2015-07-07 14:16 ` Lorenzo Pieralisi
2015-07-04 13:01 ` [RFC PATCH 3/3] arm: psci: add cpuidle_ops support Jisheng Zhang
2015-07-04 13:01 ` Jisheng Zhang
2015-07-07 14:23 ` Lorenzo Pieralisi
2015-07-07 14:23 ` Lorenzo Pieralisi
2015-07-08 6:46 ` Jisheng Zhang
2015-07-08 6:46 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707141658.GF4379@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.