* [PATCH] Fix typo in semanage args for minimum policy store
@ 2015-07-09 8:16 Petr Lautrbach
2015-07-09 10:04 ` Dominick Grift
0 siblings, 1 reply; 4+ messages in thread
From: Petr Lautrbach @ 2015-07-09 8:16 UTC (permalink / raw)
To: selinux
---
policycoreutils/semanage/semanage | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/policycoreutils/semanage/semanage b/policycoreutils/semanage/semanage
index dd63010..dd1010a 100644
--- a/policycoreutils/semanage/semanage
+++ b/policycoreutils/semanage/semanage
@@ -788,7 +788,7 @@ def createCommandParser():
def make_io_args(args):
# import/export backward compability
- args_origin = ["-S", "-o", "-i", "targeted", "minumum", "mls"]
+ args_origin = ["-S", "-o", "-i", "targeted", "minimum", "mls"]
args_file = []
args_ie = []
args_subcommand = []
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Fix typo in semanage args for minimum policy store
2015-07-09 8:16 [PATCH] Fix typo in semanage args for minimum policy store Petr Lautrbach
@ 2015-07-09 10:04 ` Dominick Grift
2015-07-09 10:49 ` Petr Lautrbach
0 siblings, 1 reply; 4+ messages in thread
From: Dominick Grift @ 2015-07-09 10:04 UTC (permalink / raw)
To: selinux
[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]
On Thu, Jul 09, 2015 at 10:16:16AM +0200, Petr Lautrbach wrote:
> ---
> policycoreutils/semanage/semanage | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/policycoreutils/semanage/semanage b/policycoreutils/semanage/semanage
> index dd63010..dd1010a 100644
> --- a/policycoreutils/semanage/semanage
> +++ b/policycoreutils/semanage/semanage
> @@ -788,7 +788,7 @@ def createCommandParser():
>
> def make_io_args(args):
> # import/export backward compability
> - args_origin = ["-S", "-o", "-i", "targeted", "minumum", "mls"]
> + args_origin = ["-S", "-o", "-i", "targeted", "minimum", "mls"]
Hard coding policy models is not very user friendly. Besides the minimum policy model is fedora specific.
> args_file = []
> args_ie = []
> args_subcommand = []
> --
> 2.4.3
>
> _______________________________________________
> Selinux mailing list
> Selinux@tycho.nsa.gov
> To unsubscribe, send email to Selinux-leave@tycho.nsa.gov.
> To get help, send an email containing "help" to Selinux-request@tycho.nsa.gov.
--
02DFF788
4D30 903A 1CF3 B756 FB48 1514 3148 83A2 02DF F788
http://keys.gnupg.net/pks/lookup?op=vindex&search=0x314883A202DFF788
Dominick Grift
[-- Attachment #2: Type: application/pgp-signature, Size: 648 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix typo in semanage args for minimum policy store
2015-07-09 10:04 ` Dominick Grift
@ 2015-07-09 10:49 ` Petr Lautrbach
2015-07-09 13:04 ` Stephen Smalley
0 siblings, 1 reply; 4+ messages in thread
From: Petr Lautrbach @ 2015-07-09 10:49 UTC (permalink / raw)
To: selinux
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
Dne 9.7.2015 v 12:04 Dominick Grift napsal(a):
> On Thu, Jul 09, 2015 at 10:16:16AM +0200, Petr Lautrbach wrote:
>> ---
>> policycoreutils/semanage/semanage | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/policycoreutils/semanage/semanage b/policycoreutils/semanage/semanage
>> index dd63010..dd1010a 100644
>> --- a/policycoreutils/semanage/semanage
>> +++ b/policycoreutils/semanage/semanage
>> @@ -788,7 +788,7 @@ def createCommandParser():
>>
>> def make_io_args(args):
>> # import/export backward compability
>> - args_origin = ["-S", "-o", "-i", "targeted", "minumum", "mls"]
>> + args_origin = ["-S", "-o", "-i", "targeted", "minimum", "mls"]
>
> Hard coding policy models is not very user friendly. Besides the minimum policy model is fedora specific.
>
You are right. The patch just fixes the typo which makes it unusable
even on Fedora.
Petr
--
Petr Lautrbach
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix typo in semanage args for minimum policy store
2015-07-09 10:49 ` Petr Lautrbach
@ 2015-07-09 13:04 ` Stephen Smalley
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Smalley @ 2015-07-09 13:04 UTC (permalink / raw)
To: Petr Lautrbach, selinux
On 07/09/2015 06:49 AM, Petr Lautrbach wrote:
> Dne 9.7.2015 v 12:04 Dominick Grift napsal(a):
>> On Thu, Jul 09, 2015 at 10:16:16AM +0200, Petr Lautrbach wrote:
>>> ---
>>> policycoreutils/semanage/semanage | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/policycoreutils/semanage/semanage b/policycoreutils/semanage/semanage
>>> index dd63010..dd1010a 100644
>>> --- a/policycoreutils/semanage/semanage
>>> +++ b/policycoreutils/semanage/semanage
>>> @@ -788,7 +788,7 @@ def createCommandParser():
>>>
>>> def make_io_args(args):
>>> # import/export backward compability
>>> - args_origin = ["-S", "-o", "-i", "targeted", "minumum", "mls"]
>>> + args_origin = ["-S", "-o", "-i", "targeted", "minimum", "mls"]
>>
>> Hard coding policy models is not very user friendly. Besides the minimum policy model is fedora specific.
>>
>
> You are right. The patch just fixes the typo which makes it unusable
> even on Fedora.
Agree that we ought to revisit this, but applied the patch to fix the
typo for now.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-09 13:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-09 8:16 [PATCH] Fix typo in semanage args for minimum policy store Petr Lautrbach
2015-07-09 10:04 ` Dominick Grift
2015-07-09 10:49 ` Petr Lautrbach
2015-07-09 13:04 ` Stephen Smalley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.