From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Timur Tabi <timur@tabi.org>,
Fabio Estevam <fabio.estevam@freescale.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ASoC: fsl: fsl_spdif: signedness bug in fsl_spdif_startup()
Date: Thu, 9 Jul 2015 07:59:47 -0700 [thread overview]
Message-ID: <20150709145946.GA5692@Asurada> (raw)
In-Reply-To: <20150709082103.GA13462@mwanda>
On Thu, Jul 09, 2015 at 11:21:03AM +0300, Dan Carpenter wrote:
> We need "i" to be signed or it leads to a forever loop in the error
> handling.
>
> Fixes: fa3be9208dcb ('ASoC: fsl: fsl_spdif: Check for clk_prepare_enable() error')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Thank you
> diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> index 3ee4539..7a92f30 100644
> --- a/sound/soc/fsl/fsl_spdif.c
> +++ b/sound/soc/fsl/fsl_spdif.c
> @@ -454,7 +454,8 @@ static int fsl_spdif_startup(struct snd_pcm_substream *substream,
> struct fsl_spdif_priv *spdif_priv = snd_soc_dai_get_drvdata(rtd->cpu_dai);
> struct platform_device *pdev = spdif_priv->pdev;
> struct regmap *regmap = spdif_priv->regmap;
> - u32 scr, mask, i;
> + u32 scr, mask;
> + int i;
> int ret;
>
> /* Reset module and interrupts only for first initialization */
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Timur Tabi <timur@tabi.org>,
Fabio Estevam <fabio.estevam@freescale.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ASoC: fsl: fsl_spdif: signedness bug in fsl_spdif_startup()
Date: Thu, 09 Jul 2015 14:59:47 +0000 [thread overview]
Message-ID: <20150709145946.GA5692@Asurada> (raw)
In-Reply-To: <20150709082103.GA13462@mwanda>
On Thu, Jul 09, 2015 at 11:21:03AM +0300, Dan Carpenter wrote:
> We need "i" to be signed or it leads to a forever loop in the error
> handling.
>
> Fixes: fa3be9208dcb ('ASoC: fsl: fsl_spdif: Check for clk_prepare_enable() error')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Thank you
> diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> index 3ee4539..7a92f30 100644
> --- a/sound/soc/fsl/fsl_spdif.c
> +++ b/sound/soc/fsl/fsl_spdif.c
> @@ -454,7 +454,8 @@ static int fsl_spdif_startup(struct snd_pcm_substream *substream,
> struct fsl_spdif_priv *spdif_priv = snd_soc_dai_get_drvdata(rtd->cpu_dai);
> struct platform_device *pdev = spdif_priv->pdev;
> struct regmap *regmap = spdif_priv->regmap;
> - u32 scr, mask, i;
> + u32 scr, mask;
> + int i;
> int ret;
>
> /* Reset module and interrupts only for first initialization */
next prev parent reply other threads:[~2015-07-09 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 8:21 [patch] ASoC: fsl: fsl_spdif: signedness bug in fsl_spdif_startup() Dan Carpenter
2015-07-09 8:21 ` Dan Carpenter
2015-07-09 14:59 ` Nicolin Chen [this message]
2015-07-09 14:59 ` Nicolin Chen
2015-07-15 11:55 ` Applied "ASoC: fsl: fsl_spdif: signedness bug in fsl_spdif_startup()" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709145946.GA5692@Asurada \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=fabio.estevam@freescale.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=perex@perex.cz \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.