From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Anurag Kumar Vulisha
<anurag.kumar.vulisha-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
punnaia-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
harinik-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
anirudh-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
svemula-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
Anurag Kumar Vulisha
<anuragku-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] i2c: removed work arounds in i2c driver for Zynq Ultrascale+ MPSoC
Date: Thu, 9 Jul 2015 22:09:13 +0200 [thread overview]
Message-ID: <20150709200913.GL4744@katana> (raw)
In-Reply-To: <1434644382-11905-1-git-send-email-anuragku-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
Hi,
thanks for the submission!
> +#define CDNS_I2C_BROKEN_HOLD_BIT 0x00000001
BIT(0) maybe?
> +static const struct cdns_platform_data r1p10_i2c_def = {
> + .quirks = CDNS_I2C_BROKEN_HOLD_BIT, };
Closing '}' should be on seperate line.
And what Mark said.
Other than that, looks okay I'd say.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: removed work arounds in i2c driver for Zynq Ultrascale+ MPSoC
Date: Thu, 9 Jul 2015 22:09:13 +0200 [thread overview]
Message-ID: <20150709200913.GL4744@katana> (raw)
In-Reply-To: <1434644382-11905-1-git-send-email-anuragku@xilinx.com>
Hi,
thanks for the submission!
> +#define CDNS_I2C_BROKEN_HOLD_BIT 0x00000001
BIT(0) maybe?
> +static const struct cdns_platform_data r1p10_i2c_def = {
> + .quirks = CDNS_I2C_BROKEN_HOLD_BIT, };
Closing '}' should be on seperate line.
And what Mark said.
Other than that, looks okay I'd say.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150709/9cf0edea/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, punnaia@xilinx.com,
harinik@xilinx.com, anirudh@xilinx.com, svemula@xilinx.com,
Anurag Kumar Vulisha <anuragku@xilinx.com>
Subject: Re: [PATCH] i2c: removed work arounds in i2c driver for Zynq Ultrascale+ MPSoC
Date: Thu, 9 Jul 2015 22:09:13 +0200 [thread overview]
Message-ID: <20150709200913.GL4744@katana> (raw)
In-Reply-To: <1434644382-11905-1-git-send-email-anuragku@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
Hi,
thanks for the submission!
> +#define CDNS_I2C_BROKEN_HOLD_BIT 0x00000001
BIT(0) maybe?
> +static const struct cdns_platform_data r1p10_i2c_def = {
> + .quirks = CDNS_I2C_BROKEN_HOLD_BIT, };
Closing '}' should be on seperate line.
And what Mark said.
Other than that, looks okay I'd say.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-07-09 20:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 16:19 [PATCH] i2c: removed work arounds in i2c driver for Zynq Ultrascale+ MPSoC Anurag Kumar Vulisha
2015-06-18 16:19 ` Anurag Kumar Vulisha
2015-06-18 16:19 ` Anurag Kumar Vulisha
[not found] ` <1434644382-11905-1-git-send-email-anuragku-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2015-06-25 15:18 ` Mark Rutland
2015-06-25 15:18 ` Mark Rutland
2015-06-25 15:18 ` Mark Rutland
2015-07-09 20:09 ` Wolfram Sang [this message]
2015-07-09 20:09 ` Wolfram Sang
2015-07-09 20:09 ` Wolfram Sang
2015-07-10 7:29 ` Anurag Kumar Vulisha
2015-07-10 7:29 ` Anurag Kumar Vulisha
2015-07-10 7:29 ` Anurag Kumar Vulisha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709200913.GL4744@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=anirudh-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=anurag.kumar.vulisha-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=anuragku-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=harinik-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=punnaia-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=svemula-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.