Re: [PATCH 1/2] ti-sysbios: Add version 6.41.04.54.

[Denys Dmytriyenko <denys@ti.com>]

Jake,

I think that was one of the long standing confusion - back in OpenEmbedded 
Classic days removing old version wasn't safe, as it could break someone 
else's build. So, people were advised to add new version they wanted, but send 
a separate patch that deleted the old one. If there was someone who used that 
specific old version, they could object to the second patch. That's why there 
used to be multiple versions of the same recipes all over the place. Now, with 
OpenEmbedded Core and the Yocto Project, the normal policy is to keep a single 
version of each recipe, where possible. Hence, updating recipe version is 
better done in a single patch, as it allows tracking recipe changes across 
versions with git log --follow flag. Other than that, I don't remember any 
other reason why would you want to do a version update in 2 separate patches. 
My position was always less strict - if you want 2 patches, then at least send 
them in right order, plus using -C --find-copies-harder flags would help with 
review, as it wouldn't look like 100% new file...

-- 
Denys


On Wed, Jul 08, 2015 at 06:51:57AM -0400, Jacob Stiffler wrote:
> I had once received a comment that it should be done this way:
> http://patchwork.dal.design.ti.com/patch/12482/
> 
> Let me know if I should resubmit this and the cgt6x patches.
> 
> On 7/7/2015 4:59 PM, Denys Dmytriyenko wrote:
> >Same comment/question about version update - any specific reason for 2
> >separate patches?
> >
> >
> >On Tue, Jul 07, 2015 at 08:29:14AM -0400, Jacob Stiffler wrote:
> >>Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> >>---
> >>  recipes-ti/bios/ti-sysbios_6.41.04.54.bb |   12 ++++++++++++
> >>  1 file changed, 12 insertions(+)
> >>  create mode 100644 recipes-ti/bios/ti-sysbios_6.41.04.54.bb
> >>
> >>diff --git a/recipes-ti/bios/ti-sysbios_6.41.04.54.bb b/recipes-ti/bios/ti-sysbios_6.41.04.54.bb
> >>new file mode 100644
> >>index 0000000..1e24fe1
> >>--- /dev/null
> >>+++ b/recipes-ti/bios/ti-sysbios_6.41.04.54.bb
> >>@@ -0,0 +1,12 @@
> >>+require ti-sysbios.inc
> >>+
> >>+PV = "6_41_04_54"
> >>+PR = "r0"
> >>+
> >>+LIC_FILES_CHKSUM = "file://bios_${PV}_manifest.html;md5=95c3c6050fb23f2755ab75bf76805190"
> >>+
> >>+SRC_URI[sysbiosbin.md5sum] = "cbc53f2b15c2f70e2eaa05c1ed90b8db"
> >>+SRC_URI[sysbiosbin.sha256sum] = "2b4fcb85af4c0abc46dadc925312b2a28906ec34db9b1500f0c484ee3fcb58cf"
> >>+
> >>+TI_BIN_UNPK_CMDS=""
> >>+TI_BIN_UNPK_ARGS = "--mode unattended --prefix ${WORKDIR}"
> >>-- 
> >>1.7.9.5
> >>
> >>-- 
> >>_______________________________________________
> >>meta-ti mailing list
> >>meta-ti@yoctoproject.org
> >>https://lists.yoctoproject.org/listinfo/meta-ti
>