Re: [PATCH 1/2] ti-sysbios: Add version 6.41.04.54.

[Denys Dmytriyenko <denys@ti.com>]

Jake,

Let me try to simplify... In order to efficiently review patches, I need to 
see the changes between the versions. There are 2 ways to do that:

1. Rename recipe to the new name (git-mv) and make the necessary changes. Then 
git-format-patch a single patch which will only have the actual changes.
This is a preferred way to do version upgrades if you don't need to keep old 
version around and maintain multple versions of the same recipe/component.

2. If you want, you can still do it in 2 patches - add new and remove old one. 
BUT, you should git-format-patch the first one with -C --find-copies-harder 
flags, so it would make the patch with new version *as a diff* against the old 
one, not a completely new one.

Since you already have this version upgrade as 2 commits, you don't need to 
rebase and squash them, just git-format-patch again with correct flags and 
resubmit. Thanks.

-- 
Denys


On Tue, Jul 28, 2015 at 11:16:28AM -0400, Jacob Stiffler wrote:
> Denys,
> 
> Were these not in the correct order? Add new version first, then
> remove the old version, correct?
> 
> Do you want me to resubmit these patch sets??
> 
> - Jake
> 
> On 7/9/2015 7:21 PM, Denys Dmytriyenko wrote:
> >Jake,
> >
> >I think that was one of the long standing confusion - back in OpenEmbedded
> >Classic days removing old version wasn't safe, as it could break someone
> >else's build. So, people were advised to add new version they wanted, but send
> >a separate patch that deleted the old one. If there was someone who used that
> >specific old version, they could object to the second patch. That's why there
> >used to be multiple versions of the same recipes all over the place. Now, with
> >OpenEmbedded Core and the Yocto Project, the normal policy is to keep a single
> >version of each recipe, where possible. Hence, updating recipe version is
> >better done in a single patch, as it allows tracking recipe changes across
> >versions with git log --follow flag. Other than that, I don't remember any
> >other reason why would you want to do a version update in 2 separate patches.
> >My position was always less strict - if you want 2 patches, then at least send
> >them in right order, plus using -C --find-copies-harder flags would help with
> >review, as it wouldn't look like 100% new file...
> >
>