From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Nitin Gupta <ngupta@vflare.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] zsmalloc: consider ZS_ALMOST_FULL as migrate source
Date: Fri, 10 Jul 2015 11:06:24 +0900 [thread overview]
Message-ID: <20150710020624.GB692@swordfish> (raw)
In-Reply-To: <1436491929-6617-1-git-send-email-minchan@kernel.org>
On (07/10/15 10:32), Minchan Kim wrote:
> static struct page *isolate_source_page(struct size_class *class)
> {
> struct page *page;
> + int i;
> + bool found = false;
>
why use 'bool found'? just return `page', which will be either NULL
or !NULL?
-ss
> - page = class->fullness_list[ZS_ALMOST_EMPTY];
> - if (page)
> - remove_zspage(page, class, ZS_ALMOST_EMPTY);
> + for (i = ZS_ALMOST_EMPTY; i >= ZS_ALMOST_FULL; i--) {
> + page = class->fullness_list[i];
> + if (!page)
> + continue;
>
> - return page;
> + remove_zspage(page, class, i);
> + found = true;
> + break;
> + }
> +
> + return found ? page : NULL;
> }
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Nitin Gupta <ngupta@vflare.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] zsmalloc: consider ZS_ALMOST_FULL as migrate source
Date: Fri, 10 Jul 2015 11:06:24 +0900 [thread overview]
Message-ID: <20150710020624.GB692@swordfish> (raw)
In-Reply-To: <1436491929-6617-1-git-send-email-minchan@kernel.org>
On (07/10/15 10:32), Minchan Kim wrote:
> static struct page *isolate_source_page(struct size_class *class)
> {
> struct page *page;
> + int i;
> + bool found = false;
>
why use 'bool found'? just return `page', which will be either NULL
or !NULL?
-ss
> - page = class->fullness_list[ZS_ALMOST_EMPTY];
> - if (page)
> - remove_zspage(page, class, ZS_ALMOST_EMPTY);
> + for (i = ZS_ALMOST_EMPTY; i >= ZS_ALMOST_FULL; i--) {
> + page = class->fullness_list[i];
> + if (!page)
> + continue;
>
> - return page;
> + remove_zspage(page, class, i);
> + found = true;
> + break;
> + }
> +
> + return found ? page : NULL;
> }
-ss
next prev parent reply other threads:[~2015-07-10 2:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 1:32 [PATCH] zsmalloc: consider ZS_ALMOST_FULL as migrate source Minchan Kim
2015-07-10 1:32 ` Minchan Kim
2015-07-10 1:58 ` Sergey Senozhatsky
2015-07-10 1:58 ` Sergey Senozhatsky
2015-07-10 2:29 ` Minchan Kim
2015-07-10 2:29 ` Minchan Kim
2015-07-10 4:19 ` Sergey Senozhatsky
2015-07-10 4:19 ` Sergey Senozhatsky
2015-07-10 5:21 ` Minchan Kim
2015-07-10 5:21 ` Minchan Kim
2015-07-10 5:34 ` Sergey Senozhatsky
2015-07-10 5:34 ` Sergey Senozhatsky
2015-07-10 2:06 ` Sergey Senozhatsky [this message]
2015-07-10 2:06 ` Sergey Senozhatsky
2015-07-10 2:34 ` Minchan Kim
2015-07-10 2:34 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710020624.GB692@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.