All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee.jones@linaro.org>,
	dmaengine@vger.kernel.org,
	Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
Date: Fri, 10 Jul 2015 08:26:11 +0000	[thread overview]
Message-ID: <20150710081411.GF836@localhost> (raw)
In-Reply-To: <CAMuHMdUTzTBT8DyRb5WN048U5DbVsFnhJB0c5tjHBnA4rfetJg@mail.gmail.com>

On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
> > The documentation already says these are physical addresses, and
> > we have concluded that any translation into the DMA address space
> > needs to reside in the dmaengine driver, so change the type of
> > the passed arguments.
> >
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Vinod Koul <vinod.koul@intel.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> 
> What's the status of this one, which has been acked by Lee and Arnd?
Looks to have slipped thru. I will redo it

-- 
~Vinod

> 
> Thanks!
> 
> > ---
> >  include/linux/dmaengine.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> > index 91ac8da..681df5f9 100644
> > --- a/include/linux/dmaengine.h
> > +++ b/include/linux/dmaengine.h
> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
> >   */
> >  struct dma_slave_config {
> >         enum dma_transfer_direction direction;
> > -       dma_addr_t src_addr;
> > -       dma_addr_t dst_addr;
> > +       phys_addr_t src_addr;
> > +       phys_addr_t dst_addr;
> >         enum dma_slave_buswidth src_addr_width;
> >         enum dma_slave_buswidth dst_addr_width;
> >         u32 src_maxburst;
> > --
> > 1.8.1.4
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee.jones@linaro.org>,
	dmaengine@vger.kernel.org,
	Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: use phys_addr_t for slave configuration
Date: Fri, 10 Jul 2015 13:44:11 +0530	[thread overview]
Message-ID: <20150710081411.GF836@localhost> (raw)
In-Reply-To: <CAMuHMdUTzTBT8DyRb5WN048U5DbVsFnhJB0c5tjHBnA4rfetJg@mail.gmail.com>

On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote:
> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
> > The documentation already says these are physical addresses, and
> > we have concluded that any translation into the DMA address space
> > needs to reside in the dmaengine driver, so change the type of
> > the passed arguments.
> >
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Vinod Koul <vinod.koul@intel.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> 
> What's the status of this one, which has been acked by Lee and Arnd?
Looks to have slipped thru. I will redo it

-- 
~Vinod

> 
> Thanks!
> 
> > ---
> >  include/linux/dmaengine.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> > index 91ac8da..681df5f9 100644
> > --- a/include/linux/dmaengine.h
> > +++ b/include/linux/dmaengine.h
> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth {
> >   */
> >  struct dma_slave_config {
> >         enum dma_transfer_direction direction;
> > -       dma_addr_t src_addr;
> > -       dma_addr_t dst_addr;
> > +       phys_addr_t src_addr;
> > +       phys_addr_t dst_addr;
> >         enum dma_slave_buswidth src_addr_width;
> >         enum dma_slave_buswidth dst_addr_width;
> >         u32 src_maxburst;
> > --
> > 1.8.1.4
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 

  reply	other threads:[~2015-07-10  8:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26  9:06 [PATCH] dmaengine: use phys_addr_t for slave configuration Linus Walleij
2013-04-26  9:14 ` Lee Jones
2013-04-26  9:40 ` Arnd Bergmann
2015-07-08 10:12 ` Geert Uytterhoeven
2015-07-08 10:12   ` Geert Uytterhoeven
2015-07-10  8:14   ` Vinod Koul [this message]
2015-07-10  8:26     ` Vinod Koul
2015-12-15 10:48     ` Geert Uytterhoeven
2015-12-15 10:48       ` Geert Uytterhoeven
2015-12-15 17:26       ` Vinod Koul
2015-12-15 17:38         ` Vinod Koul
2016-02-03 11:17         ` Geert Uytterhoeven
2016-02-03 11:17           ` Geert Uytterhoeven
2016-02-09 22:57           ` Wolfram Sang
2016-02-09 22:57             ` Wolfram Sang
2016-02-15 17:30             ` Vinod Koul
2016-02-15 17:30               ` Vinod Koul
2016-02-15 17:34               ` Wolfram Sang
2016-02-15 17:34                 ` Wolfram Sang
2016-02-16 20:42               ` Niklas Söderlund
2016-02-16 20:42                 ` Niklas Söderlund
2015-07-16  9:22   ` Linus Walleij
2015-07-16  9:22     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150710081411.GF836@localhost \
    --to=vinod.koul@intel.com \
    --cc=arnd@arndb.de \
    --cc=dmaengine@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.