All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-pm@vger.kernel.org,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	Krzysztof Kozlowski <k.kozlowski.k@gmail.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	linux-kernel@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
	Fabian Frederick <fabf@skynet.be>, Josh Wu <josh.wu@atmel.com>,
	Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	linux-arm-kernel@lists.infradead.org,
	David Woodhouse <dwmw2@infradead.org>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function
Date: Fri, 10 Jul 2015 14:46:20 +0200	[thread overview]
Message-ID: <20150710124620.GD3127@piout.net> (raw)
In-Reply-To: <20150710123148.GA28632@lukather>

On 10/07/2015 at 14:31:48 +0200, Maxime Ripard wrote :
> On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote:
> > Hi,
> > 
> > On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote :
> > > I would agree with Maxime. Currently all latest chip reset function is
> > > compatible with the atmel,sama5d3-rstc.
> > > So check compatible string is enough for now.
> > > But of cause if we have other incompatible reset in future with new chip,
> > > the structure like you said is needed.
> > 
> > We managed to avoid using of_machine_is_compatible() in all the at91
> > drivers. I'd like to keep it that way. It was painful enough to remove
> > all those cpu_is_at91xxx calls.
> 
> That's your call...
> 
> > Also, using it is trying to match strings and will result in longer boot
> > times.
> 
> Have you looked at the implementation of of_match_device? If that's
> really a concern to you, you should actually avoid it.
> 

Indeed, I misread. of_device_is_compatible is acceptable,
of_machine_is_compatible is not :)


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] power: reset: at91: add sama5d3 reset function
Date: Fri, 10 Jul 2015 14:46:20 +0200	[thread overview]
Message-ID: <20150710124620.GD3127@piout.net> (raw)
In-Reply-To: <20150710123148.GA28632@lukather>

On 10/07/2015 at 14:31:48 +0200, Maxime Ripard wrote :
> On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote:
> > Hi,
> > 
> > On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote :
> > > I would agree with Maxime. Currently all latest chip reset function is
> > > compatible with the atmel,sama5d3-rstc.
> > > So check compatible string is enough for now.
> > > But of cause if we have other incompatible reset in future with new chip,
> > > the structure like you said is needed.
> > 
> > We managed to avoid using of_machine_is_compatible() in all the at91
> > drivers. I'd like to keep it that way. It was painful enough to remove
> > all those cpu_is_at91xxx calls.
> 
> That's your call...
> 
> > Also, using it is trying to match strings and will result in longer boot
> > times.
> 
> Have you looked at the implementation of of_match_device? If that's
> really a concern to you, you should actually avoid it.
> 

Indeed, I misread. of_device_is_compatible is acceptable,
of_machine_is_compatible is not :)


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Josh Wu <josh.wu@atmel.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	linux-arm-kernel@lists.infradead.org,
	Guenter Roeck <linux@roeck-us.net>,
	Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <k.kozlowski.k@gmail.com>,
	Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Fabian Frederick <fabf@skynet.be>,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function
Date: Fri, 10 Jul 2015 14:46:20 +0200	[thread overview]
Message-ID: <20150710124620.GD3127@piout.net> (raw)
In-Reply-To: <20150710123148.GA28632@lukather>

On 10/07/2015 at 14:31:48 +0200, Maxime Ripard wrote :
> On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote:
> > Hi,
> > 
> > On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote :
> > > I would agree with Maxime. Currently all latest chip reset function is
> > > compatible with the atmel,sama5d3-rstc.
> > > So check compatible string is enough for now.
> > > But of cause if we have other incompatible reset in future with new chip,
> > > the structure like you said is needed.
> > 
> > We managed to avoid using of_machine_is_compatible() in all the at91
> > drivers. I'd like to keep it that way. It was painful enough to remove
> > all those cpu_is_at91xxx calls.
> 
> That's your call...
> 
> > Also, using it is trying to match strings and will result in longer boot
> > times.
> 
> Have you looked at the implementation of of_match_device? If that's
> really a concern to you, you should actually avoid it.
> 

Indeed, I misread. of_device_is_compatible is acceptable,
of_machine_is_compatible is not :)


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-07-10 12:46 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 10:15 [PATCH 1/2] power: reset: at91: add sama5d3 reset function Josh Wu
2015-07-09 10:15 ` Josh Wu
2015-07-09 10:15 ` Josh Wu
2015-07-09 10:15 ` [PATCH 2/2] ARM: at91: sama5/dt: update rstc to correct compatible string Josh Wu
2015-07-09 10:15   ` Josh Wu
2015-07-09 10:15   ` Josh Wu
2015-07-09 12:03 ` [PATCH 1/2] power: reset: at91: add sama5d3 reset function Maxime Ripard
2015-07-09 12:03   ` Maxime Ripard
2015-07-09 12:46   ` Nicolas Ferre
2015-07-09 12:46     ` Nicolas Ferre
2015-07-09 12:46     ` Nicolas Ferre
2015-07-10  3:06   ` Josh Wu
2015-07-10  3:06     ` Josh Wu
2015-07-10  3:06     ` Josh Wu
2015-07-10  6:54     ` Maxime Ripard
2015-07-10  6:54       ` Maxime Ripard
2015-07-10  7:59       ` Josh Wu
2015-07-10  7:59         ` Josh Wu
2015-07-10  7:59         ` Josh Wu
2015-07-09 17:37 ` Guenter Roeck
2015-07-09 17:37   ` Guenter Roeck
2015-07-10  1:59   ` Josh Wu
2015-07-10  1:59     ` Josh Wu
2015-07-10  1:59     ` Josh Wu
2015-07-10  3:14     ` Guenter Roeck
2015-07-10  3:14       ` Guenter Roeck
2015-07-10  3:52       ` Josh Wu
2015-07-10  3:52         ` Josh Wu
2015-07-10  3:52         ` Josh Wu
2015-07-10  5:56       ` Alexandre Belloni
2015-07-10  5:56         ` Alexandre Belloni
2015-07-10 17:01         ` Guenter
2015-07-10 17:01           ` Guenter
2015-07-10  6:03 ` Alexandre Belloni
2015-07-10  6:03   ` Alexandre Belloni
2015-07-10  6:58   ` Maxime Ripard
2015-07-10  6:58     ` Maxime Ripard
2015-07-10  7:56   ` Josh Wu
2015-07-10  7:56     ` Josh Wu
2015-07-10  7:56     ` Josh Wu
2015-07-10 12:09     ` Alexandre Belloni
2015-07-10 12:09       ` Alexandre Belloni
2015-07-10 12:31       ` Maxime Ripard
2015-07-10 12:31         ` Maxime Ripard
2015-07-10 12:46         ` Alexandre Belloni [this message]
2015-07-10 12:46           ` Alexandre Belloni
2015-07-10 12:46           ` Alexandre Belloni
2015-07-10 16:12         ` Nicolas Ferre
2015-07-10 16:12           ` Nicolas Ferre
2015-07-10 16:12           ` Nicolas Ferre
2015-07-13  3:21           ` Josh Wu
2015-07-13  3:21             ` Josh Wu
2015-07-13  3:21             ` Josh Wu
2015-07-20  7:52             ` Maxime Ripard
2015-07-20  7:52               ` Maxime Ripard
2015-07-20  8:35               ` Josh Wu
2015-07-20  8:35                 ` Josh Wu
2015-07-20  8:35                 ` Josh Wu
2015-07-20  8:38                 ` Nicolas Ferre
2015-07-20  8:38                   ` Nicolas Ferre
2015-07-20  8:38                   ` Nicolas Ferre
2015-07-20  8:44                 ` Josh Wu
2015-07-20  8:44                   ` Josh Wu
2015-07-20  8:44                   ` Josh Wu
2015-07-20  9:13                   ` Josh Wu
2015-07-20  9:13                     ` Josh Wu
2015-07-20  9:13                     ` Josh Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150710124620.GD3127@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=fabf@skynet.be \
    --cc=josh.wu@atmel.com \
    --cc=k.kozlowski.k@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=maxime.ripard@free-electrons.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=sre@kernel.org \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.