All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@poochiereds.net>
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	william@gandi.net
Subject: Re: [RFC PATCH 0/4] locks/nfs: fix use-after-free problem in unlock codepath
Date: Fri, 10 Jul 2015 17:21:51 -0400	[thread overview]
Message-ID: <20150710212151.GC7665@fieldses.org> (raw)
In-Reply-To: <20150710171426.082be2b0@tlielax.poochiereds.net>

On Fri, Jul 10, 2015 at 05:14:26PM -0400, Jeff Layton wrote:
> Thanks for testing, Bruce. Yeah at the very least we should get the
> first one in ASAP. The rest can probably wait for more thorough review.
> There is a real bug there, but I don't think people are hitting it
> regularly.

OK.  Free feel to add my tested-by: and/or reviewed-by: for those, they
are passing my tests and the patches look right to me....

--b.

WARNING: multiple messages have this Message-ID (diff)
From: "J. Bruce Fields" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
To: Jeff Layton <jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org>
Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	william-M8Sm6a3kpgNeoWH0uzbU5w@public.gmane.org
Subject: Re: [RFC PATCH 0/4] locks/nfs: fix use-after-free problem in unlock codepath
Date: Fri, 10 Jul 2015 17:21:51 -0400	[thread overview]
Message-ID: <20150710212151.GC7665@fieldses.org> (raw)
In-Reply-To: <20150710171426.082be2b0-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>

On Fri, Jul 10, 2015 at 05:14:26PM -0400, Jeff Layton wrote:
> Thanks for testing, Bruce. Yeah at the very least we should get the
> first one in ASAP. The rest can probably wait for more thorough review.
> There is a real bug there, but I don't think people are hitting it
> regularly.

OK.  Free feel to add my tested-by: and/or reviewed-by: for those, they
are passing my tests and the patches look right to me....

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-07-10 21:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-10 20:33 [RFC PATCH 0/4] locks/nfs: fix use-after-free problem in unlock codepath Jeff Layton
2015-07-10 20:33 ` Jeff Layton
2015-07-10 20:33 ` [RFC PATCH 1/4] Revert "nfs: take extra reference to fl->fl_file when running a LOCKU operation" Jeff Layton
2015-07-10 20:33   ` Jeff Layton
2015-07-10 20:51   ` Jeff Layton
2015-07-10 20:33 ` [RFC PATCH 2/4] locks: have flock_lock_file take an inode pointer instead of a filp Jeff Layton
2015-07-10 20:33 ` [RFC PATCH 3/4] locks: new helpers - flock_lock_inode_wait and posix_lock_inode_wait Jeff Layton
2015-07-10 20:33 ` [RFC PATCH 4/4] nfs4: have do_vfs_lock take an inode pointer Jeff Layton
2015-07-10 21:10 ` [RFC PATCH 0/4] locks/nfs: fix use-after-free problem in unlock codepath J. Bruce Fields
2015-07-10 21:10   ` J. Bruce Fields
2015-07-10 21:14   ` Jeff Layton
2015-07-10 21:14     ` Jeff Layton
2015-07-10 21:21     ` J. Bruce Fields [this message]
2015-07-10 21:21       ` J. Bruce Fields
2015-07-13 10:22 ` [PATCH 5/4] locks: inline posix_lock_file_wait and flock_lock_file_wait Jeff Layton
2015-07-13 10:22   ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150710212151.GC7665@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=jlayton@poochiereds.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=william@gandi.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.