All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: [patch 9/9] mfd/max899x: Avoid redundant irq_data lookup
Date: Mon, 13 Jul 2015 20:44:59 -0000	[thread overview]
Message-ID: <20150712225930.155347885@linutronix.de> (raw)
In-Reply-To: 20150712225758.573960291@linutronix.de

[-- Attachment #1: mfd-max899x-Avoid-redundant-irq-descriptor-lookup.patch --]
[-- Type: text/plain, Size: 2980 bytes --]

It's pretty silly to do

     irq_data *d = irq_get_irq_data(irq_data->irq);

because that results in d = irq_data, but goes through a lookup of the
irq_data. Use irq_data directly.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>
---
 drivers/mfd/max8997-irq.c |    7 +++----
 drivers/mfd/max8998-irq.c |    9 +++------
 2 files changed, 6 insertions(+), 10 deletions(-)

Index: tip/drivers/mfd/max8997-irq.c
===================================================================
--- tip.orig/drivers/mfd/max8997-irq.c
+++ tip/drivers/mfd/max8997-irq.c
@@ -140,9 +140,8 @@ static void max8997_irq_sync_unlock(stru
 }
 
 static const inline struct max8997_irq_data *
-irq_to_max8997_irq(struct max8997_dev *max8997, int irq)
+irq_to_max8997_irq(struct max8997_dev *max8997, struct irq_data *data)
 {
-	struct irq_data *data = irq_get_irq_data(irq);
 	return &max8997_irqs[data->hwirq];
 }
 
@@ -150,7 +149,7 @@ static void max8997_irq_mask(struct irq_
 {
 	struct max8997_dev *max8997 = irq_data_get_irq_chip_data(data);
 	const struct max8997_irq_data *irq_data = irq_to_max8997_irq(max8997,
-								data->irq);
+								     data);
 
 	max8997->irq_masks_cur[irq_data->group] |= irq_data->mask;
 }
@@ -159,7 +158,7 @@ static void max8997_irq_unmask(struct ir
 {
 	struct max8997_dev *max8997 = irq_data_get_irq_chip_data(data);
 	const struct max8997_irq_data *irq_data = irq_to_max8997_irq(max8997,
-								data->irq);
+								     data);
 
 	max8997->irq_masks_cur[irq_data->group] &= ~irq_data->mask;
 }
Index: tip/drivers/mfd/max8998-irq.c
===================================================================
--- tip.orig/drivers/mfd/max8998-irq.c
+++ tip/drivers/mfd/max8998-irq.c
@@ -98,9 +98,8 @@ static struct max8998_irq_data max8998_i
 };
 
 static inline struct max8998_irq_data *
-irq_to_max8998_irq(struct max8998_dev *max8998, int irq)
+irq_to_max8998_irq(struct max8998_dev *max8998, struct irq_data *data)
 {
-	struct irq_data *data = irq_get_irq_data(irq);
 	return &max8998_irqs[data->hwirq];
 }
 
@@ -134,8 +133,7 @@ static void max8998_irq_sync_unlock(stru
 static void max8998_irq_unmask(struct irq_data *data)
 {
 	struct max8998_dev *max8998 = irq_data_get_irq_chip_data(data);
-	struct max8998_irq_data *irq_data = irq_to_max8998_irq(max8998,
-							       data->irq);
+	struct max8998_irq_data *irq_data = irq_to_max8998_irq(max8998, data);
 
 	max8998->irq_masks_cur[irq_data->reg - 1] &= ~irq_data->mask;
 }
@@ -143,8 +141,7 @@ static void max8998_irq_unmask(struct ir
 static void max8998_irq_mask(struct irq_data *data)
 {
 	struct max8998_dev *max8998 = irq_data_get_irq_chip_data(data);
-	struct max8998_irq_data *irq_data = irq_to_max8998_irq(max8998,
-							       data->irq);
+	struct max8998_irq_data *irq_data = irq_to_max8998_irq(max8998, data);
 
 	max8998->irq_masks_cur[irq_data->reg - 1] |= irq_data->mask;
 }



  parent reply	other threads:[~2015-07-13 20:45 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13 20:44 [patch 0/9] mfd: Interrupt cleanups and API change preparation Thomas Gleixner
2015-07-13 20:44 ` [patch 1/9] mfd/ezx-pcap: Consolidate chained IRQ handler install/remove Thomas Gleixner
2015-07-27 15:56   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28  8:04   ` [patch 1/9] " Lee Jones
2015-07-13 20:44 ` [patch 2/9] mfd/htc-egpio: " Thomas Gleixner
2015-07-27 15:56   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28  8:04   ` [patch 2/9] " Lee Jones
2015-07-13 20:44 ` [patch 3/9] mfd/jz4740: " Thomas Gleixner
2015-07-27 15:57   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28  8:04   ` [patch 3/9] " Lee Jones
2015-07-13 20:44 ` [patch 4/9] mfd/pm8921: " Thomas Gleixner
2015-07-27 15:57   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28  8:05   ` [patch 4/9] " Lee Jones
2015-07-13 20:44 ` [patch 5/9] mfd/t7l66xb: " Thomas Gleixner
2015-07-27 15:57   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28  8:05   ` [patch 5/9] " Lee Jones
2015-07-13 20:44 ` [patch 6/9] mfd/tc6393xb: " Thomas Gleixner
2015-07-27 15:58   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28  8:05   ` [patch 6/9] " Lee Jones
2015-07-13 20:44 ` [patch 7/9] mfd: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc Thomas Gleixner
2015-07-27 15:58   ` [tip:irq/core] " tip-bot for Jiang Liu
2015-07-28  8:05   ` [patch 7/9] " Lee Jones
2015-07-13 20:44 ` [patch 8/9] mfd/ucb1x00: Prepare ucb1x00_irq for irq argument removal Thomas Gleixner
2015-07-27 15:58   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28  8:06   ` [patch 8/9] " Lee Jones
2015-07-13 20:44 ` Thomas Gleixner [this message]
2015-07-27 15:59   ` [tip:irq/core] mfd/max899x: Avoid redundant irq_data lookup tip-bot for Thomas Gleixner
2015-07-28  8:06   ` [patch 9/9] " Lee Jones
2015-07-27 16:20 ` [patch 0/9] mfd: Interrupt cleanups and API change preparation Lee Jones
2015-07-28  8:17 ` Lee Jones
2015-07-28  8:42   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150712225930.155347885@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=jiang.liu@linux.intel.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.