From: tip-bot for Thomas Gleixner <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, lee.jones@linaro.org, sameo@linux.intel.com,
jiang.liu@linux.intel.com, hpa@zytor.com, Julia.Lawall@lip6.fr,
linux-kernel@vger.kernel.org, mingo@kernel.org,
rmk+kernel@arm.linux.org.uk
Subject: [tip:irq/core] mfd/tc6393xb: Consolidate chained IRQ handler install/remove
Date: Mon, 27 Jul 2015 08:58:07 -0700 [thread overview]
Message-ID: <tip-e66cf89a3341f85ac73110aec31c5b8cc8dd7a0d@git.kernel.org> (raw)
In-Reply-To: <20150712225929.902434148@linutronix.de>
Commit-ID: e66cf89a3341f85ac73110aec31c5b8cc8dd7a0d
Gitweb: http://git.kernel.org/tip/e66cf89a3341f85ac73110aec31c5b8cc8dd7a0d
Author: Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Mon, 13 Jul 2015 20:44:54 +0000
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 27 Jul 2015 13:36:38 +0200
mfd/tc6393xb: Consolidate chained IRQ handler install/remove
Chained irq handlers usually set up handler data as well. We now have
a function to set both under irq_desc->lock. Replace the two calls
with one.
Search and conversion was done with coccinelle.
Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Link: http://lkml.kernel.org/r/20150712225929.902434148@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/mfd/tc6393xb.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
index 63458b3..6288383 100644
--- a/drivers/mfd/tc6393xb.c
+++ b/drivers/mfd/tc6393xb.c
@@ -590,8 +590,8 @@ static void tc6393xb_attach_irq(struct platform_device *dev)
}
irq_set_irq_type(tc6393xb->irq, IRQ_TYPE_EDGE_FALLING);
- irq_set_handler_data(tc6393xb->irq, tc6393xb);
- irq_set_chained_handler(tc6393xb->irq, tc6393xb_irq);
+ irq_set_chained_handler_and_data(tc6393xb->irq, tc6393xb_irq,
+ tc6393xb);
}
static void tc6393xb_detach_irq(struct platform_device *dev)
@@ -599,8 +599,7 @@ static void tc6393xb_detach_irq(struct platform_device *dev)
struct tc6393xb *tc6393xb = platform_get_drvdata(dev);
unsigned int irq, irq_base;
- irq_set_chained_handler(tc6393xb->irq, NULL);
- irq_set_handler_data(tc6393xb->irq, NULL);
+ irq_set_chained_handler_and_data(tc6393xb->irq, NULL, NULL);
irq_base = tc6393xb->irq_base;
next prev parent reply other threads:[~2015-07-27 15:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 20:44 [patch 0/9] mfd: Interrupt cleanups and API change preparation Thomas Gleixner
2015-07-13 20:44 ` [patch 1/9] mfd/ezx-pcap: Consolidate chained IRQ handler install/remove Thomas Gleixner
2015-07-27 15:56 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28 8:04 ` [patch 1/9] " Lee Jones
2015-07-13 20:44 ` [patch 2/9] mfd/htc-egpio: " Thomas Gleixner
2015-07-27 15:56 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28 8:04 ` [patch 2/9] " Lee Jones
2015-07-13 20:44 ` [patch 3/9] mfd/jz4740: " Thomas Gleixner
2015-07-27 15:57 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28 8:04 ` [patch 3/9] " Lee Jones
2015-07-13 20:44 ` [patch 4/9] mfd/pm8921: " Thomas Gleixner
2015-07-27 15:57 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28 8:05 ` [patch 4/9] " Lee Jones
2015-07-13 20:44 ` [patch 5/9] mfd/t7l66xb: " Thomas Gleixner
2015-07-27 15:57 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28 8:05 ` [patch 5/9] " Lee Jones
2015-07-13 20:44 ` [patch 6/9] mfd/tc6393xb: " Thomas Gleixner
2015-07-27 15:58 ` tip-bot for Thomas Gleixner [this message]
2015-07-28 8:05 ` Lee Jones
2015-07-13 20:44 ` [patch 7/9] mfd: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc Thomas Gleixner
2015-07-27 15:58 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-07-28 8:05 ` [patch 7/9] " Lee Jones
2015-07-13 20:44 ` [patch 8/9] mfd/ucb1x00: Prepare ucb1x00_irq for irq argument removal Thomas Gleixner
2015-07-27 15:58 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28 8:06 ` [patch 8/9] " Lee Jones
2015-07-13 20:44 ` [patch 9/9] mfd/max899x: Avoid redundant irq_data lookup Thomas Gleixner
2015-07-27 15:59 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2015-07-28 8:06 ` [patch 9/9] " Lee Jones
2015-07-27 16:20 ` [patch 0/9] mfd: Interrupt cleanups and API change preparation Lee Jones
2015-07-28 8:17 ` Lee Jones
2015-07-28 8:42 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-e66cf89a3341f85ac73110aec31c5b8cc8dd7a0d@git.kernel.org \
--to=tipbot@zytor.com \
--cc=Julia.Lawall@lip6.fr \
--cc=hpa@zytor.com \
--cc=jiang.liu@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sameo@linux.intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.