From: Mike Snitzer <snitzer@redhat.com>
To: Milan Broz <mbroz@redhat.com>
Cc: Joseph Salisbury <joseph.salisbury@canonical.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org, JBottomley@Parallels.com,
Kernel Team <kernel-team@lists.ubuntu.com>,
jgarzik@redhat.com
Subject: Re: dm-crypt: never use write same (was Re: [v3.7 Regression] [SCSI] sd: Implement support for WRITE SAME)
Date: Mon, 13 Jul 2015 14:01:55 -0400 [thread overview]
Message-ID: <20150713180155.GD30898@redhat.com> (raw)
In-Reply-To: <55A3EEF3.9080106@redhat.com>
On Mon, Jul 13 2015 at 1:01pm -0400,
Milan Broz <mbroz@redhat.com> wrote:
> (sorry, resending again, not sure if it was sent correctly)
>
> On 07/13/2015 06:33 PM, Joseph Salisbury wrote:
> > Hi Milan,
> >
> > The Ubuntu kernel has been carrying this patch since the discussion[0]
> > we were having about the bug. I don't see that patch was ever included
> > in mainline. Do you happen to know if this patch is still needed or was
> > the bug we were seeing fixed in some other way?
>
> I think it was superseded by later Mike's approach to reverse the logic
> - disable write same for all targets and require to explicitly allow it.
>
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/md/dm-table.c?id=c1a94672a830e01d58c7c7e8de530c3f136d6ff2
> (+later patches)
>
> So I think we do no need this patch upstream anymore.
>
> Mike, am I right here?
Yeah, a DM target needs to opt-in by setting ti->num_write_same_bios
(only linear, stripe and mpath do at this time).
next prev parent reply other threads:[~2015-07-13 18:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 20:30 [v3.7 Regression] [SCSI] sd: Implement support for WRITE SAME Joseph Salisbury
2012-12-14 21:11 ` Mike Snitzer
2012-12-15 2:38 ` Joseph Salisbury
2012-12-14 22:35 ` Martin K. Petersen
2012-12-15 2:40 ` Joseph Salisbury
2012-12-18 19:52 ` Joseph Salisbury
2012-12-19 16:58 ` Martin K. Petersen
2012-12-19 19:58 ` Mike Snitzer
2012-12-19 19:59 ` Joseph Salisbury
2012-12-19 20:45 ` Martin K. Petersen
2012-12-19 20:45 ` Martin K. Petersen
2012-12-19 20:45 ` Milan Broz
2012-12-19 21:07 ` [PATCH] dm-crypt: never use write same (was Re: [v3.7 Regression] [SCSI] sd: Implement support for WRITE SAME) Milan Broz
2012-12-19 21:07 ` Joseph Salisbury
2012-12-19 22:20 ` Joseph Salisbury
2012-12-19 22:23 ` Milan Broz
2015-07-13 16:33 ` Joseph Salisbury
2015-07-13 16:59 ` Milan Broz
2015-07-13 17:01 ` Milan Broz
2015-07-13 18:01 ` Mike Snitzer [this message]
2012-12-20 0:11 ` Martin K. Petersen
2012-12-20 5:47 ` Mike Snitzer
2012-12-20 5:57 ` [PATCH 1/4] dm: default to disabling WRITE SAME support for all targets Mike Snitzer
2012-12-20 5:57 ` [PATCH 2/4] dm: add WRITE SAME support Mike Snitzer
2012-12-20 5:57 ` [PATCH 3/4] dm linear: " Mike Snitzer
2012-12-20 5:57 ` [PATCH 4/4] dm stripe: " Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713180155.GD30898@redhat.com \
--to=snitzer@redhat.com \
--cc=JBottomley@Parallels.com \
--cc=jgarzik@redhat.com \
--cc=joseph.salisbury@canonical.com \
--cc=kernel-team@lists.ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mbroz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.